From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939F6C021A4 for ; Thu, 13 Feb 2025 20:43:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF238280002; Thu, 13 Feb 2025 15:43:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA27C280001; Thu, 13 Feb 2025 15:43:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6A1D280002; Thu, 13 Feb 2025 15:43:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 94ABB280001 for ; Thu, 13 Feb 2025 15:43:19 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 46A15B204C for ; Thu, 13 Feb 2025 20:43:19 +0000 (UTC) X-FDA: 83116096518.10.721CB30 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf22.hostedemail.com (Postfix) with ESMTP id 7233DC0005 for ; Thu, 13 Feb 2025 20:43:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=k0oo+WFd; spf=pass (imf22.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739479397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oyemEw81pWbLqSEfnWgxTxqNENdan3L9LXfa4tOcR7A=; b=zPXkZNwnQuwwUaVJQG2xs/YHA99AAdRCPwjDtBtnc8OTX0G8V/nISn7h0PDAZRPLYx0Cvr jAlzadoo8uddn1XxGTPrYr0iozaMqnQUIgL3FLIKIflsVtLcaFfo1V2J5I6HGtzj/B866g kKVmUrgNg5yWRq9ToccHcgSULsQpb+I= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=k0oo+WFd; spf=pass (imf22.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739479397; a=rsa-sha256; cv=none; b=rZDVFcEGMawS4Ly5Dm1L3UNP86p+yV9gL3qW3FK0DonEgvm1uvQUc7297ThtAslToqkQd+ m2piG0CmFHT1DjDoVS03lLHiy97gHKg6aP7L1nMqMKy8B2W4an8kurFI40/X5+bWr9TcDU ps79IN8htQyM63IkyY0uvHdf5RyIWPY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739479396; x=1771015396; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oyemEw81pWbLqSEfnWgxTxqNENdan3L9LXfa4tOcR7A=; b=k0oo+WFdZqVCk29OPyi3tSoShBu2am7WRbbmoxNk4qeMMQpmSorXEv/D ChqiKWSYJlJlxLNpYE9IcxT9oa/J7otKXjxJdWcsulx2ITK7aN4rAOWx9 sIqedymCmKCbjipnXb9iFLM6V+rJwi05EFIWMLpCkdkgFo7qL8oIjD3oA hgwK9w5CFvh70SN+e+0dEeXYec2eHX4OfvmzJp89Bk3kS/+jKEvDXGkVZ JOJwvbtFpQh3OuvLHbqBw5ZL0P4pDCUUaI3OQHglBBPYLGnHY+zx3/fif uFyozBp7Z0fEM6iY1DXlnzAnDWpcpyThV1RHcyJ7mZS9Ovp7F5NyNUCxA w==; X-CSE-ConnectionGUID: 313CvV+EQVObBReFS4KeVw== X-CSE-MsgGUID: BzgpugY2Thiak8MFSyk2kg== X-IronPort-AV: E=McAfee;i="6700,10204,11344"; a="40069857" X-IronPort-AV: E=Sophos;i="6.13,282,1732608000"; d="scan'208";a="40069857" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2025 12:43:15 -0800 X-CSE-ConnectionGUID: cAuQYfQ0QRqm/4fMp4s6pQ== X-CSE-MsgGUID: wNctjx5dSraAM2lUEVTAIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,282,1732608000"; d="scan'208";a="118269684" Received: from iherna2-mobl4.amr.corp.intel.com (HELO [10.125.108.188]) ([10.125.108.188]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2025 12:43:14 -0800 Message-ID: <04adffd9-2900-4cdb-a557-1c486a87b522@intel.com> Date: Thu, 13 Feb 2025 12:43:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND 1/2] x86/locking: Use ALT_OUTPUT_SP() for percpu_{,try_}cmpxchg{64,128}_op() To: Uros Bizjak , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Dennis Zhou , Tejun Heo , Christoph Lameter , "Peter Zijlstra (Intel)" References: <20250213191457.12377-1-ubizjak@gmail.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250213191457.12377-1-ubizjak@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7233DC0005 X-Stat-Signature: ktbp5ui9aeijak6mguqfunzg1bno116t X-HE-Tag: 1739479396-561562 X-HE-Meta: U2FsdGVkX1/UP6WT/MPzvV1QL4wmIYM4ooQsrtxdwpUYNK7J0mNDRdTecPVQLm0lxRfVEgHcdi4bJIyhPZIbOquoNbKGyqXph/QY/CAQV75JXoLMfhCcsoZtas1MxUPlWyWXyOyPLvjrC8F+GVFlhtR07pyzPAt6j0USv9e5rGQceudIF7xT3rce564U3Rd4zdIYNwuzSMFW6tvyy1kI0P6pLPsq82SeN70x0s43m+gjpv2gxWSgaSOK8acHdmyoRtHGE6IC4/xSAoWvq43AWDX4vm/hKiSAA1YTLcMADwWDEyQB1/tVDyUKH9rVXm5av1a4Pn6+IMOiA7IclLq0V5+d7WXUQQ6JMIdR6R+eKm6ejD6+y0msXc9odtq2KGSPSINUnl+YPBl44UEKYTJE83die79BMuyTtgexOHtovZucwRNQAXySdYJEL4kfSv6WCqKqklOaEFaIYotou67t3FMnlSinJHVOogBpR3UyRmR35j5MH7Rp8iBLdVWX8GYwph86cZMIBnLp0LnO/eBeTYnZNYQgK2RpQ7eG/3qMDbrUIf4e//8etQsYe8AXKv0vwviXUyQjQ26VY0ELWLLW+BqOmePpNMHa5S/nY4FaQZSeqrsN12ePli5Z8ILLuIKSugg7xzjegHMxrk+i6+I5udzK748LR4ubcXzEU2DmRQn+yoSJ3JQc9JK/awV1ntLuY1toK8JGHLhXwV5nJzviusdJSLgpHudOREFrMfDK2FQivqlUL9My+f8mfyXUVl5jXpsqkZpCxDHcJAz6pLQHFyGT5JJRawWMPAuY4mu6wxhsUeT+58LX14hv4Yk/pm36lTcdafeNI7xrmraLxrRAIEUjV4FJthF3nueoaXBvEfeEx6QLel60HyoWnuL3NRtvlqx+N1atm8hoL140XDDxc7OEOP6uqPh1Mz6Qhk2wbXvzM+orAg8YtpsFu8h1Q9+bNEQuXbUNcVRLbyh2SPT x35UJEP1 hmBdNxeZjs+hXt/mu2Zg5yPXKRlUEnXM5K4DUxeBE+EeL8hXxAfQeooKuGj0lDw1Zu3zBPmzbPAY9KAyaeG2p1Vc00hNlc/wAMpkl0VUnnS+owGUkGfit87XM0G95zyMzKh/pZkOuShPLF+Nd/MNutCPQKEghEi8ABROLrmM0EseiXNNgukecMnrG5NWpl5Cr8saHT3YIfhYLA16sblU0SOXj6013MMDJ5iWnAkHo7OR8TWtKuqKV2B+xIZuPUa1WmlqG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 11:14, Uros Bizjak wrote: > percpu_{,try_}cmpxchg{64,128}() macros use CALL instruction inside > asm statement in one of their alternatives. Use ALT_OUTPUT_SP() > macro to add required dependence on %esp register. Is this just a pedantic fix? Or is there an actual impact to end users that needs to be considered? Basically, you've told me what the patch does, but not why anyone should care or why it should be applied.