From: Dave Hansen <dave.hansen@intel.com>
To: Uros Bizjak <ubizjak@gmail.com>,
x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Dennis Zhou <dennis@kernel.org>,
Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [PATCH RESEND 1/2] x86/locking: Use ALT_OUTPUT_SP() for percpu_{,try_}cmpxchg{64,128}_op()
Date: Thu, 13 Feb 2025 12:43:13 -0800 [thread overview]
Message-ID: <04adffd9-2900-4cdb-a557-1c486a87b522@intel.com> (raw)
In-Reply-To: <20250213191457.12377-1-ubizjak@gmail.com>
On 2/13/25 11:14, Uros Bizjak wrote:
> percpu_{,try_}cmpxchg{64,128}() macros use CALL instruction inside
> asm statement in one of their alternatives. Use ALT_OUTPUT_SP()
> macro to add required dependence on %esp register.
Is this just a pedantic fix? Or is there an actual impact to end users
that needs to be considered?
Basically, you've told me what the patch does, but not why anyone should
care or why it should be applied.
next prev parent reply other threads:[~2025-02-13 20:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 19:14 Uros Bizjak
2025-02-13 19:14 ` [PATCH RESEND 2/2] x86/locking: Use asm_inline for {,try_}cmpxchg{64,128} emulations Uros Bizjak
2025-02-13 20:48 ` Dave Hansen
2025-02-13 22:13 ` Uros Bizjak
2025-02-13 22:52 ` Dave Hansen
2025-02-14 7:25 ` Uros Bizjak
2025-02-13 20:43 ` Dave Hansen [this message]
2025-02-13 21:17 ` [PATCH RESEND 1/2] x86/locking: Use ALT_OUTPUT_SP() for percpu_{,try_}cmpxchg{64,128}_op() Uros Bizjak
2025-02-13 22:54 ` Dave Hansen
2025-02-14 18:22 ` Christoph Lameter (Ampere)
2025-02-14 19:55 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04adffd9-2900-4cdb-a557-1c486a87b522@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=cl@linux.com \
--cc=dave.hansen@linux.intel.com \
--cc=dennis@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox