From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612ACC32772 for ; Tue, 23 Aug 2022 14:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C518E8D0002; Tue, 23 Aug 2022 10:04:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C00498D0001; Tue, 23 Aug 2022 10:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC9338D0002; Tue, 23 Aug 2022 10:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9D9348D0001 for ; Tue, 23 Aug 2022 10:04:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6A9AF140B4D for ; Tue, 23 Aug 2022 14:04:53 +0000 (UTC) X-FDA: 79831028466.20.B79732C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id A3109C007D for ; Tue, 23 Aug 2022 14:04:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E7152224A5; Tue, 23 Aug 2022 14:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661263490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CD2l+I4MjMw0C0NBz+C57caAVjEFsSwQ3UTNjf+/spY=; b=sKLpVxYTCFCzey+bXYirzI2nbMxT0IYTquNrqguhNiiE6MT21Ae+d+HsWWNZu6elEZkXd5 /75ZgG1c6s7Y3j1dOsPksjTdxygCq4oj0sEzepx6bEGbUA1yiURVubdNzeOvlGcViwiCFN /ivpUxhpDntQFz2WfKrZfL1EfHMmM5Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661263490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CD2l+I4MjMw0C0NBz+C57caAVjEFsSwQ3UTNjf+/spY=; b=gp14rMbaORLZCoNIRXyN7Ael/iuuDMsMhhsT/RaYpp7/I4NIGO9V8QEXN3msc0rvONKwNG yMyXbNMdZvY//gDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB0BF13AB7; Tue, 23 Aug 2022 14:04:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Tl8tKILeBGPhdQAAMHmgww (envelope-from ); Tue, 23 Aug 2022 14:04:50 +0000 Message-ID: <04adfdfd-8907-fd26-06cd-bb03f39eeed8@suse.cz> Date: Tue, 23 Aug 2022 16:04:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH linux-next] mm/slab_common: Remove the unneeded result variable Content-Language: en-US To: cgel.zte@gmail.com, 42.hyeyoo@gmail.com Cc: cl@linux.com, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot References: <20220823075241.209009-1-ye.xingchen@zte.com.cn> From: Vlastimil Babka In-Reply-To: <20220823075241.209009-1-ye.xingchen@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661263492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CD2l+I4MjMw0C0NBz+C57caAVjEFsSwQ3UTNjf+/spY=; b=ioP+YQDevRKzdom8x0iWMfDoPWFi9JQU7RppORYfY0a55ZuJvZ4Nq/Rw8eZlb9t1g429st xhj/a9r6mU5nGenqmj/c5V8hIM9R82/brO8cSusUo+As6RAdMY9TYhAwSzdRgAI8Q164HB 7nEZZhM39+plHPjEuqJUp0M4eC7RCsY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sKLpVxYT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gp14rMba; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661263492; a=rsa-sha256; cv=none; b=fjBlIdMlLqVEgkFE+4FisKhlAmp/vo6226z6VxJ69QCKkV4u1qq40YcIIDcjxPpn5z3PeG zVIAiEcrZRuuLfFx7PZsPg7FuFRrGX/N4pqABegfeRJK+K18tc+/HwBxATXLJxF/vT0fRe 4o+XaRaqVV8jB+/hYHhEEcUkwK6B354= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A3109C007D X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sKLpVxYT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gp14rMba; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: xshx3f66m7qnep6a93r5uuqc3tou6drb X-HE-Tag: 1661263492-465149 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/23/22 09:52, cgel.zte@gmail.com wrote: > From: ye xingchen > > Return the value from __kmem_cache_shrink() directly instead of storing it > in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: ye xingchen Thanks, added to slab.git for-6.1/trivial > --- > mm/slab_common.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 17996649cfe3..0dfa3cfb6be5 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -495,13 +495,9 @@ EXPORT_SYMBOL(kmem_cache_destroy); > */ > int kmem_cache_shrink(struct kmem_cache *cachep) > { > - int ret; > - > - > kasan_cache_shrink(cachep); > - ret = __kmem_cache_shrink(cachep); > > - return ret; > + return __kmem_cache_shrink(cachep); > } > EXPORT_SYMBOL(kmem_cache_shrink); >