From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61174E7719E for ; Mon, 13 Jan 2025 10:09:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA7306B009B; Mon, 13 Jan 2025 05:09:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D57766B009C; Mon, 13 Jan 2025 05:09:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF9286B009D; Mon, 13 Jan 2025 05:09:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A27956B009B for ; Mon, 13 Jan 2025 05:09:58 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BC827A1CE5 for ; Mon, 13 Jan 2025 10:09:57 +0000 (UTC) X-FDA: 83002007634.23.5896CF0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 3DFE9C000E for ; Mon, 13 Jan 2025 10:09:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K7tOPXWD; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736762995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UgUwpDhKMZgZxc1OL57CQ0iiOYpTsrgXRg+FEB3T4QQ=; b=6OczkOI7v/bg/4BasoN2SDO7gTUbfEoEZM3E2wv0Lw/TAlgh8JE++xCb2wIV1Jn6QMWaDs gLbaxqJZkh8MxA9H2dS5xQKag9WfsL7BZ+ioBdaSKyrp2Mo7oB7U4kLb2PjC0D5gYFa98e mVXZB33ft2fMMmvPGpSLwCkC4dIV5E8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736762995; a=rsa-sha256; cv=none; b=0EIh/IbnAU1O2Gf4lJ1qMOPrjSTrm+jZX43HC3zQrCtkf/c8RVT6qOGI6Of/CQUM0qrXiC hXa0HVeItVwNDWzuIPxl8UtDZWr8gZdxuUhx6HdwN/DHJjyh9hIJPGkLblyftVe/agOprc Jja5CdsDoGvMK0PtEYf9gSaIJwdxP3w= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K7tOPXWD; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736762994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UgUwpDhKMZgZxc1OL57CQ0iiOYpTsrgXRg+FEB3T4QQ=; b=K7tOPXWD/kdPx3XgjXpApqR+q4xFJVjkml+RiRd8PnQ+iOClpAcLa0Jr7Ns2f/ff/X8g73 jm3x5HM2e9MuzETcZlJNRWmJXiYRrvz0KgnDhKFHLQ4Tnm6HJg27kX3fH1T8RkUdFZS9m1 YnNaBhPb4bz6WTonmcUMnVQGXSPIzLA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-Ah9X4gZfOmGf-RP_ps1vcQ-1; Mon, 13 Jan 2025 05:09:51 -0500 X-MC-Unique: Ah9X4gZfOmGf-RP_ps1vcQ-1 X-Mimecast-MFC-AGG-ID: Ah9X4gZfOmGf-RP_ps1vcQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38a684a096eso1483154f8f.2 for ; Mon, 13 Jan 2025 02:09:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736762990; x=1737367790; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UgUwpDhKMZgZxc1OL57CQ0iiOYpTsrgXRg+FEB3T4QQ=; b=mjqeQmNht/KrW4YU2ghI2zvG7Apzm6Pv/11syUOihq3tOiW9g8GObSVR/T/WqREnzW CoIwJmFeAwkoZlnysLMUKfI0Z14vewxztSxch2iomWQbA2iSbzqgChrsZUKH3VipjdfF zZA/bU0LJz98r9qyxFi6DbmhokWMtDKlykcHMI8cxapZuIhmb7Z/9RcauHSGClEFkBeJ j8qJkx0JGA2h213ORdmy19Z7899bgXNhtEory8ZyetvY4SRWQ3EkHgImV60bs7RhL2TL ot6uKpiEfT66d6vbKxopxlRND7h/FnOeEfUxNFWEfmP3D/wS3wzs3YX7RxwxTNn58LOv ZjFw== X-Forwarded-Encrypted: i=1; AJvYcCVwcfuIJ2/z8Yh4Em5QVrDgYrLerKVXstcqNOonWYa0GT0o/k4aBc2iqndZUB4rNBbb1bc30i6ivw==@kvack.org X-Gm-Message-State: AOJu0YxxaUt4YyaDPue5ou4yf/JLc9mbYm/+hQrdrHsmpJStXYJXZyac 148MLe2y2VdrtNa69dR6AHP28QbH4U+TnTduaIDVAgCEac8sUpFAPtAPRUnyKZEBKYbma0tE3t8 kzZk6KeQr63lD3D2r88hLef4LDAZRrpHJdfbyCGb4iT4O2L7q X-Gm-Gg: ASbGnctg/00jgDbrHAtmWGjWweFUGLuyuKbNMvSjgtwEI0Zc1jIYWKR/ZeIhXVFKFl5 mTcXCOmpKbL6HvmEpuvq0u2J6Y+GQVkYYx6X9dhozftW98Ja8XaHOuVw+bQBEy/akgW9UN7geQf nz7SlISkLmVIxSOUOLkAXJ8hOLIz4wMCaTr1oqPlZXJD2d0R6WKazEcUeQvrhXjwKAO8hBgz7if K6vA5Hso7BO+l6YBCjl4dVLhBhvpOMryaXF4LqvgSNTTHKeuWWyzTG7JpmOPTDK6slU56cKPOEZ rJBND5qcKmNg6Ao= X-Received: by 2002:a05:6000:401f:b0:386:3328:6106 with SMTP id ffacd0b85a97d-38a872f6193mr19495421f8f.35.1736762990577; Mon, 13 Jan 2025 02:09:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGf8PBG4ERoXmyIOlZpCoTnexxxB9ssDJClNK3ARcXYvdyIb4rTKdDCq1vGjVkp/guTo3l0EA== X-Received: by 2002:a05:6000:401f:b0:386:3328:6106 with SMTP id ffacd0b85a97d-38a872f6193mr19495362f8f.35.1736762990214; Mon, 13 Jan 2025 02:09:50 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e3834fbsm11618939f8f.26.2025.01.13.02.09.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 02:09:49 -0800 (PST) Message-ID: <04667170-d5bc-4f56-a5c7-5b08a518f2e8@redhat.com> Date: Mon, 13 Jan 2025 11:09:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] mm/mglru: Check PG_dropcache instead of PG_reclaim in lru_gen_folio_seq() To: "Kirill A. Shutemov" , Andrew Morton , "Matthew Wilcox (Oracle)" , Jens Axboe Cc: "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-8-kirill.shutemov@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250113093453.1932083-8-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RPV5z64U8ARScSM4yVK6BOS6Kd57OyjQIfbHeYJsbLc_1736762991 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3DFE9C000E X-Stat-Signature: treq1bwf3huek6ygtip4hnpbt73x6ycw X-Rspam-User: X-HE-Tag: 1736762995-371426 X-HE-Meta: U2FsdGVkX1858IHmOB/fC9XfvDlGHw29N1q//WLxdER8NJvebCAQLQ8zddtoUYa2ux9RsHwZxH01QxrLOCFQAaodes0x46vGY0uIZ4lLPdMFQ7C0p3ZkcQf7YnsIORNaYqq8kXa7Z1mTkslZsEFalINhGO2D2Bc6XqMMcEcRjvkhaS6ocOdyJ4zeeVZt0tTdKSbafddUNY0uhYcM16YXi7M2b5ghaOXx1eZyDWrWHt23Ty3WbxgPgJGyqtDQU6TO+l+rLON7X/Uz1zhQPL6QZWD0K7VjbED/6o+o++jwaeM8bAHsqlUfJq7Z7Jn6DEm3PFl15gKIR6jkhVK4m5m9uqiLJiEsnhUCeaIZHgniZTtEXlBl6LkOJvDrnJcCZfz8Qva4qRmwoH0G1eG9RRHhzGCww6bW2mLPekj2BDlI5P2Zty9IRrqRDCKT5pyXLROq7NvIYLfUTsKJNnGWdamKC4dXaWIY8+DGl+a9Uff74Dddw4LnjtUshfb25Tum2vEwV93GlO6D+BPHj7MgLzUZ8ftC57CBY9IwaNwOpkTqWOxkbxaepwEMEUuJAak0es5a9kM+ESMCEvYypwEKgR8Loi69cx4TgXWSWo88ILhcpYuG5x6CSAgkfL/lFrQs0NTt6UbtJpsSTS540XiGn8EnxrlqU0DH3M0FyfjZDwpBYeup4Lf2ccQSMe+e6F/pcj4ECX3Kijxe380IIVKpuPzLrhOO4gs24InP1lAljpMalhBqZioeKIQTsgh6Bi3Z7b0hiQ/nPJfXEjIDI4XE3/KfLuTNcKQlpLZt80jspaO3lbWJQWgBxUWxDyW6xG1yeQyuu0JQry8bv++RkZ6aKlydm1c1kwe4IanoGmrerI6vstjgjZNYA3XJwbmhyoyVDCfrTyl49zV5aprXTBPcOEBzE6iK2TXnSm2WSHUpaYwUBwZRvCS+gfdPTuWgxvPQrMT/uOn+auhYq/BVsocj5ki fCtEaJPt 7rHlGciZ+keT3NJTEHtOfoL4ITOPMKac4PvEiqTzV57m4jKsCDykEQsyaEmbu7zDpPWrEHP3r/0zMz7B1YM/D3rQkmoVATEaCzFVhOJ59/LOmYHuQ1DeM7995codDJvv/ezTDPqMzxFQStX+uo1TiS6iVsEd1810xz06fjIIIB2UEzTc4bYy87d0Mx8ILTMcF8/TluVGhsdKTk9sMCcIvVDSAa6zcKRKRfbGlFSKyHEz2rCMo5OM4PD/PNwPPWS+xFu1VkG8rFViuIoxjYWnYF8bbrG7YVAHcp7OB2SNpWmKx+mTwyU1+9VbylvAD9dNQnITAcbUxx/qiVeZmL7wjv5rQmMvZKumPRmnVB1nG0gJYi7VbhMpY+8IHggIqAMgfWTk435L1lzonsNqVqRGuFursgAfmUR6koIs9Ioy6EJIyeinKd1+NGET0D7aP5WL4f3ZxnnPZsCdH4PvJWRAm5UEyZi72wahY30JQWjANMsn4eHhEGvNp5dH5Fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.01.25 10:34, Kirill A. Shutemov wrote: > Kernel sets PG_dropcache instead of PG_reclaim everywhere. Check > PG_dropcache in lru_gen_folio_seq(). Subject and description PG_dropcache->PG_dropbehind Apart from that LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb