From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2089C678DB for ; Mon, 6 Mar 2023 01:10:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2FF86B0072; Sun, 5 Mar 2023 20:10:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB8B16B0073; Sun, 5 Mar 2023 20:10:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B59066B0074; Sun, 5 Mar 2023 20:10:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A17476B0072 for ; Sun, 5 Mar 2023 20:10:44 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 68A7F1C5F0F for ; Mon, 6 Mar 2023 01:10:44 +0000 (UTC) X-FDA: 80536693608.21.CC0EA7B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf22.hostedemail.com (Postfix) with ESMTP id 6C76FC000E for ; Mon, 6 Mar 2023 01:10:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678065041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+vdKj24hidlAUky2ngBRT66aRXtAxYGwRyrRCzyv7VY=; b=mR4E4f99hgZnuENu+9RbyLTxs8QZdNfdnx9Q0bce5akzED2bQ3TNdPOg+WOR/Zso+xHOis /aUUB07fe1Bxa1doKQf282B4aTp6pu5W4WeVUzmEAUJlpz7q1TgxM7YPpN7y1kzmuJyRZf Sv/Fr/EymLq+q8HTzrYUOJu/LHqyL54= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678065041; a=rsa-sha256; cv=none; b=FGZy0dIE3KpwfipzmAiP5ouzyGzeXIcWdG/4DLDexC0HDHd5zD4Efb1mlhHOrmxyTwQWZ1 Hz1DBZ3QQX11RgVTWCtR9Demp7wuCS9uL9NANlS085l+VxP4mqYbZsBCies9ccGVw5xFEc cnE3CVtvuG5UX5IglUScxyyBOx1Tt04= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PVL6G5K44znWg5; Mon, 6 Mar 2023 09:07:50 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 6 Mar 2023 09:10:36 +0800 Message-ID: <04645c9e-2188-da5c-30da-4c4694c7283c@huawei.com> Date: Mon, 6 Mar 2023 09:10:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 2/3] mm/damon/paddr: minor refactor of damon_pa_young() Content-Language: en-US To: SeongJae Park CC: Andrew Morton , , , References: <20230303183925.113520-1-sj@kernel.org> From: Kefeng Wang In-Reply-To: <20230303183925.113520-1-sj@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6C76FC000E X-Rspam-User: X-Stat-Signature: 6yhk7fgw7y9dkuk9zrh3y7bdydnfmorr X-HE-Tag: 1678065040-957026 X-HE-Meta: U2FsdGVkX1/5ZnkfM0Y5Vu0jU08e2Prv9tYvnAYRV0avdZWDUdsl0adHVqv1dlB9jc+As14FrxLgysvww0riihVuJJv0aYB3VV+7maH3wlrLy4Y7xxnOJ313h8yoAtOJnei+wDaKhPkuurp8zZNb21beHyCTIbABOG+uE9NSCT/ppITyy9vtnY8lt0OvgcJkt3cNFJ6MYzCp9JOZkgbJud3zZFVU7jzdK5ROfNmBn5wwTJvJjJ635UdLo85J1KnaHRUSH6yLtbDl8ToKM835kCChYZJXxaDZm8HBVblDas3lHjQ5L4ZkdwrkzmV+kfpuuyTKgyD2RAvZ+7kAUHty5XrdQaMyZAGWKqmd5q8pJeziQN8k9WIIrxKQLgk6/NQLQv56M/M/FD8/TSItJVGMgZWgq03Zjh7o88UpcoR/z/Aq4rZtGshNkxEy1ZMMcwTADyHUgXOGPFLyTrnT+5LG/6NJrAv3SaET1hpDKqGIWM4iD3aiUUL6RKfDucsiD7U+9m3A7F+AWC/DEhpva9WefTFiMlF80NBpGvVNDXu9MCcIi7tQBoiVTIVXPnEChTo5s/n44G0N6LsY7Lhg63T4PCFdhO0jBWGOF84upTiNwZrhBcB6rplt/riY6rVBp401nAvifUsln/A/7CMgYbbv4ZOkq3y/TDgyZe2l/umDo/8PRUi1UReliLkcJwgGjsK4FZLew228rz/gTDXetPyhBZI+tqrq4PFI23IQUHD7Ux1IyJfu3enpcr3ixyuxxdO7XmR4RVwYzAL15bZWDnnyqSLJrOb/6PBsjPH3W38MqTnoFdoAYBAT0U3pM4lry7u3emGiTNRC3tsMcTe+VPmPbPzAgG0XtUVdza7uey4CyfFecU7MQm33FZ4vu6eWErwq2Wro8cJGcx562fRAHwwON7Wu6yFo22JmltmkT9G9MywxXfPHBks+FFZGDSqSfinaOXNRnnD7fi7MYcesQGh koGejKC2 z6IiONxUYebXtz+Yu6/IDBPwQhPwAqRDFDLEEnGFG/9CfQfDYoB1dVDC/MeeHNsnCwLXlmL5tC64F9MyqHkk17OZRtQ7ZqjrrX/D3f3OxQKaiwqkvAoUD7WCkF0mlD3EBraQ5AasS9llatBi6aapOboAN8jxDcWiGt8VF7Tt/MOwKh07hRx3t4+3OeprgSD+Kp6cIaKFwxo0caMB2bKp64V+YTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/4 2:39, SeongJae Park wrote: > Hi Kefeng, > > On Fri, 3 Mar 2023 16:43:42 +0800 Kefeng Wang wrote: > >> Omit three lines by unified folio_put(), and make code more clear. >> >> Signed-off-by: Kefeng Wang >> --- >> mm/damon/paddr.c | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c >> index 3fda00a0f786..2ef9db0189ca 100644 >> --- a/mm/damon/paddr.c >> +++ b/mm/damon/paddr.c >> @@ -130,24 +130,21 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *folio_sz) >> accessed = false; >> else >> accessed = true; >> - folio_put(folio); >> goto out; > > Because you moved 'out' label to not include *folio_sz setting, folio_sz will > not set in this case. It should be set. oh, it should be fixed. > >> } >> >> need_lock = !folio_test_anon(folio) || folio_test_ksm(folio); >> - if (need_lock && !folio_trylock(folio)) { >> - folio_put(folio); >> - return false; >> - } >> + if (need_lock && !folio_trylock(folio)) >> + goto out; >> >> rmap_walk(folio, &rwc); >> >> if (need_lock) >> folio_unlock(folio); >> - folio_put(folio); >> >> -out: >> *folio_sz = folio_size(folio); >> +out: >> + folio_put(folio); > > Before this change, folio_size() is called after folio_put(). Shouldn't it be > called before folio_put()? If so, could we make a separate fix for that first, > and then make this change on top of it, so that it can be easily applied to > relevant stable kernels? > Yes， I could separate it, after folio_put(), the folio could be re-allocated and the folio_size calculation is not right. > > Thanks, > SJ > >> return accessed; >> } >> >> -- >> 2.35.3 >> >>