From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A31C3ABC9 for ; Fri, 16 May 2025 21:20:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0EF36B000A; Fri, 16 May 2025 17:20:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C967F6B0082; Fri, 16 May 2025 17:20:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE8AB6B0083; Fri, 16 May 2025 17:20:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F6936B000A for ; Fri, 16 May 2025 17:20:55 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 02EB31CFAC0 for ; Fri, 16 May 2025 21:20:55 +0000 (UTC) X-FDA: 83450040912.13.3977733 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 6B85B18000F for ; Fri, 16 May 2025 21:20:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UBJgZFu3; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747430453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eCoMavrmaZxJcGW5dsoDotDkap37Rrn/8QZ0fSt1V6w=; b=DirgoFQejJcQCsiQsqWp4kWbAGIWVgVnlob/m/MCkPljpHCS0sHkk1nVrFQaitS+z016M0 Gfcta6v/AO26r8YWygbRSUuF9WpksntNodqS1gD85ac6M8XiyrLK4p0PtDsVq9Q2DYae9q osBMcnvAMSKr4C3K3Mol/R5K08YPGfE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UBJgZFu3; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747430453; a=rsa-sha256; cv=none; b=1AkDKYa0evUv6qJaMTOPLUTlCY1k6FEKWxf3qGmVzzCOdZ7dDQPx46sFNm2f3sdv7pTGyM zBGRV5w0pZecbtpqrRtLKW2UOEdo0r/BUrsJTLm1UAddQWOEG4LsBMdDhYKg0kQBwWEFyy ygGTrAXNw4w/4QDxZsdEI6M5m2bAlbg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747430452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eCoMavrmaZxJcGW5dsoDotDkap37Rrn/8QZ0fSt1V6w=; b=UBJgZFu3YpjoVGQI0u85w34yytM4AAl4O1SthujxBOiOaeslODgza+9Olxliy7XWKuOJ4W 2JQbnmkz6wHWYtz4rZCFh0z6IrqXlFsGHQKlM+YkAmDSJabQvbRhLKR9EwesLd+qfYGfmN rAfIueUtUpLP+rQjNy21zh7MnKO/CuA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-A9oqDdySNkG_Xhwni1xMKQ-1; Fri, 16 May 2025 17:20:49 -0400 X-MC-Unique: A9oqDdySNkG_Xhwni1xMKQ-1 X-Mimecast-MFC-AGG-ID: A9oqDdySNkG_Xhwni1xMKQ_1747430446 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a206f05150so1779391f8f.0 for ; Fri, 16 May 2025 14:20:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747430446; x=1748035246; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eCoMavrmaZxJcGW5dsoDotDkap37Rrn/8QZ0fSt1V6w=; b=acYQ9yXX/2mw9gsGZ7+QcvxPwXjifm2QmE98fxvBHm0KDQW5CD0YF538MgoXUIKNVi WmVSuRJsep186l6VJOcVzN7u1wtzINAnj4eLCPLz1SukX80dPLUAdSrSEaZRo+cOHSLI /j5entpmFqqUyZ1x2J2B4Qz0ka6sH29z1CVHsIr/IA1iTB9jJsyqKJCA9T6/RKPJKAK4 BI0Fa6IHBYJG0NjFmqZonFw8s+hTkhMU4DEb3BaKhT+MfOZHpS11YX5kIoC8s/mwPrDK 1MOZrBhQHoC+FQ4MbpQcwM1lloq4Vwh/7ZqYMoQOHvjbfQQlI7mGX8Yyda8W0iU41cII 6oEw== X-Forwarded-Encrypted: i=1; AJvYcCXqr+bmNgB/60K/GE/NTDaAFyD19B9nZfJCtFMmno8Sz4sFR0BmA3BLBH7QsdtOaA+5jbhuy6HcWw==@kvack.org X-Gm-Message-State: AOJu0YyoV9S1XwIpT1iR4h/OaI147lh5YGRDkTudcDTHvf7wUGwGeMyp 5oYzJVuTWGAOkE+K1eUZj2MFbx6/Ybh/+p+RtQ2rjypY0q417bk7Z3E0Lp257DrLvX64g3doIE0 5OKbHtg4wogLop1csP4azPqWkMw4/lEQttCpii1+xcjhvIITHTj0d X-Gm-Gg: ASbGncuD8ccIfan3LJIQvMftnC2xqXSnSYwL4mx5quRnj+dRFQFEaOITlvZOnT5XO1T GCo34NsqRIQFBN4CqeGX9kzGBlIUoL/o7T1LONYZNfW5I0qQi5q43ZKfOJ8VWCjDn5tqNshvcqZ t/XXAuVEBmib7yE0oCNURvMK2mc3UsyVvNwe3oRnLgV0HEUpfUipaEw+IG1QoBinDlC1HYmC5os y1+ra79hOMW+jWSZF0Zpjvyk4FdLE8uvSENYAeGUlG1Y8NVKu+jWEXJVq/lHkBGoYDrl7qPbHaR 9EUip//lj0NOX7+gaRf3YYRWvgXho1Ae622eJJ/v6Q== X-Received: by 2002:a05:6000:3113:b0:3a0:9f24:7749 with SMTP id ffacd0b85a97d-3a35ffd2d38mr3744507f8f.36.1747430446407; Fri, 16 May 2025 14:20:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9rcafLxS8xgREIjIKFia45brBz+IMR/aurS6hED242W2pTBmnbljKkHgcAvsIcUmFaCJwRQ== X-Received: by 2002:a05:6000:3113:b0:3a0:9f24:7749 with SMTP id ffacd0b85a97d-3a35ffd2d38mr3744485f8f.36.1747430446028; Fri, 16 May 2025 14:20:46 -0700 (PDT) Received: from [192.168.3.141] (p57a1ac29.dip0.t-ipconnect.de. [87.161.172.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca5a79asm3942366f8f.25.2025.05.16.14.20.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 14:20:45 -0700 (PDT) Message-ID: <0454761b-ec54-4cc8-9d01-b783e2e58f9e@redhat.com> Date: Fri, 16 May 2025 23:20:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] s390/uv: don't return 0 from make_hva_secure() if the operation was not successful To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Huth , Matthew Wilcox , Sebastian Mitterle , stable@vger.kernel.org References: <20250516123946.1648026-1-david@redhat.com> <20250516123946.1648026-2-david@redhat.com> <60DDE99E-E09D-4BD4-AC58-569186E45660@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <60DDE99E-E09D-4BD4-AC58-569186E45660@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: a26ZX5v6AUynEmj4hqj2W0hAHDA5eLzqTrF_aGuCbWg_1747430446 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 6B85B18000F X-Rspamd-Server: rspam09 X-Stat-Signature: n8ej9cqup65gfqdssinandcgrqphy5r7 X-HE-Tag: 1747430453-149107 X-HE-Meta: U2FsdGVkX1/idp67Jd2u7/cKEH7CvBKCM/3iNLvO87tlGvGDxEAt7C5jeGuB/Kg1WOMEEFJSG0EwhrCI7wHY7HoY+RnI2tFmg1LiusdbP1zZq6rq2c65LruAPzUporf0FUyLv1r/WZTzLhS4GaaTFxNYd3KJ1yVFAcXR+oyuIm1d7AEP74nzkdAaeoNCd/H9hfh450LNOa07gLTrnvVSqIXZbS5J2aUwYjcbsKga7g4PNPuno5SdCAO5EJYqhcoqf4Xc+v61BD05MZ6lLsCGVtM4MxrjUjkHFyU0bFr4grXP2WKh+rUKjfTcCQdQNqMt0TJGHYvna7u1toqy/UHjfwZCL+Ki6G9rlRqBzj/5YLkGCTWoqhETnNno9yKqC/yV43d/6byG+Z2Z2x1DvTyI1P6uCbu0K3XqLu4X43IyEGecGHNT3q2sVxqsCK/TyiWoBbqIybIpx7/07d9W+s6xamlYWkZ8OO8E+Rd7UGJyZMKPVGyzJZQS/A46h1RpZ5t2kqqxEb34Yd/qxvRUFf9Btnk44YXcdxDtKXVkxWAptBZDshLWEFeZP5x4s2fbl0vjQwjIvS7GjF4mJlGhARFbwoIHfZSZLfXsvcGSjQ7w1xCRsc58mRjNGdd1vDgzQMDFCoJVyMO6V54RK0XcmBvD9bWp4MywKBdPpj7JEpSJzK08dM4y3f1lF5f2lTFLQekDJLGt2QLWDyK5OC8WFtciXjRKuNZcNKk7BFvjueY5wkQ6poHc41vaR9cOIhA4E3HyB1IZ/5ZpI74x/mJbV475hGA5Jizurt3Jl9b7/6p1Lp3ODGbXPF0ELpjyvUq2nH1G4/fMXOvlHHwK5W29OyYst0FgfOKFz66+VjjCcRixiSqEvpYTUDrg5vswJi+zDsOQgeFaslL7+GmghmfbQMMXrnPsAJWpQzI6amWk2umzeEFiZRU6j2TCJYePuKyP0l//w+n4DTEBGDM787IqOsY FrrrGkAL TGMZQoiqZz+Zh+XwoGO9MSVewg1/OD+67eYCQN8BqnguPElxoVMwKtsUx50IcFyDNjg84Hj64IYxkme2ivy+8LCHQEGrFUg+rA6r5jIfSTmAI4E3mdH6cRlVqpDn015UmQS4VLFUlCMoRI+wZeAIpvXQiM4rLxoL0b6wKD6vFnwSUMyqB1A9oT+fMb7XZzg2e+D576HXNOnNsmIIkrFjr3wsJ0URH+HLNBByl6thTtk3h2co7/skSiGLmM+bu9TerSUbqgchYM37codRFvrrGzhulqOP+fjiPBFApDbyEtxixlH/yNgeT0rNYU7sB60KHOn8Nd6V7WHoS65i9lyi1cZFlBoLTYIDvMNDmr4Sc0zQbqYTFXFImJNXvuKpvCeGL/WCQI6Q+Q0CSoBPvfTU/ko3bIqII33PHZgBCMW71yx0HHuy1lB+t/8A4fVmpOd3PW2pyE9B2bKMiJJRri5GX/DTeXMhltsmikQRnwvxv6PhCjvY8QeJyJiH5PkqlyRGgDW9Ny7KrhzTVwK3Y3TD6jQ1xpypok+uCQbeCVcVPrH8yuL8gbskiob+Hq3WYZD2KHJC7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.05.25 23:08, Zi Yan wrote: > On 16 May 2025, at 8:39, David Hildenbrand wrote: > >> If s390_wiggle_split_folio() returns 0 because splitting a large folio >> succeeded, we will return 0 from make_hva_secure() even though a retry >> is required. Return -EAGAIN in that case. >> >> Otherwise, we'll return 0 from gmap_make_secure(), and consequently from >> unpack_one(). In kvm_s390_pv_unpack(), we assume that unpacking >> succeeded and skip unpacking this page. Later on, we run into issues >> and fail booting the VM. >> >> So far, this issue was only observed with follow-up patches where we >> split large pagecache XFS folios. Maybe it can also be triggered with >> shmem? >> >> We'll cleanup s390_wiggle_split_folio() a bit next, to also return 0 >> if no split was required. >> >> Fixes: d8dfda5af0be ("KVM: s390: pv: fix race when making a page secure") >> Cc: stable@vger.kernel.org >> Signed-off-by: David Hildenbrand >> --- >> arch/s390/kernel/uv.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c >> index 9a5d5be8acf41..2cc3b599c7fe3 100644 >> --- a/arch/s390/kernel/uv.c >> +++ b/arch/s390/kernel/uv.c >> @@ -393,8 +393,11 @@ int make_hva_secure(struct mm_struct *mm, unsigned long hva, struct uv_cb_header >> folio_walk_end(&fw, vma); >> mmap_read_unlock(mm); >> >> - if (rc == -E2BIG || rc == -EBUSY) >> + if (rc == -E2BIG || rc == -EBUSY) { >> rc = s390_wiggle_split_folio(mm, folio, rc == -E2BIG); >> + if (!rc) >> + rc = -EAGAIN; > > Why not just folio_put() then jump back to the beginning of the > function to do the retry? This could avoid going all the way back > to kvm_s390_unpack(). Hi, thanks for the review. We had a pretty optimized version with such tricks before Claudio refactored it in: commit 5cbe24350b7d8ef6d466a37d56b07ae643c622ca Author: Claudio Imbrenda Date: Thu Jan 23 15:46:17 2025 +0100 KVM: s390: move pv gmap functions into kvm In particular, one relevant hunk was: - switch (rc) { - case -E2BIG: - folio_lock(folio); - rc = split_folio(folio); - folio_unlock(folio); - folio_put(folio); - - switch (rc) { - case 0: - /* Splitting succeeded, try again immediately. */ - goto again; - case -EAGAIN: - /* Additional folio references. */ - if (drain_lru(&drain_lru_called)) - goto again; - return -EAGAIN; Claudio probably had a good reason to rewrite the code -- and I hope we'll be able to rip all of that out soon, so ... ... minimal changes until then :) -- Cheers, David / dhildenb