From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC24CC7EE23 for ; Mon, 12 Jun 2023 10:11:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FC8A6B0072; Mon, 12 Jun 2023 06:11:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ACF16B0074; Mon, 12 Jun 2023 06:11:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 476706B0075; Mon, 12 Jun 2023 06:11:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 39D646B0072 for ; Mon, 12 Jun 2023 06:11:36 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 155921A01A2 for ; Mon, 12 Jun 2023 10:11:36 +0000 (UTC) X-FDA: 80893678992.02.4580D7A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id BCDE7C0017 for ; Mon, 12 Jun 2023 10:11:33 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PzRY3Dak; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686564693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JmpRAnV26AUF4s7IjPY/jpT3j5W5+5DIpLFBGjUK+sc=; b=QqLhc502tKQ2GAD0RoPu11WcSlh4zZovlcmgZ4h5QqJ5vZm+1773LsigI4xSQKjfsO7vnR W8/ig7R4PaaFIrXjWzPOhQdtH3/kodomCQn/Aq+GqAL3OWUxtTWdF4HwSrAd9n4sWTh1uQ KqaRoJSAY90pqab5jz2QDb++aU7YTZc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PzRY3Dak; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686564693; a=rsa-sha256; cv=none; b=xdhL7DQDcP/gPnCnkoOEdEHT72qhn7LtegRoxD2MvcIUcZh4JIsKgfGSOqSM0T+etiM+q2 dYd4uJHCkPm26SZ3VRBCAIkXJCPTLFA65u8SEKTimhgeU8ny9MS7wyuuXoZ5RLw8XH9o4O zFvdG1KuUzwPmVYkulhZx7iqi0K+GqM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686564693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JmpRAnV26AUF4s7IjPY/jpT3j5W5+5DIpLFBGjUK+sc=; b=PzRY3Dakp03BW/sL58HBR4gAkyBSRl+425kO3SveRV9sOTGi1E9iSNpmafVnLd3TllkqJs Nx7KZZtXGrvx4rWuGhEhzQMQ0BLcwgM0SqZNYfwa7Jjp8SZ8SFeBur3sy2eJ+BwlZamky1 1wgXUOyS2uUtZuw0TTMvXZNPdqJwRhw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-qugL8HE5OjO_Z6pj39_0xg-1; Mon, 12 Jun 2023 06:11:31 -0400 X-MC-Unique: qugL8HE5OjO_Z6pj39_0xg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-30fc7ab9ff3so50656f8f.0 for ; Mon, 12 Jun 2023 03:11:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686564690; x=1689156690; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JmpRAnV26AUF4s7IjPY/jpT3j5W5+5DIpLFBGjUK+sc=; b=cIcsQQJOGd5guCunzTRtMJHavSyC7VQ5FTCHlhvTWS8YrBZfK8XDDODc1Blsiz0DKv lo5LvTwKKDE5IFsXhnPEZZbBG/sEvib9g8YvVqYAe341DAJZFuOXKYGOcDfPAvF/D+0r 8gILCBSZlDHh1fzuxu8Yh6K08e1sXJuhUeqxwEVel2T3rFOGHD4grtksx9pJ8gftVQhX pepinraNem5Z9SHY+HKdZjiKvO5bUvUf3oX871qPji2dexI64Dz0rmwwARLzKUJHOsi0 VwVDeoVSXjptrX4E1Tw1tgacRoazs7l5JWVVFHsjHUUssqD9bwjKh4iL8mcyaEYSHJ3I 71Sw== X-Gm-Message-State: AC+VfDyh3LKt5fhuHWN+fUSTx4+DIMXsxKsEZ+JgYQOnCTkGO/WiqUg5 FMVCb+JQNrteBHIDpEBPOruZYveJvE8eH6C0a0WyLzEDrTG8hgcUdtI8yRievB+MN8ndCvd+Poc 6LrsBoROkFGFuzCWpfGc= X-Received: by 2002:a5d:4ac8:0:b0:30e:2ff3:8c88 with SMTP id y8-20020a5d4ac8000000b0030e2ff38c88mr4564984wrs.35.1686564690589; Mon, 12 Jun 2023 03:11:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5jBUUk+/WujpPvTO1qN/t91PuJs5FrOQ9Jv+cH2AOp+kP8w2wN8nq0M2EPsm7sAASVQtLN9g== X-Received: by 2002:a5d:4ac8:0:b0:30e:2ff3:8c88 with SMTP id y8-20020a5d4ac8000000b0030e2ff38c88mr4564968wrs.35.1686564690216; Mon, 12 Jun 2023 03:11:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e? (p200300cbc74e16004f6725b23e8c2a4e.dip0.t-ipconnect.de. [2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e]) by smtp.gmail.com with ESMTPSA id k10-20020adff5ca000000b003077a19cf75sm11982305wrp.60.2023.06.12.03.11.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 03:11:29 -0700 (PDT) Message-ID: <044ec8f2-83e7-4bb5-fb26-72266b9d195c@redhat.com> Date: Mon, 12 Jun 2023 12:11:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm: compaction: skip memory hole rapidly when isolating migratable pages To: Baolin Wang , "Huang, Ying" Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8cc668b77c8eb2fa78058b3d81386ebed9c5a9cd.1686294549.git.baolin.wang@linux.alibaba.com> <87sfax6v7c.fsf@yhuang6-desk2.ccr.corp.intel.com> <55e05ac0-041d-75eb-4707-e053dc3f2976@redhat.com> <337d90f3-7c95-d5b8-de30-fb72e441a18b@linux.alibaba.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <337d90f3-7c95-d5b8-de30-fb72e441a18b@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: BCDE7C0017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wticzoz5ndq5h891fq161tb34pjpfcqk X-HE-Tag: 1686564693-221049 X-HE-Meta: U2FsdGVkX19EDjho2sPMe7Gag9ZLltcwIl0Gzwrtg0MiwCyT3OW6E+8khdgLjzRDFFQtnV76hyMGvlq8POVVGMgwk6+MV8pv3fUkUpEAwX9Hj9og38qmiNT3wH0CtmnJ5eys1mDcd1Bo7nH0bVgB/+T8KbVxSxj/MX01fRXH8dpEGG7Z0BvFa253pXQL3eccAUKo+prPNzTw/ND8BbjHDCPUucvykMEtiwwBL/OMPt2mbSZEPw3xS48IOtjriMJJ4JZqUEMKLZkLVleXiC3uRSRO+/L0xAHry1DafrWFCEEjeWzsZ/pAb3lhxED9QuhFtJH7DxnzLhnbY7P5UsUMveH6ipl2O1CkzzNeKATa5Tf5K0ZbXpyniIkji/yANMGMhxH5ERUo/YArZmS4tre6CJMlFK7Yl+07g71jKPiJt7X5WeaIC9n7Aq4/NCXedRjxIotsaUos5dnR3YzJMeG5UUJXndab/eTUvHZiEGeOCexZaslpI3VpT+RuPS880mPtoBaxYJ23k15CW+K2PcOskmwEgVr6AUc5jbKAc8yRnGe80kJLAWEEDvDqbUUBZ0dUYgh47y7ytdrD35aBPVtZSZ7Y2QqpPAB5gIM0a6Ox3cR8HOvaqJiH1LjoTGLbjbrG8bhruajHrzMkUPiXPAeSFMB9Xlh2PEqNkCGNK8imSda3zo5VK7xd20R04q9YJRaYWjCCtSYW5KeA+J/46rJ+HMhFdjhtQwl0Ir+iWH/CVgyavpaNVSd/2BaSdmsyKBuQXw7DgZ41ciZxSa/22kQA2NRbBspWalTRAYc0jP10CeiNss94UqQU/oaD+jgPgJyImXmahVTit1ImUksz4698Z98mgwLRvXZ+rxicTDdNFZsR7kddUdA1cE/S5BEeJpf9WXBjeexIR3PUJZYcZZALytZ2mtux1J3oGfmrO+bdc9IBsxR9qrmPHzXvyi2Crx+zjueOOzICoiCcscCfbPL D+kYmb9O evtZf3grFgKubqTYAyyMuRfgu35RotBDY4KKYVa7TQmeO1tq/z3t+pJYOgKOGDh7/INE93GEDdRd+pJPxYabR1Xs96j84O7Ww8jgDEaBi+oibPMoPWfH4asKVOyuQuA5LEGI+6p4lXELKPe2HzKIL+dnk38sKzX/OfoJ53k7EtIIll1GLRSeDFTAY86hKuzVJb0Ti4DxelRyhiaIezY5BcyWWC5+P/Auk9fFpedbFdZMA7scBbHKctnqkV350Wrzqo8ceE84x8UlWp+SdYF8puqjakBbUywmieEX9wnmi013l1EV+7gIKGjOY8I7bwjRm/FPh8+LRDZsIgT3eSqgho3Zv8S8ZmNe31RxXEc2pyLuqpyFuekTAKOsnRKlOVpMZmrwLncd1efMqo3P+/anR+4BlRHAB7PbUMIlnf6uK1qH2ak9f3aTSyIayCe/5Jv+q9gHBVUhnVeTgS+8DWBrHzTAX0+iL84oYh4v159CxqN04Wc4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.06.23 12:10, Baolin Wang wrote: > > > On 6/12/2023 5:54 PM, David Hildenbrand wrote: >> On 12.06.23 11:36, Baolin Wang wrote: >>> >>> >>> On 6/12/2023 2:39 PM, Huang, Ying wrote: >>>> Baolin Wang writes: >>>> >>>>> On some machines, the normal zone can have a large memory hole like >>>>> below memory layout, and we can see the range from 0x100000000 to >>>>> 0x1800000000 is a hole. So when isolating some migratable pages, the >>>>> scanner can meet the hole and it will take more time to skip the large >>>>> hole. From my measurement, I can see the isolation scanner will take >>>>> 80us ~ 100us to skip the large hole [0x100000000 - 0x1800000000]. >>>>> >>>>> So adding a new helper to fast search next online memory section >>>>> to skip the large hole can help to find next suitable pageblock >>>>> efficiently. With this patch, I can see the large hole scanning only >>>>> takes < 1us. >>>>> >>>>> [    0.000000] Zone ranges: >>>>> [    0.000000]   DMA      [mem 0x0000000040000000-0x00000000ffffffff] >>>>> [    0.000000]   DMA32    empty >>>>> [    0.000000]   Normal   [mem 0x0000000100000000-0x0000001fa7ffffff] >>>>> [    0.000000] Movable zone start for each node >>>>> [    0.000000] Early memory node ranges >>>>> [    0.000000]   node   0: [mem 0x0000000040000000-0x0000000fffffffff] >>>>> [    0.000000]   node   0: [mem 0x0000001800000000-0x0000001fa3c7ffff] >>>>> [    0.000000]   node   0: [mem 0x0000001fa3c80000-0x0000001fa3ffffff] >>>>> [    0.000000]   node   0: [mem 0x0000001fa4000000-0x0000001fa402ffff] >>>>> [    0.000000]   node   0: [mem 0x0000001fa4030000-0x0000001fa40effff] >>>>> [    0.000000]   node   0: [mem 0x0000001fa40f0000-0x0000001fa73cffff] >>>>> [    0.000000]   node   0: [mem 0x0000001fa73d0000-0x0000001fa745ffff] >>>>> [    0.000000]   node   0: [mem 0x0000001fa7460000-0x0000001fa746ffff] >>>>> [    0.000000]   node   0: [mem 0x0000001fa7470000-0x0000001fa758ffff] >>>>> [    0.000000]   node   0: [mem 0x0000001fa7590000-0x0000001fa7ffffff] >>>>> >>>>> Signed-off-by: Baolin Wang >>>>> --- >>>>>    include/linux/mmzone.h | 10 ++++++++++ >>>>>    mm/compaction.c        | 23 ++++++++++++++++++++++- >>>>>    2 files changed, 32 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >>>>> index 5a7ada0413da..87e6c535d895 100644 >>>>> --- a/include/linux/mmzone.h >>>>> +++ b/include/linux/mmzone.h >>>>> @@ -2000,6 +2000,16 @@ static inline unsigned long >>>>> next_present_section_nr(unsigned long section_nr) >>>>>        return -1; >>>>>    } >>>>> +static inline unsigned long next_online_section_nr(unsigned long >>>>> section_nr) >>>>> +{ >>>>> +    while (++section_nr <= __highest_present_section_nr) { >>>>> +        if (online_section_nr(section_nr)) >>>>> +            return section_nr; >>>>> +    } >>>>> + >>>>> +    return -1UL; >>>>> +} >>>>> + >>>>>    /* >>>>>     * These are _only_ used during initialisation, therefore they >>>>>     * can use __initdata ...  They could have names to indicate >>>>> diff --git a/mm/compaction.c b/mm/compaction.c >>>>> index 3398ef3a55fe..3a55fdd20c49 100644 >>>>> --- a/mm/compaction.c >>>>> +++ b/mm/compaction.c >>>>> @@ -229,6 +229,21 @@ static void reset_cached_positions(struct zone >>>>> *zone) >>>>>                    pageblock_start_pfn(zone_end_pfn(zone) - 1); >>>>>    } >>>>> +static unsigned long skip_hole_pageblock(unsigned long start_pfn) >>>>> +{ >>>>> +    unsigned long next_online_nr; >>>>> +    unsigned long start_nr = pfn_to_section_nr(start_pfn); >>>>> + >>>>> +    if (online_section_nr(start_nr)) >>>>> +        return -1UL; >>>> >>>> Define a macro for the maigic "-1UL"?  Which is used for multiple times >>>> in the patch. >>> >>> I am struggling to find a readable macro for these '-1UL', since the >>> '-1UL' in next_online_section_nr() indicates that it can not find an >>> online section. However the '-1' in skip_hole_pageblock() indicates that >>> it can not find an online pfn. >> >> Maybe something like >> >> #define SECTION_NR_INVALID -1UL > > Actually we already have a NR_MEM_SECTIONS macro, which means it is an > invalid section if the section nr >= NR_MEM_SECTIONS. So using > NR_MEM_SECTIONS seems more suitable? Indeed, that would also work! -- Cheers, David / dhildenb