From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4D7E77180 for ; Tue, 10 Dec 2024 09:06:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C6126B013F; Tue, 10 Dec 2024 04:06:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 076BA6B0140; Tue, 10 Dec 2024 04:06:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0A9E6B0142; Tue, 10 Dec 2024 04:06:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BE6746B013F for ; Tue, 10 Dec 2024 04:06:39 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7F9E441630 for ; Tue, 10 Dec 2024 09:06:39 +0000 (UTC) X-FDA: 82878467658.09.4E3D08C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 4C3BB140004 for ; Tue, 10 Dec 2024 09:06:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QMda8sx+; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733821582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WViKBtubyiEweAq6c93mHEW2iW9FasO8p1wZhXA5URg=; b=cuZ8UJHrthy6yIfRRWJlmtSiQlft9YtTV5+h76eFgR2k1D0DTGyUH+VYs+iPuFs0I8byoO neipElkmTJb1hDklhpxajLmNpjxfHk7CsZCRUBkUyhdPVcXZQxX9Vh/0tmaja06AtRuU0W sJieUTFjNs+P0BKSjU8y9K21rHTNWvc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733821582; a=rsa-sha256; cv=none; b=h3gZYBzmmw7kRdhzYIFGV3Yg2+AVLT3Y2QYvfIm7OJ5xCy1p9q/yJhqDSVreUsp//rm6XN uEC5zA+NBDsf9n9i0Nq5mxhv/e5U24ojvNAtg+TFBREp1MA0B9O4b0w+MbqjFUtFydXff3 deXBYL/44lHtmB/+77BMAx5fy5MqJKc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QMda8sx+; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733821596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WViKBtubyiEweAq6c93mHEW2iW9FasO8p1wZhXA5URg=; b=QMda8sx+AJQ1sNejnC8bicTQsL2d77k5H/D9cnYW220n0G0CquK3DxoK/K7IjVkjLk4jCB bDOk4x1hBO77lhjgK0lBh9frMyyu8k4Lnf93rOKQaXB6/5LQPOBa5dUVdnuKL+f+DnUrf1 ZHa47quXvRvA6YP51myrN8B9rnmJJYQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-UYDamNoOOyik085agPHj1g-1; Tue, 10 Dec 2024 04:06:34 -0500 X-MC-Unique: UYDamNoOOyik085agPHj1g-1 X-Mimecast-MFC-AGG-ID: UYDamNoOOyik085agPHj1g Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4359206e1e4so3362165e9.2 for ; Tue, 10 Dec 2024 01:06:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733821593; x=1734426393; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WViKBtubyiEweAq6c93mHEW2iW9FasO8p1wZhXA5URg=; b=Iw///c65uAob6tW4ctYwUR5tqOvdKEY+sq8bEGePKh6GJDUocI6UV+1CIsyoO8/IgA YXQ0CeWA7kbTgST5pgLPJzZQfrzizyTejurHRsUSi+IUdFmhfTJBfPp8j947+Mqq43w6 pPdnDcvga1mjs83BI7yB6ixrKhb6wosm84o4APyLs9jamqR/EaxhBHKOP21nHMR1X8FP fFEUg3RzmYtLfTq4RBpHXX2c5j2PBr8N9B+Jb48d3o1jSgBBbGz6UUOICmk56+GnvCcI YRxZKm8B4b2GRPCarN9U+N0eK3EjTVJMUTmp5j1CA/ZTLZ8ZN0oBscuthHCJKN6MfmGI zxpw== X-Forwarded-Encrypted: i=1; AJvYcCWRApR2XK2jGJpRVQ9HF8f5yHAyEreXj8+ZKuiS7v6qi6Fu+bPWdl0QgkiDVqpa7VxFbddhTuXAEw==@kvack.org X-Gm-Message-State: AOJu0Yzm7vqlqMWXw0FPX5CKxuV4e/Uq6wyk2ZvE0ymg0jFpX3ueA0vp bXbfiv+PeTC90CTkdhRrMyQfXxmFqHMC7GAcHr559O0V+qNxN5gWaDMJCiZn5yYsyWVpstujMnV HMbY3zlCyA1TJNRqoH5sxsAuwAaFu7wIQgf5nOhIXsapR9Asa X-Gm-Gg: ASbGncu6yzMXnAEtzQ7xQ7hOw/HaPjbf1gD2/6dL0fLibAm+gNK2uLfi6ZCabbJ3KiB nJjIuF9+RcV6wtFgB6H1eIJAue59+ZhmsWFw3CcmPE7oiCqMBM80N8FC24pprCWynk0xVR/8hzt TuB2C8QLU9rXowzOmbbOnNrvWcmGsJFexSVER+eO7CaU+rAS2bkzqX2r6nUVSaQpvauns28UjnH Mn5PFsLnrEvZGr8JvWh2YJPCAQf3DrcGbh7fEO/em9OwdqSYv2BF0xXfXaAiWsEnKlft9wr91lk chJMlC663JN1HrngD4rM8qOFvLpUTJQRf3dueO1GXCZbVhdxKJOi9vhlpSJY86roL8xt3mhg/NW GRl5Brw== X-Received: by 2002:a05:6000:716:b0:385:df73:2f42 with SMTP id ffacd0b85a97d-386453e1ed4mr3407570f8f.32.1733821593217; Tue, 10 Dec 2024 01:06:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGl8zSmol9ZLal+68wsCmsbBIBHWp10p/fCgidEcZpYsF4kBtwxdF5K1aT3eXRNGSPBT4sZrw== X-Received: by 2002:a05:6000:716:b0:385:df73:2f42 with SMTP id ffacd0b85a97d-386453e1ed4mr3407512f8f.32.1733821592917; Tue, 10 Dec 2024 01:06:32 -0800 (PST) Received: from ?IPV6:2003:cb:c723:b800:9a60:4b46:49f9:87f3? (p200300cbc723b8009a604b4649f987f3.dip0.t-ipconnect.de. [2003:cb:c723:b800:9a60:4b46:49f9:87f3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-435017d724esm27604605e9.19.2024.12.10.01.06.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 01:06:31 -0800 (PST) Message-ID: <0448d4c5-1675-402f-9629-d1348019e38a@redhat.com> Date: Tue, 10 Dec 2024 10:06:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: fix vma_copy for !CONFIG_PER_VMA_LOCK To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: oliver.sang@intel.com, klarasmodin@gmail.com, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, mgorman@techsingularity.net, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20241209221028.1644210-1-surenb@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241209221028.1644210-1-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tO-mgVL9qds0cA_sQ2KDBjRTzAq-2qVDPLvZ5UgwGw0_1733821593 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4C3BB140004 X-Stat-Signature: w1y1tax44ygrcxpen7sfzes1jb4nrnse X-Rspam-User: X-HE-Tag: 1733821582-963804 X-HE-Meta: U2FsdGVkX1+UD/vC+W0QsRt0rqhvxAtwOZIKb03T/5cXSs9FB7JEauxXi8pxwq6YkGw/1b9mB8xbeuxsXNiH6KpM8PlslDvM6+lRpePGhBsLKPZExgMdXfeJtPKxgu0v+S7RB8WPXEQHHdgtScSV0pUuuOhJzSAXI69unAQVLqEGK2tIxOxNLoJQNKnOQdJ6UIUg5UtMyNkAEc/QIHYokTMQ1BfPBvGUSpMnP3KT3q//luXoZI5czX35tY1DXSAtvd5S2U1Ktrf4sRlPWRfA+DQnDfQYghFE3Gmx1PATBtBY2qWG9O05COT/oJ63+lo1BvRIu66v7STh2LyH/UN3nt750+smbxR7b5vg2a8qBftaJupGJED9YA7uDqwLeucd/NCipTkMpNy1703Bjsj/RoaPrEAM02cxBooLyEuK3+uOwb3aIcCmZG34oRoQxW9830djhS5XfMtJn9eJXKSRjkjKB/wAVjgBAmzPpoJrlU6itc4N2Hs3kUmA5JEmap/lxuh4eLilutNFFYVeBcDmadwIsUd8neoPhJNUPrWp+P6vxfyRKxq9xpCqFjxBsLVeoTlUMaBYb88Arr7r4nTklLCJYkeD4pqYxfSNyi3oEI/EAd76RLGVzBjb7J3JveST2WmQh/JRjfJ5pw9JiFp1lfoJLqQKgTi5a4/H4e7/ZTucTqmBA41BasAYqlzNQh6rV2ITo6iEGqa3odYqeOfUlYLOV3WqANbDnJ0VubPGEVddvs27YpjJ6JfGpYXFwhxxEEoeevH7FOP+ObqShmBQkLmCcPRTpkKpsjX5yBQ5Wiz0a7GhkcGtzBqjr+ZBPfc5Ux1DxBmH3tIuduH0+mGjiB8aOalgv5x6ElDj+DqhyE8ddBf/Tn8wsZ9bhuazz/0tYj2uW1tmb/GDG4Qc6ooWGT46mxFXGzbWWpzEfPOKpaO6lZizC+DvpidwXFQshidS39hbcCiXpsTQPZIiZv/ DJDnSkDf e1jLqk8JEUPzkrNNbCjhgdIqLuRNI54aF9yKzsoxsOVt/3vL29TIjzgc/wCvupDb7U1QdNcJ7PkEN3ekynBoCVie2RNGS04pV405+F669fYNvui1+rxUSWA/8nJhRY4Td3BQfuj41C4WKbMfsa/11+HtG8NR3WkfyzOsPx1OY8zCXJP8/8qK3nGNNVc/tr/C4ddP+j0kjf/Xog2yAJyIWBTnGv8IkepLcV48mLSDyNcDDzV2IkoUeEhSPHkdfycYN76RskkOMFfHYlD1yPJrWwwwQLyMonIz3wK6KQ8q2OdejDhvHa0d8IyVNRiT1j8VleoFBPqlP0YbzlTfL6ub5vcX3F7f95vWok4BKVQaNhJv/cC8qRkqkiPaf5lruSpZXBsmH8rhfp6qIqEekeKuuOwoZp25LG1/qhiy+MSbLGZZpo0rVdBRA83/FSJY4DrZkrpU47m3VMketCPA4otgEericHGIKYars5UC8dZRl1MmlgxY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.213914, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.12.24 23:10, Suren Baghdasaryan wrote: > vma_copy() function for !CONFIG_PER_VMA_LOCK configuration copies all > fields using memcpy() as opposed to CONFIG_PER_VMA_LOCK version which > copies only required fields. anon_vma_chain field should not be copied > and new vma should instead initialize it to an empty list. Fix this > by initializing anon_vma_chain inside vma_copy() function. The version > of vma_copy() for CONFIG_PER_VMA_LOCK is fine since it does not change > that field and anon_vma_chain of any new vma is already initialized and > empty. I'm wondering if there is sufficient reason to have two implementations to do the copying. How expensive would it be to simply use the CONFIG_PER_VMA_LOCK variant unconditionally? Is it even measurable in fork() micro-benchmarks? -- Cheers, David / dhildenb