From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A160EC77B75 for ; Wed, 17 May 2023 07:20:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8FFB900004; Wed, 17 May 2023 03:20:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4141900003; Wed, 17 May 2023 03:20:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2EE4900004; Wed, 17 May 2023 03:20:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A4BFE900003 for ; Wed, 17 May 2023 03:20:25 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6F109140458 for ; Wed, 17 May 2023 07:20:25 +0000 (UTC) X-FDA: 80798898810.20.4E59DC1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 4EE718000D for ; Wed, 17 May 2023 07:20:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J9H9km8t; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684308023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lX9THAjBRRvTJDvL9/RTj01gjyTGzt4OdK7dq/0zryA=; b=PbkraWXJu0Pj6tArSfnIhQXEJiqwB+YlxDLoI+fX/FVGzxVMAlNIHkB+q9rB9b5Q/NmpVY RVt5ano0m1F+Migge74YzoYj/JLR2vbwR/NdR4Lrje9YFX25nL21WSmO4vPuBB0TdzW5ff 5eGDH/pyKT2wX2q8z1+pPUJb+nVHNII= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684308023; a=rsa-sha256; cv=none; b=sEjVdDR6wkCQNY/aQ4aEInQnUc0OvaYFc/GFapzjlVjxcKGeZIwzR+9AjtnNZl7uIRll+w tkj5kRjMulxsCgdqIPOZXTVHPTcPaDyY79nE5v9y9z5yWSWKhUWf0MDQVo7WNVLBLg46LY gVkYCbvbkLtDrY0OzI3n4HoxCranNnI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J9H9km8t; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684308022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lX9THAjBRRvTJDvL9/RTj01gjyTGzt4OdK7dq/0zryA=; b=J9H9km8td9vQ31YQPyJDAoT5u75ypvp8Y/oTymGJ3iKYOIwvgrxyjs7p5iWH8p+bmBACyu ZWGSUgfkHSeOeCBt/c2UW3+E3a6jlXQigHRS4dHTVAWAkbkaheTVvK/+6x7VuCxxQ5OWKl /h4YocvyTvpH1CBA8crimhbCh6lW1pI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-IOGEZ2iOMf6Q5YY4OvSing-1; Wed, 17 May 2023 03:20:20 -0400 X-MC-Unique: IOGEZ2iOMf6Q5YY4OvSing-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f42d18a079so2368115e9.2 for ; Wed, 17 May 2023 00:20:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684308019; x=1686900019; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lX9THAjBRRvTJDvL9/RTj01gjyTGzt4OdK7dq/0zryA=; b=W5ppY8ehxuDeyP255duL75OUnt4RQym9VCTCpvL6xVRV8ZTpGAJl1A2t+h0M/1puis JcBCmeQWRGmzUv+tan6CNCPubAxZ4QZf4iOXikrUfS53cL+DJy7gP4YvGfXa5MbAIUiE rDvSE5S18oO6pBMzHTY9+PqawhqQkwz+QJ+Fnuhf3wIoKE+8uI6a6Pbi028dxys4hzbE 1rCQKXllxlCeI7/Qn1GLT7jhIESf2YMVaWoxzudY+OAfJ2/o+cZ19ih4jEtW70nUYG7Z IOsh/AShMGLEcn/TzJib9Bory/bKDmfSlvexNyuVojJMKKt5F80z0ZAtVVc1AMKeybmH RY/w== X-Gm-Message-State: AC+VfDzT4jIFNH5mcaU3AZVwooxPBx/VOpVYZcqVE8VvXrGhEsrsNa5J oNgZ+qHe204OgaMOS998p1+610SQ1y8rGEm7rb1COdOXDksGKuxuIkcv3f2F8EBVWpObJq1l2z1 qkWgtzCnWQsY= X-Received: by 2002:a7b:cb97:0:b0:3f4:2c71:b9ad with SMTP id m23-20020a7bcb97000000b003f42c71b9admr22412719wmi.30.1684308019192; Wed, 17 May 2023 00:20:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7cVZ8I/6wargKKFrizFw4sXbko4IAyzuhu4M0IR8C+EKbw7dIvkODBqskSfpxg4oU9SN/tsg== X-Received: by 2002:a7b:cb97:0:b0:3f4:2c71:b9ad with SMTP id m23-20020a7bcb97000000b003f42c71b9admr22412699wmi.30.1684308018847; Wed, 17 May 2023 00:20:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:3900:757e:83f8:a99d:41ae? (p200300cbc7073900757e83f8a99d41ae.dip0.t-ipconnect.de. [2003:cb:c707:3900:757e:83f8:a99d:41ae]) by smtp.gmail.com with ESMTPSA id s2-20020a1cf202000000b003f50876905dsm1246894wmc.6.2023.05.17.00.20.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 00:20:18 -0700 (PDT) Message-ID: <04428bad-4044-ef59-8dfe-381741164148@redhat.com> Date: Wed, 17 May 2023 09:20:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] mm/hugetlb: remove hugetlb_page_subpool() To: Sidhartha Kumar , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, willy@infradead.org References: <20230516225205.1429196-1-sidhartha.kumar@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230516225205.1429196-1-sidhartha.kumar@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: yqd1pbqu3wxzzd46oxwjxt6ghg59zh5m X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 4EE718000D X-HE-Tag: 1684308023-159080 X-HE-Meta: U2FsdGVkX18++9mXqKDfBXbtKIUb1XyLcNQ3smd9ivpntqyEaUgu1sl7+yHRNC43VW5fI+Qw9LFTkMLbG+m8K1DAaJ/0MMS0/GaA9ucEJufMZIQm6jHZbf3H4P/i095itLTpxcRkHrDwjEnGwjScUnPAAWFuOHwNi4Wa+nvyklnJdC5LHOdObYvYWAYAmyd3SORGcjwxHpYGrGBozoaCCCbfhml4JeecDkpRnuVBYPMsRyBTiwsrnUqjqV6d1UrY5bvgUdFz8zLAJApu/0amXV18bE03CuBJQ4A1FQmZV4U/nA/UMO6q0gaGF/fJb7y7+3Y2BU36AcMzhmFdiUmk6Rw5KeWVcp4QfFtT/urjt58G3qnfgmGsU9unIPoGYCW+Qn4KQwRO5AYdFsDGZsMUWqZQ2vlSj1z2G/ZvtSbJA9ByYwSLHPfYC54g0xb08girVlHLcQOLDrHxq+Sn3Ogl4pMNFG8gBnP2dnmK42eg6/5DbcvBKCiyfRB6EWck1B0MTgKmjQn8mB1mLjLwS30YC5A84EJMNQzd5/DNCQ5g8LtQfpJd9YBVLtOI89SYB9nv4KBoKyyWdN663kETi0zrFy1LIrAGKwGBS41SkO1Y8V0MWyNV8MNImoxOGqSWqcwV5R47VxA37NdfHCIvJV7qvMQ8ePN9QYBVUc7UFDEiv8TPgDDXwCoe5hu6PNiKTW+TLwuBGOTcFGnWR/l0Pw4Hfjw8vGWMyfMVVpgL2UYX5G+02ihzRZ3j2kuWn+8L+hFSCQ2B62kw59iExJvOdtzZKVrX+nmnrsIUG9RMMbPGKB/dCir+pXjL8NO40w9m41kSpPwpRnqO5ueQHqbiqnLaJvGV5HOXB0+EG9bY2zkUf+M4hjo4KZ4k7J/r097y2nqd2AtZ6al3QQ5PWwXu5aCiGgBd5CghXkHU4n7+Wn45G/UNi30ywyISSdj2liCcQIDfSU2urdYSpcRc3aAegWb yoEzAPqT y1jXVUcnXPkrpl3/piv9UnWWCAG1xl1wuCO8LlJMCpYYc5y1XBCj7A6Tr/3TS81Drnk0KO3xcR5CdI69MVu0Y72aq7eKGM+h78OsOTWdK0oaWacrLl4Ei0t4D/xQku/drqJ4GwDimZRGBXpuAUkIvPyt4ri/vnPluGToDgMAi5UEx66M8yghhCheAZfIla1qDSFxqJ197bo4LCz3eImlCJRMWktDf0gzQS4MAStU5xIQBcKT+qp3GoKb1KuxzwXju2KibZcAEFm47NYYNHFdQQv6Z6IejaKcdBEKAiumVlhlwfmRDXsp4NiXXOrqwuLNkPzdyj9X2IyyBi1i86vVoES+TsKH7kUOI9IQKbY+04rEHw80lIVseZWOfuDyOwCfs94HVYYWPBmJAu8xrx/zGLbXPiQD53kCz9f7SCDOtb1KmXM7YA3BpqnEgOpJsMdaBIgPWY4mmlqPM1UaFb6M32ffDdJCge8no3uHq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.05.23 00:52, Sidhartha Kumar wrote: > All users of hugetlb_page_subpool() have been converted to use the folio > equivalent. This function can be safely removed. > > Signed-off-by: Sidhartha Kumar > --- > include/linux/hugetlb.h | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index b2b698f9a2ecb..21f942025fecd 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio > return folio->_hugetlb_subpool; > } > > -/* > - * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool > - */ > -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage) > -{ > - return hugetlb_folio_subpool(page_folio(hpage)); > -} > - > static inline void hugetlb_set_folio_subpool(struct folio *folio, > struct hugepage_subpool *subpool) > { > @@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio > return NULL; > } > > -static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage) > -{ > - return NULL; > -} > - > static inline int isolate_or_dissolve_huge_page(struct page *page, > struct list_head *list) > { Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb