From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C20C54E67 for ; Thu, 28 Mar 2024 11:33:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D5496B0088; Thu, 28 Mar 2024 07:33:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05E116B0089; Thu, 28 Mar 2024 07:33:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF3016B008A; Thu, 28 Mar 2024 07:33:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BE1B56B0088 for ; Thu, 28 Mar 2024 07:33:43 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 016F01410B3 for ; Thu, 28 Mar 2024 11:33:41 +0000 (UTC) X-FDA: 81946237884.29.0D4C513 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 936EA14001A for ; Thu, 28 Mar 2024 11:33:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ESSVsFuh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711625619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+OnVIsAvhmL8u/GQjeaswCFbDOC2tuF3B6FfsefyYQQ=; b=lwjYxPjzwMY7nxKjjfX1evNb0SeJpCXVYVTVZ0EhtoEp1nNjDnqTsGD2axk6BKkTHKV2hK 0e6vZbn1PVpDZ12S+aMuE+uXRtU97oPPcocDmLn0gRC+kOZw3kuopigFVIdhctaR/7bd7A 1JmZ23mNl0FGuSL+cgfL2fe5/4xFX9k= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ESSVsFuh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711625619; a=rsa-sha256; cv=none; b=gnuup6ik00vvocXwPnBJ5hVeoq9eO+sGuSHSKRjmwSM+VlPGk/z/EppHldLrRf0q46W3bq 4BCCleCKxCm3oqW9GN3JFJqjK0bZ3tN6aBGU4MBVSW7wfbr8gPiYfQjH3w0XHj0AgtrHOL LFOUbmY48KzTG7XzMf+wymvATS2tWWc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711625618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+OnVIsAvhmL8u/GQjeaswCFbDOC2tuF3B6FfsefyYQQ=; b=ESSVsFuhCYFDNbuezQeqqN5Y7sA1Tg0mXwlMMFYmT6ykvNS6j84YD9E6OElGYcKR/Czhdt Wzm0yEFfQFgChnfL13JKP4Qb3XdKQ2VMvocnpmOWRuD0Y5JunG0cAN6ypGjY5Ss0DCY0WD W9VExfTYD4ImTMaehqHc3iev/uNnnaQ= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-xrWIKp7cMcyeJtnIUbzpAw-1; Thu, 28 Mar 2024 07:33:35 -0400 X-MC-Unique: xrWIKp7cMcyeJtnIUbzpAw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d45c064742so7919131fa.3 for ; Thu, 28 Mar 2024 04:33:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711625614; x=1712230414; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+OnVIsAvhmL8u/GQjeaswCFbDOC2tuF3B6FfsefyYQQ=; b=pQuojaHSgGS92pPXYLUIi7WgPQYSoz3clH+SlFoIlplo44TnP6IWlUSMzOqNAyl7d0 1HY9Ypf4BwjoU/ZgVr1e8KmKzgh0ChqxkqfSjeXRMVAmDeKDlcrEKLjZ1iVHf64f15qb Nb42LySMHTZw+gzYNb37CKgq6OUxoZ3gL5Kp2z56c+xg7SHpCKER9TVae/el/hPYll/H emRFqd4+9dTKszZal0JusopCY4IbeBWhcw+CBKlNZs9Y+HD5usmAVhZ0FK6kL/aSxr/4 jPNQJaF4LmjuZiXhuhS542WAbvdaOGBdYtmhHOkUIBPuIxHRMTqvLNAY9+Vw1vl2IsBy NOWg== X-Forwarded-Encrypted: i=1; AJvYcCUmg47dfHaCZLPn+g+kpxm2/VVYZRnp+zamsFUJpCZQ3f+MRChVD5i4IcVxz8xKsXz/DUv1Lm+o/fmVZeDwJZUREF0= X-Gm-Message-State: AOJu0YzbmT1O1ZlZ0zIwSPkIuMOZma1hcLWqAwv/Y9wCgLjeH++jsRO7 aC7D4LKWknNgZ7E+2mi9HbERJrIAUAA93QxvHq9UEoEeF0+SSS9ur2YGY1J6wBOZ28aiERd/7HG wU2wFrU1zBCWvXmGPWM3bsx1PwwW+b9caehlct5nUYAHllDns X-Received: by 2002:a2e:9e08:0:b0:2d6:a5f6:c8d3 with SMTP id e8-20020a2e9e08000000b002d6a5f6c8d3mr1854470ljk.27.1711625614049; Thu, 28 Mar 2024 04:33:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmICQmYh68ZTu/uqAXjt5o7grz19N+CnYfNJKgyWenWUcQXt5wAwNH5jsk8S9B0IXAd2J6ag== X-Received: by 2002:a2e:9e08:0:b0:2d6:a5f6:c8d3 with SMTP id e8-20020a2e9e08000000b002d6a5f6c8d3mr1854457ljk.27.1711625613700; Thu, 28 Mar 2024 04:33:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c714:3600:8033:4189:6bd4:ea29? (p200300cbc7143600803341896bd4ea29.dip0.t-ipconnect.de. [2003:cb:c714:3600:8033:4189:6bd4:ea29]) by smtp.gmail.com with ESMTPSA id l14-20020a05600c1d0e00b0041477f95cf6sm2037466wms.13.2024.03.28.04.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 04:33:33 -0700 (PDT) Message-ID: <042fae15-5b07-4cab-9818-afbddedc96f2@redhat.com> Date: Thu, 28 Mar 2024 12:33:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] selftest/mm: ksm_functional_tests: extend test case for ksm fork/exec To: Jinjiang Tu , akpm@linux-foundation.org, shr@devkernel.io, hannes@cmpxchg.org, riel@surriel.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, linux-mm@kvack.org References: <20240328111010.1502191-1-tujinjiang@huawei.com> <20240328111010.1502191-4-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240328111010.1502191-4-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 5uz71x3f3gshz5csyd84jbjkpup7ssj9 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 936EA14001A X-HE-Tag: 1711625619-434657 X-HE-Meta: U2FsdGVkX1/FJvUVt2xfU5MgLExwhM+Vsrtwl781qQaFAqqHJfL/wHt+ussPQ5whef26z9UJrTdYuNj/sQOX1Y7w2mGf/Mxjnr91fV7hmxG4FDKONzYXS7/1ux/48gg43HV9FPo9y9PEmj5eNDf8JJCRZJFSeTP3LytRWo/d3oVHiUlE9bKoO2Bp4VBs7h4xmFKQOBobUSbz+BEH4FYOoM0+DC12Lhy3lJLyVYAClbOAGbjSp6JJ1OrPGQQzYmuTpkqvRAe03VrL5QRZirxgJ0HULTO8RzCURaAwdEAUt/5++tQ1bS/KTyEMxLWLsAFy7tcxtJahYkpJ4r0bLpP4N0R14HY2tAVj92P6TJECJBOIr+QFy5ItvzUEZ7hMsTTjwAyiqjKghxwWm4qmuldNRLipyFQi/SSYLhthrjpTX8jJ6AMY52tSfart3/RhhTvTcF3DoKbIbkoaFFmwxRnG7lP/OrSFvS4qCBlhcABlvztUPZe0WaGcaNbJztT7hc874n7RV7YzHqtFd6MO99hcJVctWbedIF3/vyOkEV7gAzpEql3OeNAVd+b4XFkNIDoNh42XYcqcUrNhA7YAYl5jR7nB1RuNzihLx+99M02WAHR24QMO5Oi93ySnEasYr9xA/0j1UijD70vu+cMn/gFKNWwDOfOP0RQ5kdD0OVZIBaBc3YbM/5e/jq5DWLa3y5omkGkj55mTR6/btDNXgLHjeRrsehN4hpA35DoXUbthXDparDhVkvqBvSauuLiKMR3c92WGagecyFMHUyjsleDQJKGTVSzQm4N3bm9CSzIyLT6xca3Rsr355ixhmTMoUnaLkIxyXFMs7FbbsbCNXH4X+2BAygyE3+csojTwGQ0kxBjnlk7WGndCyqtyiQiYi2YX34bxaEh0ggPuelb9EBTRgPf/WRCr2HNd2vo+DJ1JobAF8MKBqkj6Ch6Z+yGHnVXmTxMQaFHTB5q+QJBuI5j DLKtUc7N nsfDY4Ijyib9iBXlk90TEVpOgP60PMuAyjtY3Oz4JVpyKDWuS0F6BpqNibBFeeZCd8m9V5EhOoDbtGs2WxfnEiQiM50khRqiLyYvmeOc5Equ8x5hoGgDn4kRBZdj6ZKX66UZQEdR5ASOx40Nl0nEZUQvHi0/4TdN2oNeTZE13V8Tbprev8Lb3Tjsm4IAHjz7ZAtjia8ZE7eP8sAuLRqMjUt3AnFypg7Uv6+59BAbIHqT+fLJ1kveQ/zg8Stvx46sA1u5zSVQ4rDgrK0U4SFqZRy46TVukEfCOlasNUSrqdZkGs9zgRjEnFbC8EpapEjTDeS7iI1qNqO4VFH0Q48iKu1adGGtAuSC/BUGz3SdYFOPe8QviK4KtKdf55fBr3hg8YZ3SRrvEgeoYavJRldyXbLCWFR6n8VbzRqxKuZVMZRiVJTHtX/qJerB4tMNDqY+DntwYbkGNFKMjlhQzTpTrgXkYllvz4fE0CYYwAke8k02LYvn+kFpK8eCgFB6a9YguETy2Dw5ho7wVCbM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000555, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.03.24 12:10, Jinjiang Tu wrote: > This extends test_prctl_fork() and test_prctl_fork_exec() to make sure > that deduplication really happens, instead of only testing the > MMF_VM_MERGE_ANY flag is set. > > Suggested-by: David Hildenbrand > Signed-off-by: Jinjiang Tu > --- > .../selftests/mm/ksm_functional_tests.c | 49 ++++++++++++++----- > 1 file changed, 38 insertions(+), 11 deletions(-) > > diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c > index 5462873df84c..2d277620fad2 100644 > --- a/tools/testing/selftests/mm/ksm_functional_tests.c > +++ b/tools/testing/selftests/mm/ksm_functional_tests.c > @@ -475,6 +475,36 @@ static void test_prctl(void) > ksft_test_result_pass("Setting/clearing PR_SET_MEMORY_MERGE works\n"); > } > > +static int test_child_ksm(void) > +{ > + const unsigned int size = 2 * MiB; > + char *map; > + > + /* Test if KSM is enabled for the process. */ > + if (prctl(PR_GET_MEMORY_MERGE, 0, 0, 0, 0) != 1) > + return -1; > + > + /* Test if merge could really happen. */ > + map = __mmap_and_merge_range(0xcf, size, PROT_READ | PROT_WRITE, KSM_MERGE_NONE); > + if (map == MAP_MERGE_FAIL) > + return -2; > + else if (map == MAP_MERGE_SKIP) > + return -3; > + > + munmap(map, size); > + return 0; > +} > + > +static void test_child_ksm_err(int status) Maybe better "handle_child_ksm_err" because you only call it if status != 0. Thanks! Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb