From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 804DDD2AB0A for ; Tue, 29 Oct 2024 09:51:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACBE56B00A8; Tue, 29 Oct 2024 05:51:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7B3C6B00AA; Tue, 29 Oct 2024 05:51:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CE406B00AC; Tue, 29 Oct 2024 05:51:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6DCA76B00A8 for ; Tue, 29 Oct 2024 05:51:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 21C84AB650 for ; Tue, 29 Oct 2024 09:51:32 +0000 (UTC) X-FDA: 82726171206.01.197A1F4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id A36F12001C for ; Tue, 29 Oct 2024 09:51:04 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gLKjtBZs; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730195278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GW+lQ+Vvsk55p8Qz2foFsN9ggMeRarYPXgS/LMyYGtQ=; b=6owsIsc4xqX6elxV9snBqfa/lTn1PnSzFED2jXMOEFGbKpufruAg+2Cdub7rPbd1sXdRIM nMfK7YWncU0ZsStN/qWSjwg+A/9sdm9su2qa1YGBPZdz83dzfG2ntYPAXdYh+Tg7ev64iW IkXmEnGcFv7tn4MX66DAuxx4cHyn1Jc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gLKjtBZs; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730195278; a=rsa-sha256; cv=none; b=GZGF3VhUzc0mEWo6c4HtE3D9AgFVghcgedun3WO57uhTTmw3+AvN3BWUUcC9HVvhQcQAJ/ 7ww2ywktIDNt2BdiN1fXCWlWYNL3CIRnDQQoI3zIpOFZCgPc6VxlsCNZXOMCmp9m64/Jur qqqYrnrAyUOehzkevhT8l0Ru0qWW5Q0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730195489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GW+lQ+Vvsk55p8Qz2foFsN9ggMeRarYPXgS/LMyYGtQ=; b=gLKjtBZs7t5AG9Tf7N7Yo8BTKjdKyayqwvVTW0vKN87rEKQk6v8+bC6zVOOvPC7WfyL/jl 3ACqSu8l0nlVSmb3zqOeq4h5iv14CY7pZ4g8vsEN22cYAiOf1WClvAtVDyq6F1dbbYKwID a9sAO9UkT6Ih86i50Vw/5ObTL1onQcw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-Ps8Zt9mCNhOTqMetGa0qMQ-1; Tue, 29 Oct 2024 05:51:27 -0400 X-MC-Unique: Ps8Zt9mCNhOTqMetGa0qMQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4315cefda02so38679415e9.0 for ; Tue, 29 Oct 2024 02:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730195486; x=1730800286; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GW+lQ+Vvsk55p8Qz2foFsN9ggMeRarYPXgS/LMyYGtQ=; b=UeNSh2KDILHd8jhSnW4fyJJRJbEn3IqN5b+aDcsgRFum9LU6++NawvoME+u1smOyPf CEQenzkpIQ37asNO1Ws2FbRbHgL0FnFIkz0txfesLiAe7gdAdiS9YAI+ursmXAwF5jPl QEFTp3jtCTgCaQbKNX3m5qntcat5aOUsjao7yIpiHbH4iQcn6lJhEDQGYNpz+6FmAKO0 XSsZyg1tRrMV8Sr7ZUZgYMIWtp+9cKdsFEiHrRldKr0ZulwbVGoGDxMRIFeY/fm/PFiB gyrBHg7Er3sgnNjoG/3fU8HDK5h4Cn0jJnJrADbVlWGer3pzDMpy/52jxbuhxXNbSxqe s6ng== X-Forwarded-Encrypted: i=1; AJvYcCUoluYzYkKS3bSJQTo1vDf9LrWPVjJyAJwOoabvD63GpwBCd3/aSU9nYUgBT/al7zhf3hKqzlkRtg==@kvack.org X-Gm-Message-State: AOJu0YzaxtTmNq/gYOS4yullaMLf1AO1+fZV54eLitxJYSoHDYc1Tuc1 1wyPtHjkXXi8uGV2H5u2gwkxYIh1o8zYBQgEMMB8hb3WkffzSMSTgEZR/Lv04+XFbsT3qnOsKHv CunAt66bJIZeRf4R+wbRD0MeDKfrk+31b6MbgUYn/t4x6N1VcKsOq+lSV9hk= X-Received: by 2002:a7b:c354:0:b0:431:7c78:b885 with SMTP id 5b1f17b1804b1-431aa80f822mr44829505e9.4.1730195486372; Tue, 29 Oct 2024 02:51:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHm5GdX4gAdOHeLMJ0lXAl2ye5OSVgxcGZA26HvZWvLwdeYb96ubIhgPmgDmyE60EhtJwmJCg== X-Received: by 2002:a7b:c354:0:b0:431:7c78:b885 with SMTP id 5b1f17b1804b1-431aa80f822mr44829375e9.4.1730195485992; Tue, 29 Oct 2024 02:51:25 -0700 (PDT) Received: from [192.168.3.141] (p4ff23af2.dip0.t-ipconnect.de. [79.242.58.242]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431935a4c0esm140213535e9.27.2024.10.29.02.51.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Oct 2024 02:51:24 -0700 (PDT) Message-ID: <0429a803-beab-479c-bfdc-f9310a19c465@redhat.com> Date: Tue, 29 Oct 2024 10:51:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] mm: use aligned address in copy_user_gigantic_page() To: Kefeng Wang , Andrew Morton Cc: Matthew Wilcox , Muchun Song , "Huang, Ying" , linux-mm@kvack.org References: <20241028145656.932941-1-wangkefeng.wang@huawei.com> <20241028145656.932941-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241028145656.932941-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A36F12001C X-Stat-Signature: yowb9iug7n84arngiw1u7kj3hxkqq4uy X-Rspam-User: X-HE-Tag: 1730195464-115209 X-HE-Meta: U2FsdGVkX19Qs/gH69WKAmpvBYIVpUWZTw5cl2zsqGMfZp1pw8jL070n6Ed9o4IW5vU5ZxWkP+otwsPLOTCOQpbj8xi1AaEO1pH/GK3wVv+sg6HCD6W3/RcEYF2/GDfo1RiaBWDbPN59NnZpfFkZtgn+BD1IUj8KC2eVFNJdGY7BgCPbv4IPcVPXZC8oK7oCmT8ecgffOUDW6R5VEY3Je5oAvJ3HS+jqL1woqcV4Xmn9z1L8H8EoNr49LCQ7UuWF18SpB7HOngsUJQT4uOlP3fDta6gk19G33czG/St3UCDgm5BAYQlvC4LBif+zPZHDajNO9wca9XOm6sxwy2or2ZnPS8Q7Ig63DbSBu+Q/tTmhiLpDcSW9U/YvzYtDTDMFpVe/mU1Gd11SToHk5MoVtpZ7nYyioRQCI9Od05UdvOreofimmqKsxXopZlOLp4q3F4+AnI2sfOQ6vODpwMN776iIXtTvHK82Y6k0eYgIKZgW+YCXd4CBZoMqZhonN4Fm00K5U4FGLyjcxWLnW3Jnya/zg0LbLnxVkzL0eAu0yLvWsS710XrACWTiN+QSK9iYZXh9kqk18SW0BRIKvK0XEB+JrYVubVnsVBQcg8z6XZwMzDiuZitQC9MpPitjj4k0uScnCYDNWh+UuC/hZd259QJQNxGhVRleTauJV2Kc5qQM3vGlsSFXgexLw9l3FeHbCtPCruzpNjjI6ls1CwT36dj3wFxJ2ALzMOpQw4wN3qBgN/RgDJklcHS6TNmZTJo+pk8/atCaC7g8EPpvew2nES3N/sJcqn+bmztzeyenmCAl/YQbfhoguP5h+lp8b4QSEpipEiP5TllFjOlttl7NpUxJKiKo4xm7JTKuVfMZJ2s+qGQ8fuRMirgFWCPgyZ2w9PlGgpirCepMhrwMA+YPkO+f2QwkAE7Q4Sv7CTHzohbgDNOz/mu1VxyVdQhkwYJuiwqb5wuA7UTDfvbjP5w 0cylwgwB rNChDjRj3Vd9jR5CdZYOR03IZ/+M7kjFasaLrR0uvf1wV4310qNFfHLGXFMojbzPjhVtPMpeXRbNhYHUJUSt2R7XCC6ESuNauj8EKElo+mFUJR0QweN7peqZ5fz1pWCFchC0xK03FSayx+27uwU3Ej7MkaSmqtvPn977Hfi28sAsjA7k2gvKTE10HDpHocjiO1e8kWmZ+AK7DB4bAeVeHZG3vqms8J/u+wHfJhTcNndWsPL4uZt9OntLzObAxOkJmK5aPbS9JwRdbq+lvL6iHdhx8vYogBfpcyCjHx99/UWZrG8dJrvGvG89Zp4J8oJhZYdE7jHh93Np59hGzlP3xZgMz3tesJ+wHsMyTsPaySCOEFWoKxmJDC7p3cfVjMFamM1OeZjh/pa3D0VtGidHkQUTpR4eUUK9PH8l62s2zrlk2yGLWcstkb3nwG56uWZM/5NHcEn6rYXa2T3eAABRWNlAwdbLqZkdtLBpBpYLPEOQMwYTmQjAB6lflL//GCgNnL1LY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.10.24 15:56, Kefeng Wang wrote: > In current kernel, hugetlb_wp() calls copy_user_large_folio() with the > fault address. Where the fault address may be not aligned with the huge > page size. Then, copy_user_large_folio() may call copy_user_gigantic_page() > with the address, while copy_user_gigantic_page() requires the address > to be huge page size aligned. So, this may cause memory corruption or > information leak, addtional, use more obvious naming 'addr_hint' instead > of 'addr' for copy_user_gigantic_page(). > > Fixes: 530dd9926dc1 ("mm: memory: improve copy_user_large_folio()") > Signed-off-by: Kefeng Wang > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb