From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCE3C3600A for ; Tue, 17 Sep 2024 10:30:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D4D66B0092; Tue, 17 Sep 2024 06:30:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 384046B0093; Tue, 17 Sep 2024 06:30:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FDF76B0096; Tue, 17 Sep 2024 06:30:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 026C66B0092 for ; Tue, 17 Sep 2024 06:30:16 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A5B091202F0 for ; Tue, 17 Sep 2024 10:30:16 +0000 (UTC) X-FDA: 82573860432.13.1DE9006 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 5A6C1C0005 for ; Tue, 17 Sep 2024 10:30:14 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UmAfT/z0"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726568891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Il6/yr79hfIqszHcYXe2ZQwVjF0GnV7MWdNXGzD9hFg=; b=g6OzxOs+tGZLtHfexHOjMT7AHVJyERi8XOaFW90Mn4cr6WmlmRxtfta53SzdTZjZ26qK3D QnhY3WNLwOTgbE32C6ijBGeBdr6T82xKhp2UEcnvWg3ieaYkYet6wFmhPMvBhx/9+nZIvK 6k3Oo5Lz2i7RXPBlBAMYw4SArBduLvc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726568891; a=rsa-sha256; cv=none; b=fSnODXjCHdoJGKLjzyeDE/+xcp+xbHlwcQ3TifSTbm25xEA8sp0QiSn5Z7bnJvOTnTf1Bn YiMM1hWVZJA+cFDaEJuYhWb7Od+XmyPbCFKKUcHUhX8l8kM/9NujyYzpmqXmEWjFwNblpj 1tPz66OqXYcVzXo+uLqD2QAdJFugRYM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UmAfT/z0"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Il6/yr79hfIqszHcYXe2ZQwVjF0GnV7MWdNXGzD9hFg=; b=UmAfT/z0vFbMAGAiMy5PrdJY6uJV2KhCiEDzqsT1stsApeF8XTPIBCr0B8g0JK2ZeyZP1Q iLegldb50Aecz3205qg1oFsoDArCuiAZNdCZypkaU26rGPBRWHCxqao+eW/eRbSrNvXHDw cZJfmKS/ySjYF3HC3Lc2lvJYtOY+Jq8= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-8IhdNQEANO68OXsv7OK_Zw-1; Tue, 17 Sep 2024 06:30:12 -0400 X-MC-Unique: 8IhdNQEANO68OXsv7OK_Zw-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5c24cd1e1bdso5909256a12.2 for ; Tue, 17 Sep 2024 03:30:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726569011; x=1727173811; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Il6/yr79hfIqszHcYXe2ZQwVjF0GnV7MWdNXGzD9hFg=; b=cdVzb5mKP4Zbh31c70qlDOjeKY8DWFFG4ttf89nTTh3LWesIC8d4A6sbHDUK/NnC7p 4M17PkceN4vXCgfmB58AYZVdvM+Xpi86dPX4pTBqKq+c6NjVBdZv7pRXSJ9OfyLJC+zV TdnJB3PkPEUGyCgrOrvAHefwdOY0Cp+sOhfBLPta+mq7OynQjUCuwrmqj+eU4mWk7q6E LepD4DnfP84gxW7/vhatHdTKoceG+gsV6qUHZMJCeSqwFMWuRI1xAeG8C5ty1d6yyOgu VUpilkSeY0fMBjZKiOPLzXi20b2jnJ9xt9bHMU+6GzxoXdFAYxOMVfRFarv5FiySTKYM 88sg== X-Forwarded-Encrypted: i=1; AJvYcCWd84nWTINzWsagK9p3JxszMt6qnU+aOqSETCxNa2Qbf9o1untEjcs2gxlCoaMxKWNbgt91BKEryA==@kvack.org X-Gm-Message-State: AOJu0YwnrFxbW8HQwGastw2sXnga54dO4ZGCmNms2GH5mFnTHCuSW0pM wkP5Y9dNoRZNttL4P5voqHNnpO9nA7QLhsa6CgtLi8U7miDNgaGJRVkU5fRlUPDaL/cxGQBsEnh DyrhScs+YSLKQgOVi4MJvQKK4irEwKhRJuGS/GvTbe0YA65JJ X-Received: by 2002:a50:cc4b:0:b0:5c0:ba23:a544 with SMTP id 4fb4d7f45d1cf-5c413e11a77mr13969656a12.12.1726569010932; Tue, 17 Sep 2024 03:30:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJTwHM98MA2kgkvMOUNXrW8Gsj1Ct1E78OeiAnmCwzZW8pymJVRmDQoeNYuIOrguJT7Sl3Tg== X-Received: by 2002:a50:cc4b:0:b0:5c0:ba23:a544 with SMTP id 4fb4d7f45d1cf-5c413e11a77mr13969615a12.12.1726569010313; Tue, 17 Sep 2024 03:30:10 -0700 (PDT) Received: from [192.168.55.136] (tmo-067-108.customers.d1-online.com. [80.187.67.108]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb89e1fsm3704713a12.72.2024.09.17.03.30.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Sep 2024 03:30:09 -0700 (PDT) Message-ID: <0419471e-20d5-4db6-ac58-09ae0c0b9c65@redhat.com> Date: Tue, 17 Sep 2024 12:30:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/7] m68k/mm: Change pmd_val() To: Ryan Roberts , Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , "Mike Rapoport (IBM)" , Arnd Bergmann , x86@kernel.org, linux-m68k@lists.linux-m68k.org, linux-fsdevel@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Geert Uytterhoeven , Guo Ren , Peter Zijlstra References: <20240917073117.1531207-1-anshuman.khandual@arm.com> <20240917073117.1531207-2-anshuman.khandual@arm.com> <4ced9211-2bd7-4257-a9fc-32c775ceffef@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5A6C1C0005 X-Stat-Signature: iiyxudr4w9q9u6s66hzhtozinc37uqic X-Rspam-User: X-HE-Tag: 1726569014-420392 X-HE-Meta: U2FsdGVkX18bMcbS+pCNZEIFfc1JXM6VFaMKXpDQAUGu9Tt6ndxE9J+MStRmL9iHLq0vyxarvsorSUDTUkxDMwPM031BKqgXfcDuKSuq1GoGF3qOCNnJV1SVONE13cp1pTsLg+k0hSkS63ppHHtJbPA/nAb3/fPgFEXNwIf7stSpbBlJtQilpzxrgnkwuX1ZGEbjqQzItZF8uuTYbJ0T3z9YK1oZQRYT4pejbBJJQs2ueR4BOoTPp5xg+29+og8ZuYHoh3dLmXkrnpLMqukA+MCWOv0Hby4wrBsyPbT/DFAT92bI+wYNxztHS/hFv5UsvUJI7Gz3YjVrxw+W2rk4QMgktBDX0u7buKJ+33TkOv8HvnV8J2Bz50Aj7E574iHvI/4x52KwONfnsuC+0GaDAw5vTz5gf/h8Y6Qclp/Q9K+/GodW1Wz/afD8NC3PbSWzLLYA53zGS+bW0T/maDa6UJcuE2ekjt7I3mCPxPSw4TS6BWmKip3hGEJO5EJHnAvNgRTzc1e6FZeV8MBjt85CZKqR3jVWROTEGbs8gGWSIM4f2Ksi2dDCzrlbVYtkw5y76T8kEaH1NaArQT42/EaF3KgYALm2rEs7OI0Y1p8RZJkt+GSc0UatPwkrYI9/3N/mHMZOfGFc8ihBdZIwW5d6dRmI1/jGHhn7QzC/9r41YTM8431+sHg3BnRh8qwk/neQNS0hg8Yt+UeeBzUSANvMUGwgxiarkmAOPg6CRey2HktCMMmhfO4XUBESoTFRO2FzkrNW0CFpsdVwxsepgb0zuEgVFgQO8SEUE0HKBWS7VBGsRHz4HL0x1WIm1ErEi260flw6I3PzxbZ3mxrP9oi4eiSOuyiv8LMGwB7YV0/ePzYKKC70c87kAwIJKPDvTgR9KxCUGTScae4/YKP+rRgmcQvIXDQdk8bQgU3cqyEon2QqVvM95FlkOh+5FfVpsatx6FEMb8rxQ7HC9Hpxl2V WIx+Ed/L +Kx2v6eJLW4t/mGiSoAUtqTLnBL0VP/85czMbEoBMPkIeEX2LInPUcWj//U2P1RhuP4VGC1SnJL8IqE7aGVpMaaW+zuypiJxEQNKCH2BcE0ippqn5OSTg8WHLtjltBqJ9iBIQG//0wk5f7rEQ5cCCVa/UtfkJCnKKz5DuoT316aoMd5adVx5MtNphKsN2eIdP64Zuox+tn9CG+e+Mu8h03fkFbCThYdfAQSBHxpVDe1d3tHY9Rir4r5SSOIn07qKd2FNGiD5020BpNNhorXhdD7tKmTbRZPLDokELpJ9X+p7/5RK6cpwKgev5gPPzrzBNnxYZksoMTiWz/fS/jYlVVu1T8z+d63t1AZF/TtW5m9fxzvDpiD4+VmuH2XRP7onG28BwkE89yaIMsu+IFkdXzIxyThs4XAqi3ais/y3Tr5/fCXNB8KCuHn0XA+SXkOo1oUImHk/8D+LbDX54AhdSgev4qx+YgLXrm2Hl/ZPwWOfwbDQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>  #if !defined(CONFIG_MMU) || CONFIG_PGTABLE_LEVELS == 3 >> -typedef struct { unsigned long pmd[16]; } pmd_t; >> -#define pmd_val(x)     ((&x)->pmd[0]) >> -#define __pmd(x)       ((pmd_t) { { (x) }, }) >> +typedef struct { unsigned long pmd; } pmd_t; >> +#define pmd_val(x)     ((&x)->pmd) >> +#define __pmd(x)       ((pmd_t) { (x) } ) >>  #endif >> >> So I assume this should be fine > > I think you're implying that taking the address then using arrow operator was > needed when pmd was an array? I don't really understand that if so? Surely: > > ((x).pmd[0]) > > would have worked too? I think your right, I guess one suspects that there is more magic to it than there actually is ... :) -- Cheers, David / dhildenb