From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ACB3C433FE for ; Thu, 13 Oct 2022 17:12:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 202406B0073; Thu, 13 Oct 2022 13:12:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AE36B0074; Thu, 13 Oct 2022 13:12:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1F346B0075; Thu, 13 Oct 2022 13:12:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DE5086B0073 for ; Thu, 13 Oct 2022 13:12:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 98862414A3 for ; Thu, 13 Oct 2022 17:12:32 +0000 (UTC) X-FDA: 80016570144.07.56176C2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id E3A91C0021 for ; Thu, 13 Oct 2022 17:12:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C1E6B2200E; Thu, 13 Oct 2022 17:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1665681150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=875KymawgiOKvMrSm73B8Ijsp0VVBYGNTS/PvojnyXs=; b=QNKSiu2lxDrvRlUn494XvZsyZLeeBIaZB3wVnkFVrmGosw0xCIAueAZGJ9JOV9PczP0wl4 KTz5/U2aFG+eke1VtJIkOgwP/kf34zUeB6tGSGfrtdRJR8hEfE7Z4By9643OzJfelq9JAA oeEPeXGFDw9oPjos5AWVsinCUiq0PDQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1665681150; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=875KymawgiOKvMrSm73B8Ijsp0VVBYGNTS/PvojnyXs=; b=79nANDm0JBGWrcMBPKpXCjKM+OQdogoPQBJddO6dHwN1/nMyynkrRlSAXr2swe+rf18JaE v5+I7popaVwhyhAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 662CF139F3; Thu, 13 Oct 2022 17:12:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8Pj3F/5GSGNOQQAAMHmgww (envelope-from ); Thu, 13 Oct 2022 17:12:30 +0000 Message-ID: <04114304-7b35-d42f-0155-087e3b6237c6@suse.cz> Date: Thu, 13 Oct 2022 19:12:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: hmm_test issues with latest mainline Content-Language: en-US To: Shuah Khan , David Hildenbrand , Alex Sierra , Alistair Popple Cc: Jason Gunthorpe , Ralph Campbell , Felix Kuehling , Christoph Hellwig , Jerome Glisse , "linux-mm@kvack.org" , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan References: <26017fe3-5ad7-6946-57db-e5ec48063ceb@suse.cz> <7e2e6679-3205-3540-f522-9eaed2940559@redhat.com> <44fcecda-31a4-7288-1848-63003dfe0a7d@linuxfoundation.org> From: Vlastimil Babka In-Reply-To: <44fcecda-31a4-7288-1848-63003dfe0a7d@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665681152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=875KymawgiOKvMrSm73B8Ijsp0VVBYGNTS/PvojnyXs=; b=5dp6BQOY2rAjZVd7sxdRTyilnavU1Vbnj5BfwaCGU8gBZP10crNFLfMPd1nIdlylb83KSD hI1CVp3nM1aUiVSRSF3JA8VlAcIB2CfGEq/84Zbb/PHkqHggg5YPnkU+H8BBe2SjGZXZt7 SArtnjb0szUUNMCu1EPqiaEcOssEi0o= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QNKSiu2l; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=79nANDm0; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665681152; a=rsa-sha256; cv=none; b=BbvdNPgxEDehWegLkRMpUKMN5jZj5Pwkav5DBIZFiFI4ShQ93wuMZW8NNd+bZ6DaciPWkQ uAjihhRNXT3DRJHkZyHz3plk8hSH4d/jd9aCxuKQL+W16Bevy0Q7m1PcKCeWUpPtoi8bsC SO3ypu7tmOCUHPhydESTDmS17SFh5Eo= X-Stat-Signature: mnotm7tg1473y6xxq1x15zo45cm3ywgx X-Rspamd-Queue-Id: E3A91C0021 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QNKSiu2l; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=79nANDm0; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1665681151-435305 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/13/22 19:10, Shuah Khan wrote: > On 10/13/22 11:01, David Hildenbrand wrote: >> On 13.10.22 18:54, Vlastimil Babka wrote: >>> Hi, >>> >>> I've been trying the hmm_tests as of today's commit: >>> >>> a185a0995518 ("Merge tag 'linux-kselftest-kunit-6.1-rc1-2' ...) >>> >>> and run into several issues that seemed worth reporting. >>> >>> First, it seems the FIXTURE_TEARDOWN(hmm) in >>> tools/testing/selftests/vm/hmm-tests.c >>> using ASSERT_EQ(ret, 0); can run into an infinite loop of reporting the >>> assertion failure. Dunno if it's a kselftests issue or it's a bug to >>> use asserts in teardown. I hacked it up like this locally to proceed: >>> >>> --- a/tools/testing/selftests/vm/hmm-tests.c >>> +++ b/tools/testing/selftests/vm/hmm-tests.c >>> @@ -154,6 +154,11 @@ FIXTURE_TEARDOWN(hmm) >>>   { >>>       int ret = close(self->fd); >>> +    if (ret != 0) { >>> +        fprintf(stderr, "close returned (%d) fd is (%d)\n", ret,self->fd); >>> +        exit(1); >>> +    } >>> + >>>       ASSERT_EQ(ret, 0); >>>       self->fd = -1; >>>   } >>> >>> Next, there are some tests that fail (and thus also trigger the issue above) >>> >>> #  RUN           hmm.hmm_device_private.exclusive ... >>> # hmm-tests.c:1702:exclusive:Expected ret (-16) == 0 (0) >>> close returned (-1) fd is (3) >>> # exclusive: Test failed at step #1 >>> #          FAIL  hmm.hmm_device_private.exclusive >>> not ok 20 hmm.hmm_device_private.exclusive >>> #  RUN           hmm.hmm_device_private.exclusive_mprotect ... >>> # hmm-tests.c:1756:exclusive_mprotect:Expected ret (-16) == 0 (0) >>> close returned (-1) fd is (3) >>> # exclusive_mprotect: Test failed at step #1 >>> #          FAIL  hmm.hmm_device_private.exclusive_mprotect >>> not ok 21 hmm.hmm_device_private.exclusive_mprotect >>> #  RUN           hmm.hmm_device_private.exclusive_cow ... >>> # hmm-tests.c:1809:exclusive_cow:Expected ret (-16) == 0 (0) >>> close returned (-1) fd is (3) >>> # exclusive_cow: Test failed at step #1 >>> #          FAIL  hmm.hmm_device_private.exclusive_cow >>> not ok 22 hmm.hmm_device_private.exclusive_cow >>> >>> >> >> When did that test start failing? Was it still ok for 6.0? Didn't test yet, will try, in case it's my system/config specific thing. >> > > commit 4fe89d07dcc2804c8b562f6c7896a45643d34b2f (tag: v6.0, linux/master) > > # FAILED: 25 / 50 tests passed. > # Totals: pass:25 fail:25 xfail:0 xpass:0 skip:0 error:0 > > Looks good to me. Hmm but there's 25 that failed? Or are those also misreported SKIPs? > Possible change in 6.1 and we have to time fix them all. :) > > thanks, > -- Shuah