From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C7AD64072 for ; Fri, 8 Nov 2024 18:56:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2520900008; Fri, 8 Nov 2024 13:56:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DAD828D0001; Fri, 8 Nov 2024 13:56:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFFF7900008; Fri, 8 Nov 2024 13:56:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9E21A8D0001 for ; Fri, 8 Nov 2024 13:56:30 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 35FE91C6A4D for ; Fri, 8 Nov 2024 18:56:30 +0000 (UTC) X-FDA: 82763832984.16.ACAACF3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 8EA454001B for ; Fri, 8 Nov 2024 18:55:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HttrBVEt; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731092048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J+I+5BFvbPCfW1HdQwPZPMhISIQ+GkdJt2xQbEb1CqM=; b=4prwkiiBmbExBqhSiaJWnD0xojsdTakCFPvIMnWTH+WJ+/15xLkyGB54kdkAn0vJAzacym kVW4DQvcZT3S7g/qaH5Jh4+z8ltnKX0w8sYfvPmiJVG7kuqa8ET4k6nac4IHuTyBlnFqYc 89rxpCy70Qv1xNz9jRqK7sf9Oj/XOaw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731092048; a=rsa-sha256; cv=none; b=OLo5hTjIfF9zLQSsB+1sdoHY2F0DKqWlu39x/JByGqaKB7GxqRXhIQuYbUnockW9/m6KOm PrRfPAvOKa9SNhEJafb/I1dxyRmyJwTIdSX8VlMpjsZ8roJTbHSS99JE8mFyFk9XKWmmcQ 4rrIB0CFVlJNwqp6zApMnXbc4befgi8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HttrBVEt; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731092187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=J+I+5BFvbPCfW1HdQwPZPMhISIQ+GkdJt2xQbEb1CqM=; b=HttrBVEtRaBgsT+WyiIlHREEzFHRgSLS/UUPW4sVaz8qputMytCN3LdyD08IfkcfWlU77Q VvBOxhJkmXm52orVj8F5goGCLJmo6NDwhqv1OlCOYlFaDZu3pLbJHty1LX2srDCHDBUy3J B2XDgpBuQhhkid/23quN/IbXr9l/+qE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-whdbXtAbNm-5kbyp94GonA-1; Fri, 08 Nov 2024 13:56:23 -0500 X-MC-Unique: whdbXtAbNm-5kbyp94GonA-1 X-Mimecast-MFC-AGG-ID: whdbXtAbNm-5kbyp94GonA Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37d4cf04bcfso1213028f8f.2 for ; Fri, 08 Nov 2024 10:56:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731092182; x=1731696982; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=J+I+5BFvbPCfW1HdQwPZPMhISIQ+GkdJt2xQbEb1CqM=; b=drMNdsugJx1sTfLAfLnPCItG9RUSfZd6n5tuG2V5AV56YQIJhH5Pu27pPu5Kf8obvG JOb92mYEmfJBUh1AEsVGHnW5V/qpoqsvzuK1/RX4a/k1nVRCwqiUTQKdI9quwPnDwvyE vUJCwx+rRtUAqoaJ06JModbjlxJ1yYYkwKtvJGQUh6M5meOQWEmGCKKIUiUdnfA7srbj TVHGjDiFII+KIy8q38+D07OYehSfKy6eXQaX+qQiKJA8vGEBWeJUFLnCJJBavWGiNP0P MHkkexgpi0uCZhcyhgqT0ItvCGWlcMOB5y1WRSOCrsFVi2i148bSu6o0ib05IQnqRdZc /kMw== X-Forwarded-Encrypted: i=1; AJvYcCW3DpBC36ZtB+VzAlxmTasi2LAcUzW2SnesjIBbVdvuCw3fgpfjT69M5bxfSQSQAqMeGews5FNokg==@kvack.org X-Gm-Message-State: AOJu0Yy4vYgxrQm04wD5a1QE4VrKb+PBkeOFfm1Ihdzy8QvgoHjWT+p+ 1EABNzIg7/7O/6Ec0uLll9mepph54Qz3ub5TwJUDbcJ8Gq8CNRCmd8QR7W4K1y/RcciP3hYzr34 KkICiAIiyc2hKyRTd95PNASMRcr1N0uc5EXidZvraNLhKXXBw X-Received: by 2002:a5d:47ac:0:b0:37d:5134:fe1 with SMTP id ffacd0b85a97d-381f1866a6fmr3368502f8f.17.1731092182643; Fri, 08 Nov 2024 10:56:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAkYj6A739MwOXmyy4DiGBziQqRa5Lpca7nQqTSnnT5e1mZHOuOPwVv/xiuNor5sootscIeg== X-Received: by 2002:a5d:47ac:0:b0:37d:5134:fe1 with SMTP id ffacd0b85a97d-381f1866a6fmr3368472f8f.17.1731092182317; Fri, 08 Nov 2024 10:56:22 -0800 (PST) Received: from ?IPV6:2003:d8:2f3a:cb00:3f4e:6894:3a3b:36b5? (p200300d82f3acb003f4e68943a3b36b5.dip0.t-ipconnect.de. [2003:d8:2f3a:cb00:3f4e:6894:3a3b:36b5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed9ea5e4sm5836870f8f.77.2024.11.08.10.56.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2024 10:56:21 -0800 (PST) Message-ID: <04020bb7-5567-4b91-a424-62c46f136e2a@redhat.com> Date: Fri, 8 Nov 2024 19:56:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] mm/memory-hotplug: add finite retries in offline_pages() if migration fails To: SeongJae Park , Joanne Koong Cc: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, shakeel.butt@linux.dev, jefflexu@linux.alibaba.com, josef@toxicpanda.com, linux-mm@kvack.org, bernd.schubert@fastmail.fm, kernel-team@meta.com References: <20241108173309.71619-1-sj@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241108173309.71619-1-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ach2tnmEwaQfBldPRchoTbZzVKHt7p1U4ADlpy8EkAA_1731092183 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8EA454001B X-Stat-Signature: f7y7kfwckqgei5g8t8mticddcjqyc7r7 X-HE-Tag: 1731092135-223633 X-HE-Meta: U2FsdGVkX195uEd8S8nKTo0fVW5WwMluiXxzT8SIyPMyQgFTUqxP7zZxTwWL1t9ScaF/WoSVvBqC3KRq3fQ0iIs0DxQleo32YK4UGNMbcC2KHd8aelZos9dwqO2Dzs+/McFT1yeOJEygnMdkW6J2uTE3hHrzjNvL3X1gKLEJyY9mecBcalgHkj3L3gu5uWJZrr8ZpjVL0hgzHewKXqzB3VGPboMzUXtFFSO2jKqOUQtLKhQdktqpVtstEFUQM6vmWoMG5nL2J2+i8E5H5eKiB1fZo2SP9hyYRg1P1r2XP8dXbs3iNNNTmT9TwWuHkl3jG2/15Zm+d8nzHPfFxHXGM2CzkfSwVD30ddeJvCwK/vgHvyj+mXVNpA/TIBQ6Pr5kLle9o6NFzMTYjkxHABQe8hYH0A5i6DK6Mwr/SsG56Nu14pZgg7q6MPj6SbXTK1+xnPfmKnk1DUmelzJvs1nzHqjMuVP42U1sq8wLJx4B9sCJBjE32kVXH34ekfVW10yOXEq8qwXA5EEZBKy0o/EO0FOUCcJFU1iWkzQIwMc9081MmuVjklnbsU0mnx2CmUF6FXrrp5lYI14dK6Q6eOZ2KfooGY6i4fB0H7+7lRniZHvIW6GDJ4A4kuZsmwgU1XhnoAazL534vIkuLYk96bOAqOSDXduqTWux+a0muhOJFrD/yrOm6+cA24RrvdTCIo0S5N/nWxTplfKHAjW1uq7oz6ZGuyv6dqHksgFgS0U9u0/02EDooe0o8zzTyr2rsGYg2M9waBy+Yh7SHvrowe0X5d7YwUGSmqpvMRIOPpnbpzS4JUhAIyNnaIncSpXuPdCfCu3FuyL98ziEO566n/EFi4XMqkCWbxDP/OF+0k2JPVifPS/UHGz3gatNH7Uft7zEuCTxrAtmaen/PEAmfbt5z1vIgLMbYGK7bdKM6z/xV/3XYtLOJSb+lDe/mQGTP5e6qiL5t8K9OF4pNakzXFw 3/Cj84ux +i5MTTmzU9jHXPgZbyqHh4ILrc3e2+X/AqsIE3JZaYHVAjHa2UHg7Eq6zHVQCXSVap9ziucOLjBg+BLgF245ZCXnydySlM2RpBmHbgqe+L3Phe/B+uEJKOwzdXKbFA4MixnLZw/tGbQlcomwYvh9R8f0kpsHSCMjvOKOJyX3YkupigcP760qSaYCZ+/SEmITH7oL7/bSEQJ+5IH3O88r7ABYOcppMwgsk3yWy0Z42QNafYP0MCwRXmD9zQE74N+z5bDA/PhjceFlxpg860u6nOn21WgkaTp8DGLOz+u4SmjHh0eYbnE2+VUPJZ1iIAX7duEyQxcTtNZWY6f7aFZznxxGoSpUQrsjM1fF04ao4yFTRYzyTbc7brCAnq12U3+TPgPSjwt5eSikowij6faG+3eMW+zrF5bd9w2LCmPALf/RuCbbwTXPr7ckWB++0bFj3MaHchVThQ3TA4OKlHzY2w3CiJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.11.24 18:33, SeongJae Park wrote: > + David Hildenbrand > > On Thu, 7 Nov 2024 15:56:12 -0800 Joanne Koong wrote: > >> In offline_pages(), do_migrate_range() may potentially retry forever if >> the migration fails. Add a return value for do_migrate_range(), and >> allow offline_page() to try migrating pages 5 times before erroring >> out, similar to how migration failures in __alloc_contig_migrate_range() >> is handled. > > I'm curious if this could cause unexpected behavioral differences to memory > hotplugging users, and how '5' is chosen. Could you please enlighten me? > I'm wondering how much more often I'll have to nack such a patch. :) On a related note: MAINTAINERS file exists for a reason. -- Cheers, David / dhildenb