From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B78C7115B for ; Mon, 23 Jun 2025 19:33:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 655056B00C5; Mon, 23 Jun 2025 15:33:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 606026B00C6; Mon, 23 Jun 2025 15:33:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CE216B00C7; Mon, 23 Jun 2025 15:33:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3E1DC6B00C5 for ; Mon, 23 Jun 2025 15:33:22 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0C8A41D873C for ; Mon, 23 Jun 2025 19:33:22 +0000 (UTC) X-FDA: 83587664244.21.9C4C617 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id B72EE8000A for ; Mon, 23 Jun 2025 19:33:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YIPLhfDC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750707199; a=rsa-sha256; cv=none; b=HaPXjgkfWxJ4E/i972MeQTw1lPlQaSrm4UBQLYmEE+8lCPJ7QIrcxCIJf61iPJtm1gtFDJ jMZ6fzD9MLp626QXs81GrewKJNc1d69Ij/TbeuOBT0qIDXZ8mBP+QwZfnaPkgYaVP3FZDz BcFYMJs7W8h1W154opqnxx755tPhVBM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YIPLhfDC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750707199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K0/+8NFujf4JTzwsWWkGjCoD10GFomMmDwt15P0EBbo=; b=Xkwgz9MGzfrt7BByPQ/9yaveRdTBLjJmjzUvq1Bwc4jpB1j1gCl2CgOfR7MMI05tekCtq4 bdirhUTgyCn3IVml/cKFUpWNXrbLaueWu0rGqlZl7Dt7/kxJ7X4E3cCyzEn7E4LQBw+seo MBByJg3AAfPW3n94KeW3HF4VKVpE1ik= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750707199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=K0/+8NFujf4JTzwsWWkGjCoD10GFomMmDwt15P0EBbo=; b=YIPLhfDCq9rK9VkoV6LbjROTMA+g7EVq8Uf435x/wA8/WDlUL3NSwWkSwK/rUFjfiOV/F9 xxzUdx1ST5BJjfpi90WVdGEh7yWixQvDCL9mVBqXYT7yydoe5QMjqF6GmyDrz6ijCaxZNp Q+bN7U6gtm/e0ZB0al9lkCSFDVc2iy8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-210-Ne5KsjS4McS6vNs1rr_gDA-1; Mon, 23 Jun 2025 15:33:17 -0400 X-MC-Unique: Ne5KsjS4McS6vNs1rr_gDA-1 X-Mimecast-MFC-AGG-ID: Ne5KsjS4McS6vNs1rr_gDA_1750707197 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4edf5bb4dso3612504f8f.0 for ; Mon, 23 Jun 2025 12:33:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750707196; x=1751311996; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=K0/+8NFujf4JTzwsWWkGjCoD10GFomMmDwt15P0EBbo=; b=iVL/QsQCSO8jxnfbb7xcOQCOWrZ8a3BVSmhgdm5HSVT/zoJLobubW7yPQK6310W/wT eBA1qDxZ2M6pXMOSUiU7Y+zI0NTZML8KQqmSkz5DGBDuqPwFcaavfU0SjXIdBc4/n9Fc iXVTOAbaJFuzawdF5U5Ir87MvD63Vl+tk1VhOFSXsPGyrCNf/nnRdTHlpctPdoQe3Qt1 kazir2N4ZWjnw3d61ASA8bJdhXyfz6EAXFUT1X0A1qpJUFSVjUzWo5UlIQsxXYKQ96rg UoKH80FYZ7MUyWjutuemE9zM2cKDsuNv2Z3aWJhZ51BpdH2QNv0aDsX5kP7dB2NAdl2x oWsQ== X-Gm-Message-State: AOJu0Yxo+LMSYdz4WunnZx3VPIYli9ZJfzBsxujthIaq5w6lG3ZjIIiR VZbH+E0LEHtmCAMNrHP2SpRBJEo14gpnoLw9DoWdDTcvJ6dL5BI97DbWHoIdKe/qt1D1sRi9S2L i4nktpQPcDGe/ZBbpbbLNjD70ZWvUPAlW7lkZZYEYD+0ZA5pBInzb X-Gm-Gg: ASbGncuzI17WUKFpNFNSblbgKvg3Ln0MT4UhdetqDLbmw1FcxK0927m9v3c+viwrryE 6cZa4GZubXgQpaLd0ogmWNt0vdiNehmtEiO7prLWDB19O/ZQ7luQt+1azcJHeK5lkfeE4UwfJ3C 0iWIYkzkd1Gm+h/ZY/xfsNak+4mfj+GamSO86PLbpZ0l4oiZmKGjO4PWUVrkVqq+Lt4VbKUHiHY etrPt73mehgwMsKkulYNXTovC9yS00iUvBVXh5jWJlOiup4Ouo3wdSt7d6numts/F6RlbbMVRr9 xPw7CshEK/VJpEMsXOOhlnY2o/uf087CpSzprbd/md/uSD5JNfym2cyi00/Qw/EM9V2amCSmSNf HHDF6qK4FZf04hyeZsLiRxzJVJZclAhPgVUGoaIr9v+FoByPeRQ== X-Received: by 2002:a05:6000:23c2:b0:3a5:2ef8:34f9 with SMTP id ffacd0b85a97d-3a6d12fc23bmr8367466f8f.27.1750707196519; Mon, 23 Jun 2025 12:33:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwjq0vsrWg8eKGsSx4TLrqrpk9YypvFu3BPs38tM7cfCERusESM5p0aomG/RrEUVRCb5Wepw== X-Received: by 2002:a05:6000:23c2:b0:3a5:2ef8:34f9 with SMTP id ffacd0b85a97d-3a6d12fc23bmr8367453f8f.27.1750707196086; Mon, 23 Jun 2025 12:33:16 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535eac8edbsm153409965e9.24.2025.06.23.12.33.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 12:33:15 -0700 (PDT) Message-ID: <04013158-841d-48cc-9687-6c6e75fe65d1@redhat.com> Date: Mon, 23 Jun 2025 21:33:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/zswap: export zswap API to modules To: Matthew Wilcox , Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Igor Belousov References: <20250620193552.2772125-1-vitaly.wool@konsulko.se> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Cv9evoJYYj8eTmtj4qZ7NJd_0dMxfSwO9uI-EAYkXQg_1750707197 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B72EE8000A X-Stat-Signature: g44kc9owobgseywz4boukjrsnp1me7eq X-Rspam-User: X-HE-Tag: 1750707199-666978 X-HE-Meta: U2FsdGVkX1+1LBtvTG8MHHgrX5MGDPa84LqP6hxAiwC1pcu94GTku4fphkxedScus3Pu+/LWrd4pGxtTMnRWahaFSasaBtB3bPQGOWYxVffAjZx2YdvCRRa0nQ7HFDjRgsAfznLfcFvrEAdoUtCSvo5nH+ZUE2jSFGAvREUwerzgtPLEhDalFqztUWHtXa5qD4UzlLWuyDU6g+ToW94BlMH+RjqNr7QeREk8RlYHr7HJCfywuq6bNgQSKanybBqqhq3nAfj/j65qkkXzV1uHf4z0baVzhYjbl0H1L9lVp8ysdShtL9tQ25RQS6m5/WHX1nxScSCBc6xcdOHTzQKlPBlkJycuWGVxkzexfAJxrTVOu047BTstxWcgykVaegIS3u5k2Enl8i9Lh5pSiwjxhp79Kic2bVBsFhPSqr5LGdIZQVLy9GJAh9pu8F8UukNWI71BA0K9z0qoEnKtOK/31pSELmgGXDXaxKUNkt0ptqHdQNZxWo2kVeuClACyacljrrFHboACC5ATgaBEVtUPrPFl4z7en2Gt3k5vZ9nbqyiToQR3enlNKBmb0vjxxXJEb/IaEWoCr9FqvT7TkJwM1/5e61/vTQtItiL/ZPTEVGR3vy4feU2bsOSgWKGZXs2k7mc+jO5s1RHG6qWrhG+9IFayRv0Sc03dcY0Tic1rJNOZkkh8ebJZahyg9kh96TA7jaq4IVE36nM5PNpTipuNd7Nz7PNTVtwhfM9WwyhchiIJomTWkvhdHYGuWwjT52GShSF7rY6TzsOmHbpomVPZ+ykWZaYSPG55bjaF8jNhIZ/rfyHlzI03leIc2EFzOdvZPVJL0T8h7yHqUZhoduK/hm/UNwAwUzrnF4pngu6ZM9tjCH2R9o2uhspYQIw05K7Y1apaWvwzQ3i6hAKyW2c4XzGdmpTBxBQcEd8wrnGLfy4Nnr5WtCZXfZs0E+0+ZS6K8BRR3EQvoKTKyM6/0XW wMqnD9Hs fISGWb7XH/pkyUe2acjvenyHtBN6aeMbnneYvampp0K2GYKpWh2vsGEVSXwAqdO5MgAKcOFjHl93N/hb5bkWuhHU1RS7QxaJqjWJT5hUXI8l97WkgUy8IT9UbEXQQs1K0X0LGaY9GJWiSJ0Hhr+g4gqr2mawWp9XziOeisJCPtOPAQjsm6WDrFIQReSPjO5Zc2TgiX00XO589CC67gpfH+fFSMD/gFQPETF/U5ydsQ6HkGaqUvGzukmChPY5kDLvUBozgDCzuFMRK5Ll98297LNYGs0XFjj/Dy0wzjHjjgYWgaIGhVHiOEVDh4350Gw45k5nnTyQNUliIo+ncX/80IqqOi8r+R3y6iRmunB3WdHiVKy2Dr257E6IyM1nEZt3yHWsx0lBNDaFn4S7YVZXTWgYr9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.25 21:47, Matthew Wilcox wrote: > On Fri, Jun 20, 2025 at 09:35:52PM +0200, Vitaly Wool wrote: >> There is no reason to not let modules use zswap capabilies to >> densely store unused pages in RAM. This will allow to remove some >> homebrew solutions for e.g. GPU drivers in favor of plainly using >> zswap pool. > > I really think these should be _GPL exports. And I'm not sure why the > GPU drivers are using "homebrew solutions" instead of using the shmem > APIs which work whether zswap is configured in or not. In particular, because zswap is tightly glued to actual swap code (e.g., swap_writeout()), and we should review first if any such GPU user should really be talking to zswap directly. -- Cheers, David / dhildenb