From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72C0C3DA7F for ; Mon, 12 Aug 2024 17:51:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51DE26B0095; Mon, 12 Aug 2024 13:51:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CE536B0098; Mon, 12 Aug 2024 13:51:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 395EB6B009A; Mon, 12 Aug 2024 13:51:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1A9C86B0095 for ; Mon, 12 Aug 2024 13:51:31 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A99ABC0337 for ; Mon, 12 Aug 2024 17:51:30 +0000 (UTC) X-FDA: 82444335540.28.EE8A014 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf11.hostedemail.com (Postfix) with ESMTP id C18464001C for ; Mon, 12 Aug 2024 17:51:28 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QqpBZtqy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of sinquersw@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=sinquersw@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723485037; a=rsa-sha256; cv=none; b=8Z4E79yuZsMJjMTK4UUX2Iyp58z1bdVVgL64p4wUZBIgXhR2KEc3bvbJKNi3QICH2IQu+2 I+3NsveRzxgng6elw41URHk+T4DAoGn6QdzrzF6qkrpC3DvkMgiUlCrJL4jIr13xbYswZJ p9Re0zu195FJDGd8xuPdZFAUguSWN6o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QqpBZtqy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of sinquersw@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=sinquersw@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723485037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w3VdWir9GXGF+e3m+U832FlK9QbD8mhoWFFrkHX69HQ=; b=F9MPscgGhqKfKkzksqSA7jq3sBKF6kkGifSWnEP07XVqR/UOs8lZtwD3d5MjiHblkvH4+L NnmlpB5kYUwd2ktOcjbSsucIZ9f3HXPY5J/R1t+5JPOM1IiCGoZ0vovEQTZoj5bKSsunXF ADZf9CPqWF/ia9w6bwuU88rKqVz6zqA= Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-690404fd27eso44268017b3.2 for ; Mon, 12 Aug 2024 10:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723485088; x=1724089888; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w3VdWir9GXGF+e3m+U832FlK9QbD8mhoWFFrkHX69HQ=; b=QqpBZtqy/tjludYuSHQeY38Fca18WH9SVhm7qaF2INV4QELTSWkibeH9/5lEZMnAHP 5NqFnGJfkd0manvaonxe5hn+3I5ohD7Ftjj4tmqrR2SEjk1iMDZjo7Bvf5hHLDunGSv+ 6D2F4xirX+0cHrgg/BYkLA5PbPJ1GESzOPezX4fUMiBYpu27ZN82mn/T3k+ti0/dxyKK s+o0rpNbRV/pf0iWEO57IUXEl5AN69w6PauUd6mlvrxywj6jGD5u4I/Mpoqkm22mSzMD R70Cz7L1E6h3A2pbcfnf9+tGgSssQbZbowQcio5zNyhfr0Jq4Z0ZG/zkyztwbcUWdCY8 qd/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723485088; x=1724089888; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w3VdWir9GXGF+e3m+U832FlK9QbD8mhoWFFrkHX69HQ=; b=iCioV+zl7hVSJQ8XhmDpRVcZyrSNsz3cg02ng+RcvTqdvjThYg/J1iHUZLy6B6zLM1 Ji6S5gWbv5kN+URhz1esG67Zl0t4nc5poOVzUUfcDEGYj8gQGxvsQS9C1Oh/54Arvo9Z il+mKzPItWhnn6VO2Cl38KRVwewk8XfaGl5X//FhqIHKPc6ngoIY1rQK9hc+JMJZ6GtF co0MH/aRwbjYpm6qk9GkfKPDbRGjWYf1xn1uofELiF+yvMUCMBS3vSK+XPddtkypuy1h 9t3pHD+krtpUUTtJKR8rnhmTyZuY6nj9wOmS5qy4yekvhSMsKoz6Hz4mqtPft0bsk+mB mTtA== X-Forwarded-Encrypted: i=1; AJvYcCVucoRtek4WkMeAqQzxSQDvURgHS8LxwDdr23VnOUpYVfkvE18xe3HZoPHk93T/i5uKrqVFgz/9dhqPkLUE8DSuoA8= X-Gm-Message-State: AOJu0YxcXQpzhhAcLKxdydlyS5tAE59xU7jeGAd4EAayry3+tlBA/y+m Jyq2sQCbNah09F1Zp2SGCvAkHsx+pbY1hO4k+18MrSjB9x8Z+TFo X-Google-Smtp-Source: AGHT+IF7VGhJ+Xd5RKhMVC4Z3unUa3NitK1NVNXo+RijUPPpY81FsoXse4Fe6sCE8LFGpdsn1vX8aQ== X-Received: by 2002:a05:690c:dc9:b0:63b:d711:e722 with SMTP id 00721157ae682-6a97151ca8amr13532577b3.1.1723485087682; Mon, 12 Aug 2024 10:51:27 -0700 (PDT) Received: from ?IPV6:2600:1700:6cf8:1240:9b6c:23b8:ec8:40fd? ([2600:1700:6cf8:1240:9b6c:23b8:ec8:40fd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6a0a121a0basm9389517b3.64.2024.08.12.10.51.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 10:51:27 -0700 (PDT) Message-ID: <03fa1e24-4d5c-4a48-a06f-dee2538927aa@gmail.com> Date: Mon, 12 Aug 2024 10:51:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC bpf-next 3/5] bpf: pin, translate, and unpin __kptr_user from syscalls. To: Alexei Starovoitov Cc: Kui-Feng Lee , bpf , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Kernel Team , Andrii Nakryiko , Kui-Feng Lee , linux-mm References: <20240807235755.1435806-1-thinker.li@gmail.com> <20240807235755.1435806-4-thinker.li@gmail.com> <62ade560-dd46-4480-8595-250b0264d3a4@gmail.com> Content-Language: en-US From: Kui-Feng Lee In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C18464001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bhdqne6w8pba9qy86nb141jnczhxagzz X-HE-Tag: 1723485088-466165 X-HE-Meta: U2FsdGVkX1+NxnLYqwyGgOqKqw/Yj2xCzk0AeNULv3d5CpuwQP4I0lFfSgQCUqSFtKY6FR8UUu5CGH+hezesuWMSlTM95PiLDf4FBqReoNzdVIRf/PCVmAG2Mc3mo6FHe6qUNJTMlL2x8aR/l3SWq3Uq7utHf+b8FislenQWvPBKRM9Ezl3R9Ff87EkI6tyMJQjtUHnWuoY1/4zAVE401lnm+36Vmw99Wkpvlo8FX1eAvLj4Ygqm2+G6ORdas536u+QASA2YInCZ6M3tu1lAHN8u/eS76y71qUqrYESme8jqx5kYI45JFLyoJ6OAVh+97kpJpVAB1QnA6pp8tmdMnavb9ntmy97+xlLwFgEUSWqaehvbJ3+dv98iXnRGPbGPnqg4Y4AMUB+KC1bdaYONbVD5jAfjxp2r5IujBsqzGDNS3A6TcRfq4dDl3xVmWf+4O3UyehMsFkDALtb3q2SxhUJi7rN3dbajc8516dLMWD1A9f/dIja8uHQEsMnH8WfVre6v8YiiX89JO8tf9aB6frkv/7Az1vJ1wzg4bUXza8edfh/tkB7VrvkKh28oTEFN76DlHiL+EsZ20fBQ7vRrDJc33OcJydYBq5yUZZHt33O9yz8oahFsSkYPVnAiFoaxB6Az7Bn+L0GUEHru6k/Bcp5OKHSe061ygrAdc5yNK2hQQeZFAFEmfZmpC04KNJDVVKf6UmlAKBIXgbHUQMDolkzAJjcFL0CHUF0/6C36T4vxipdn4SPiKuNwtCQJVcTQw0vABhFmXTaskFVB8ItLIztdEXjzRXDJYFDCnSS0XZBniIsFb2ksFrV/y+6fwXckniMosy6wTD+vOhB4HpKaK5L6io28vZbUjwaxyDKqrD085wzdFX6I8LVHDrAYlA1A4I/gEGSgL2LsA5h5PxuuSNOXr5gkGgad6V329ZG8BkFQNWzUzt50U9R8wx9nR3PJhtrKQRj4VEz1go4AUaR mPFCt2Ce 7E/byFAQmTbNLjkVfkabYQNsLGyfueDP4qhquIfrzpgRczm8d+e+j3wNHlQB4nannulsGFeEZI6HO/IPMkmkj2QHHigAAbg60qtQVNq5G+/nlZcA+wdomcX0I6Z2MUHAbBowBKmdKDTnWkWX1cvZ3ETjc3lF2D+fTkoqVyH1TvZVV8h8f/bKppTSPiDjZhSuNM4ycO1lHKFqeUTNFRHaDCf/Ea6pCEpXk0R5hGY5PC8Y5BamN/Hxp+NCMtWsuPLdpT8+EbPalr1n31lHW0grKYSV2DdmkAsquuHAEV5q1/fauYKwu0jFWYvSLtZJIBCQrGQQKiirP2fsHpCzwMJ23FD25gJUfK5LWtPilNdXawRVaJ74gcTJDQQsAxgqExqscu6hke753HeMu6QSJPIAgpG/L0LQdJeQ7dzfDGj5DDizMS2fzODUymYCf/qvdZ1nmxC2+YvCAmP0SYGz2xFCVXA7tsgvhZpjEsWW+CtasMiiU4mg51u/pBXTYbdYA/TegRVeqRAaCVcuCkgzcwPY/cX+JvNjte36y7rfo7YA+7ckAQIc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000314, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/12/24 10:36, Alexei Starovoitov wrote: > On Mon, Aug 12, 2024 at 10:24 AM Kui-Feng Lee wrote: >> >> >>>> +static int bpf_map_update_value(struct bpf_map *map, struct file *map_file, >>>> + void *key, void *value, __u64 flags) >>>> +{ >>>> + int err; >>>> + >>>> + if (flags & BPF_FROM_USER) { >>> >>> there shouldn't be a need for this extra flag. >>> map->record has the info whether uptr is present or not. >> >> The BPF_FROM_USER flag is used to support updating map values from BPF >> programs as well. Although BPF programs can udpate map values, I >> don't want the values of uptrs to be changed by the BPF programs. >> >> Should we just forbid the BPF programs to udpate the map values having >> uptrs in them? > > hmm. map_update_elem() is disallowed from bpf prog. > > case BPF_MAP_TYPE_TASK_STORAGE: > if (func_id != BPF_FUNC_task_storage_get && > func_id != BPF_FUNC_task_storage_delete && > func_id != BPF_FUNC_kptr_xchg) > goto error; Thank you for the information!