From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97008C5B559 for ; Fri, 6 Jun 2025 10:27:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29EA66B007B; Fri, 6 Jun 2025 06:27:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 24FCF6B0088; Fri, 6 Jun 2025 06:27:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1192A6B0089; Fri, 6 Jun 2025 06:27:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E30BF6B007B for ; Fri, 6 Jun 2025 06:27:33 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 77462810A6 for ; Fri, 6 Jun 2025 10:27:33 +0000 (UTC) X-FDA: 83524599186.08.D280098 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id E80F720003 for ; Fri, 6 Jun 2025 10:27:30 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V0h3aazV; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749205651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B2FoVaJKHKmklTyZk1cv0vTh0MbuFjlj3z+B0k4EatA=; b=iHfVSkc2wRAp+NSaZNCthdibyMjP2KpPD+bUQ7nSIqZQ0SyF2AKFdBRcje4EXD/86SC2Gq L9JLiD9jxeZGAEU/5hTuyP3kiTpOAhAQLgxnUwI8HDlNYNmRsNJinntt5FLPZKE9ufVmpz kz+gdSBFo7+GNMQoz7x1IvnLPxr8BpY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V0h3aazV; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749205651; a=rsa-sha256; cv=none; b=FjqANdugzyE2tUtEDQgUODIXwL5ZspidGJNC15CV5Q/pPpRbz+aL2rgAjpCkuhlgCEGi4H yDHG30+os3yeRV+v13ZDb07mNSsvERp4VAUA5hezCFcG0F0HrSoSXsbOc9jmDa8oLaqIN8 SdG2uh3fmOYQ3VEIW7Lt7syqmOEJLfs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749205650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B2FoVaJKHKmklTyZk1cv0vTh0MbuFjlj3z+B0k4EatA=; b=V0h3aazV0aWm0K4cxe3SdsmzGe4VNc0y1t6loiRssxMH8yfY5S5VwndITVDwVCaC+zfdZp scS/91+DnE3szpf445aVOnxu+oQPffd5m587L+COLqJH+9nLA/d01x82C+3cpkiuoEIT2t s2YeuAojfWhcdPZ9l4yspZnjK5l4t+4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-Vj50pJl3OjqvcrtfKwP9iw-1; Fri, 06 Jun 2025 06:27:29 -0400 X-MC-Unique: Vj50pJl3OjqvcrtfKwP9iw-1 X-Mimecast-MFC-AGG-ID: Vj50pJl3OjqvcrtfKwP9iw_1749205647 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451d7de4ae3so12783755e9.2 for ; Fri, 06 Jun 2025 03:27:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749205647; x=1749810447; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=B2FoVaJKHKmklTyZk1cv0vTh0MbuFjlj3z+B0k4EatA=; b=mWbXUleeR/IMO1HrapCaI5mS4j06MeKJDJ8hnLVLrd0fxmQAr/Y3nuJ+hp+p9R+Ib8 C7n/IIrnK34FxMYeVwvWoT6YnLf2em6Lul8kdL1bSA357DRj8wdVBpilmhXPyZ1KTKpY yVJR4NY0oH76w0fT6fQH9fsD02cCf+uNyob9ZKnoS2Tcn4i8JAxChLctwpGhfw4G6Qel 9zgf5Z6gHfsGSdChhm1ygbIJISHvCXyWPxlQU9qdwhvKb7Kc6jgBu1BhQUhBOby9Qnme u1LikVrxpIqZEkmPJkG3rgO3BFT6va4l5S4sb2uy7M+KEjqSoCwvuWOIOYvxJPW2JEsB 1+Ww== X-Forwarded-Encrypted: i=1; AJvYcCUJHRb1BptyQqBqzfQwB1jW9qjR+NrXCMw+U+UFeCl6WsnUVYeBcPbcRUJEvJ1p8kU/qj8fQTGR2A==@kvack.org X-Gm-Message-State: AOJu0YxIqkxcPFP0ROdozgcK2OtoNLY8/PkeddUu7ntRZ2rzEAv/RdQl aMy/I1lciPI/cPctgxk9nIOigEMMAod0WHwBJsZ7DcQP+KVYXUtmc0lXs2B8hxtdXoEF2DCClQ8 8bJIwNdlIcJi1bcNlCV8Cx71YWSBTjjnHuklCGafWhJP4PEs+hkdefFcTUSxC X-Gm-Gg: ASbGncsh4A3D7Tk8pev1JTfWi54jn6d7UH5S4mGcz/Lbk1eOCHsY4sO5PJZBGhPu153 kwaK4g0oPpz+ZU8EKqdpcjSBIY3v3vf44PQCFiNCREHaSx/cJbZOxhU8wFSYBdDk1tSJ/VNgh6U fBha7fyxgye2k8AtWUIPQ2lRrEPXax/0RrT1cazIgT/AB+7kV0XAF4a5oACSHvxTNGgYTj11tg2 quBV7AtuBjQBar6kiecG6DPpN2H3TQs7et239+hkYRMX5w9idDfRvU8m22OnMBR8NBCj4C8vM5S m4BfbV1AG0EZODLctOFMBmdk4KoQKa4mM5TrB3z+1EILxzpbwkZtwDO5O0o+7keRATk6HhBaRz7 VE/h/VpFanu2cRdymK9OXll8u3UzifcbooQugplqgYw== X-Received: by 2002:a05:600c:c163:b0:43c:fd27:a216 with SMTP id 5b1f17b1804b1-452fa7ed515mr10712225e9.23.1749205646954; Fri, 06 Jun 2025 03:27:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHEmbcYjLTgLVCUtyFzzP95tBUCDltp5qdbSNrDM3KqC5dmjOdzJWRJz8svdB+Fvl+EBl5V/w== X-Received: by 2002:a05:600c:c163:b0:43c:fd27:a216 with SMTP id 5b1f17b1804b1-452fa7ed515mr10711905e9.23.1749205646496; Fri, 06 Jun 2025 03:27:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452730b9b3esm16346055e9.25.2025.06.06.03.27.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 03:27:26 -0700 (PDT) Message-ID: <03fa1946-e02f-4bd5-96bd-e8a2f77c0807@redhat.com> Date: Fri, 6 Jun 2025 12:27:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Jason Gunthorpe , John Hubbard , Peter Xu References: <20250604140544.688711-1-david@redhat.com> <1a65d0e6-6088-4a15-9c19-537203fe655c@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6nU5WlkHspFihz5OMWrX6_TBv-OkcVoHkDpSBjkCpe0_1749205647 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E80F720003 X-Stat-Signature: 9ypbo9idqpas6bjeo716t7sc5mdae1nw X-Rspam-User: X-HE-Tag: 1749205650-385390 X-HE-Meta: U2FsdGVkX19t92MTITIekvuoa7Lu2+lYZwHAXoeDRZ3CYXw0YbJRxFlCZEebiniCPqiLqPN5UPC3LPFPohBDJF8lsd78SWnVBs0Rj1PXYsZgDdGwooonmmQ4iIKi3CCFp6BXDBHaSPnX4Yqj8K4y7VEW9SPk3s6zSYVxWeY1k8IAd2iD00DLHGtKO8VtTA7cm6/QI9NOSGL2pj4w3TLDIuXeDuQP0wWAYSBopqRN//lZhSaBZ7ZLH9YgGJLGiJ1BHlbvBE1EqeSHNXptP18EZe0R2DiKjguZDO2xWxHKARWKO/0fO4cfxmI8bvgXJjuuJYe2awOvIgauVwmxdQpmytM96Y+YQJQCpwLpy4U+0sNGLUxWR4jp5Oib1rX8ezEiMvGnJWgLspIMEtKJtUeH2tMXnrA/LplAYRghXobLCKdQErizFXaOtCFRMiQFYSVCoE+03hEZtn9R07FVAYJpFETZxewBcUwjqxIm/ABO7TiMukKVrQ610S4/8KmE/gzkFd5BmTAt0ligd2KXd/SsnKYGMyWpEzmwmFvXt2GjJuYho/aCkfDuafriUtzyyeggfoH/E+MicFEgYhY5Bj6xZd4iqmCHGnVR7o4K2ucLVcPD/T0+5BSzCH6VilQyy6uu1aORlbzA9zrotBcd99EkdqFuK2sge7eojAtoC8aI2SUSsok/HrXt7kGOMfaF/neMD1rAUL2k/SfLpp9W+zw6efHJvpCN00Ooc5mXK/MviTAWw3xRK/yiS4iHPhsGC6iNtPZd4b3iprE9ko6k8t/N4nPJWnIrSv1ID3zByfdvI2rDY+D8Y41mhH16crHvMeRRKUvU++kcluPhPKSGQF4Z5XoGBakvYPIE4iDI0b5bCJnQLJZ2w43YyWlBygD1jgykZVxe/5HYwY35wlpLht7Ek3TzjOm9w2Xu+nJxQLIxq651exE/tSy+jyMW+lCsU3Hw6ULtAy0Ick69rnXJWBv ebm9ItC8 lZwBNHyTeJnNKbBqDONwUD6XY1Ww+p+vchfjcsvZsjjnEhwyqcxFXLnLkITqIEhW37thQBliv51tGWAJnHkJM5TJNkkuMWxSxg2DmjPTkVu/YD7LXYrhTvqR+sdIFdcKfkTOw9Jp8Tse7qHyTzFnCY/SRIt727rvGm/CyTnwef+2oUZ3zRunthR+DhhxI3ztm7VVShBFmabG8nDkKPat64rJ93OlFWeaff14/ZpMf3u6DXjSBnuSGHANZ+qniL6xYalgjlBcrBCjmnoCeD8A4q5qzxVH54lWKZhQGRp8Vt7EcMWY947J3E87U781hoKt7XM+Tz6kw8rZw7BX9fkDZFq+X67/Rpbn5x404jhLNwq0lRxIjeQxIlXFamMocENAYyd73XK/FBRvAV3Ebu/OsDEo9gsAhldb6yXJyvAVSUkBSqgboIYAMv2FthcNnmnOrdE9ehD9qzkdapzw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 12:13, Michal Hocko wrote: > On Fri 06-06-25 11:01:18, David Hildenbrand wrote: >> On 06.06.25 10:31, Michal Hocko wrote: > [...] >>> Turning them into VM_WARN_ON >>> should be reasonably safe as they are not enabled in production >>> environment anyway so we cannot really rely on those. Having them in >>> WARN form would be still useful for debugging and those that really need >>> a crash dump while debugging can achieve the same result. >> >> One question is if we should be VM_WARN_ON vs. VM_WARN_ON_ONCE ... > > *WARN_ONCE ha a very limited use from code paths which are generally > shared by many callers. You just see one and then nothing. Some time ago > we have discussed an option to have _ONCE per call trace but I haven't > see any follow up. While true, getting a flood of the same events is absolutely not helpful in my experience. Usually one cares about a single instance of any events, even if triggered by various code paths. Sure, there are some other cases ... which brings me back of my original point of doing it stepwise. > > Anyway starting without _ONCE seems like safer option because we are not > losing potentially useful debugging information. Afterall this is > debugging only thing. But no strong position on my side. Yeah. > >> VM_BUG_ON is essentially a "once" thing so far, but then, we don't continue >> ... so probably most should be _ONCE. >> >>> >>> So while I agree that many of them could be dropped or made more clear >>> those could be dealt with after a mass move. An advantage of this would >>> be that we can drop VM_BUG_ON* and stop new instances from being added. >> >> As a first step we could probably just #define them to go to the >> VM_WARN_ON_* variants and see what happens. > > You meand VM_BUG_ON expand to VM_WARN_ON by default? That's one approach with little churn, that still allows us easily to go through them and re-evaluate them later as we actually remove them. -- Cheers, David / dhildenb