Re: [Patch v2 2/2] mm/huge_memory: Optimize and simplify __split_unmapped_folio() logic

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Tue, Oct 21, 2025 at 12:30:23AM +0000, Wei Yang wrote:
> On Mon, Oct 20, 2025 at 03:03:06PM +0100, Lorenzo Stoakes wrote:
> >On Fri, Oct 17, 2025 at 01:24:37PM -0400, Zi Yan wrote:
> >> Let me explain the changes in details below, so that we might find a
> >> good way of splitting it up for an easy review:
> >
> >Thanks, much appreciated!
> >
> >Looking through it seems to me there should be 3 patches:
> >
> >- Getting rid of the trailing loop
> >- Stats fixups
>
> Hmm... I don't get how to arrange in this order.
>
> Remove the trailing loop before stats fixup means we still do mod_mthp_stat()
> in two places? And we keep the stop_split and fixup the stats on stop_split?
>
> If this is what you mean, it looks complicated the change.
>
> >- Remaining trivial cleanups
>
> My suggestion is switch 1 and 2:
>
>  - Stats fixups
>  - Getting rid of the trailing loop
>  - Remaining trivial cleanups

Yup this works too!

>
> We first update stats only on success split, so that we could get rid of the
> stop_split. Then we could get rid of the trailing loop in a clean way.
>
> And this my v1 with patch 4&5 merged.
>
> >Do you agree?
> >
> >Each can have a commit message that describes in detail what's happening
> >and why it's ok.
> >
> >This is also useful for bisection purposes.
> >
>
> --
> Wei Yang
> Help you, Help me
>

Thanks, Lorenzo