From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8694C27C53 for ; Wed, 12 Jun 2024 07:24:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 579C66B0181; Wed, 12 Jun 2024 03:24:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 501E26B0183; Wed, 12 Jun 2024 03:24:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37BDF6B0184; Wed, 12 Jun 2024 03:24:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1682D6B0181 for ; Wed, 12 Jun 2024 03:24:08 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BD89780303 for ; Wed, 12 Jun 2024 07:24:07 +0000 (UTC) X-FDA: 82221397734.21.4E2341F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 820731A0005 for ; Wed, 12 Jun 2024 07:24:04 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="QJqxN/Vn"; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718177044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=79mN57PblL//gRfMCssaahRjclAPb9+bPKf2dv1SbGA=; b=i/I0KQTYTcCSZRSVNljCPiPu6rwLKOEDg2bYujZd6//+gyBfOC8JQ1BQmAz7IXeZ/MnAN4 mSTDKP8S+P0/i4dAzUYcrXj4nCetVnSGtLZpHMeSsllCIUMcXozV18WmnzsRQ3318pKyLh C0VNWMqWIJb9dUFnIuXoOJMegCi9m6s= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="QJqxN/Vn"; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718177044; a=rsa-sha256; cv=none; b=KbFBDgRHLp56PS+LnfbCej32wI1lEiDe9G4I0iAQzNusA7GtTMROhcwbgl/Jtf6tM+6n2x 8g/uccZCn+XVFIEH9P13YaXbr/Y5nOH3nd2XEhDXM8iWe4/qHgiy3KQd2LoIQSYHnjlSn2 Z+5sYgK2SEmAkpE2X15O9287GNj05zk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718177037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=79mN57PblL//gRfMCssaahRjclAPb9+bPKf2dv1SbGA=; b=QJqxN/VngOw9oAJBy4Y5MPGwI9U+/EpQLy1MVHki16ruaTUp3DOrXliU28BvXT/9YTAeU2 wMqYwp6h/kkT16PYQ/xVcRkhRE8e4FCWW+YPFbdb0Dk5VLdI3BXbsF/33/9V/P/4r3r0Ae 0eBgYh/lh+t5ScAi9Y1+gCb3cXgxl6c= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-11lNQVFINdieCnIgNJRJAA-1; Wed, 12 Jun 2024 03:23:55 -0400 X-MC-Unique: 11lNQVFINdieCnIgNJRJAA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42196394b72so21739075e9.0 for ; Wed, 12 Jun 2024 00:23:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718177032; x=1718781832; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=79mN57PblL//gRfMCssaahRjclAPb9+bPKf2dv1SbGA=; b=j27OUa9M2R4DH9ozaisJJA5RrcJEalDvo1N3BUiCUuXmJP96ZcgJJBS3HOA3mRHwM6 yFBfvz5Oj4UyoFRYNZ4bUSUQU1j/u2mWN10dIWpi2ZN+uGaIxnYCyKON4SVE1Gnn3QcS aETZDaQ9kBpO+wjhThLFyVBrQ48Pu1SGBIOBABG+OZlbO3kc35apfOsRhcSP+nSM+H3d 7eKYZI0rxFkmGmbzg/FEaC1XW1BqxyEZ0+R9x525oyEjxFl6uko6RVD5gL47ZIbMYx85 KkRu802KFSjGMM8cyS92YxXOriKu2g9SBbl00U0xdEkQjxZFcL5cWF0OzY6dICpdIdO0 8NAg== X-Forwarded-Encrypted: i=1; AJvYcCW4JsGzA6dbAM95RscFPUpjZp24e4W07vaVlIPwEEmLH2n8Sg0X1rsuqZX8ReqBOSl/XzIhMDmbCwLmY0rKOs1qc6E= X-Gm-Message-State: AOJu0YwJ2/mfExV30IXDncbDMxwjJWjN4xXNn2njsRNI51rSthP/DtVC F0Wj13PKcOSua7BDRpNSdA1355/2eASIYLdTtBjXW5H4Ni0UgjLQTydecSryymkJ/RPCQvPz0QR Et6bTTq1LnFBoCgBxQBK8XwrNavdScZ58xI0xEG0PXUEyTjZY X-Received: by 2002:a05:600c:138d:b0:421:5966:ca40 with SMTP id 5b1f17b1804b1-422863b4838mr11414515e9.10.1718177032181; Wed, 12 Jun 2024 00:23:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtj8PBXU2plzI2QtlIeeLdg/YMNZ/9oe3xZYexWTW7W2BruHYPTtRrm2ij9fTk7U2doAjf8w== X-Received: by 2002:a05:600c:138d:b0:421:5966:ca40 with SMTP id 5b1f17b1804b1-422863b4838mr11414285e9.10.1718177031531; Wed, 12 Jun 2024 00:23:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:bf00:abf6:cc3a:24d6:fa55? (p200300cbc702bf00abf6cc3a24d6fa55.dip0.t-ipconnect.de. [2003:cb:c702:bf00:abf6:cc3a:24d6:fa55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f2169fc45sm8245554f8f.10.2024.06.12.00.23.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 00:23:51 -0700 (PDT) Message-ID: <03f1f5a5-e2eb-4dec-9c03-5d00243ee485@redhat.com> Date: Wed, 12 Jun 2024 09:23:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH unstable] mm: rmap: abstract updating per-node and per-memcg stats fix To: Hugh Dickins , Andrew Morton Cc: Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <49914517-dfc7-e784-fde0-0e08fafbecc2@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <49914517-dfc7-e784-fde0-0e08fafbecc2@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 820731A0005 X-Rspamd-Server: rspam01 X-Stat-Signature: ajfnitkiziyfy356a5pu763issyrj7bg X-HE-Tag: 1718177044-217243 X-HE-Meta: U2FsdGVkX1+ELyGuhkOMCPACunQlUZ+IPrXHJaQl5aAekNoT3OSQwrOvA+3VpJB8p7ARwhdd+aHgYeMtLl2yA0AbR0od3HdUyVJuN8t7Bg41C/1n0o/FGrrlTaFVp4AxHluf5uGMYDq2mjY1WFmzKbc2uY7Ks49PQTO8aDVGRlKymPkco6QVNMfdh7Z8iznCDz/mtQezXquNQoNQqD0jHuj1Wxin9N8tUbJSaTXXhm5XTWSEZgfuZO6cMce58PqgHdqq0wik8n6WRAXhZzUT6lYehcyEcFFMVTvmUsep/HRGZPK33kJv3MqoP1N9vOVBrow+viu18PYthAD6bxjYOEBp2tBOmWcoGxUsUI0kZfXsLsCjwW8JbftvB/ZZV8+YMdJdl9IHnfsioojKBDgzctQQxmUZqb4YhhpXGsWQP9p0sYpLgy4bjUvCx60JA6Jnt+U3cwct/JKvaGFxSPkmP/+48TOyPJJW0F+WVRzrC8Nf+UTu5s2Pf0wGH84gWg2E8CkyoshXHRN6AINwdBYF6iXUDg7AXj9mTthZwl9hkEPNqM2mGO2gebH2cw88plP4E7j1xGy+fsDLYj6lRZLfAbBd0XfPJ4v5beLC94VWdRRYn5ontyf9+4XIS0h+A7mV5Mw5nUnvdKI4qWwQxQ6S3Om6xuHE0l6ZgGasjSArges1f94Fi+B1zVqoIo7Mj/cV8KTM8CFJAxPeRrJLAvcixhcXMZyUd9iS/Qz/wcSNXtNVUh0/08s7AZn6PIfBaPDmaFJkdNVRitJhAqfSW5vIlC+JNQmwJkcREBArTDZZzb9ZW6x9sU9oTjWeSobs8mtPPoK64epydSXU95dp74pzH2ZgmOr9tDm1xzxPA/il2LrG5YCW5ifB3SqAwdip6w3QMlG39utfLmhuZDf0gdahH2J7mMcBz6ezvU384kskxQME/zESRx12Pl8Ryr/IQ+AQ3ZXJM6lmjqSUlxSv4aU dZynaMe3 x8UwjVYw+ac3vn9PSHkQvpYtkUPtVAD2UUVGOZKoTcp2yUd2Rq38MT6skngt7lKCqulsd0rmauNMycYwuMW21jG9U0Flo15T50oBRrB815d2jMhnDz5rfd0HvYnLSIzywW7YjLybvIHyosoz+iTlpNFXh4r6y+bgIyrTWZOqZpOCJoEKwBfeemfKDj0ih3eRLRkfqcn65ticLKdOtu0i+52yQ2MWB3hN+TNxCb2hjCnWGDs9v42fnTZU9u5R5ArO+2OCK26HDiMuAG3RoN4k6nOYZnGYeLGg3LtnrhqxDN9+pGk3OQexUdICcHsCzr3W0f3U6gjZGnaieD6ceECCZK5KD3RLaWm2VRHVwtHs8XI5MZ1sYvpO4jNigBtRQMIS7R1iJhf6vQVPJw6iTczdRGGQ2mtinY5JzyLg4P38XxvQxm0qFH7NXIZ2aB2sx4UcZtCfMM0Zf0C/c0tXIDjvm7YlDAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.24 07:10, Hugh Dickins wrote: > /proc/meminfo is showing ridiculously large numbers on some lines: > __folio_remove_rmap()'s __folio_mod_stat() should be subtracting! > > Signed-off-by: Hugh Dickins > --- > A fix for folding into mm-unstable, not needed for 6.10-rc. > > mm/rmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1567,7 +1567,7 @@ static __always_inline void __folio_remove_rmap(struct folio *folio, > list_empty(&folio->_deferred_list)) > deferred_split_folio(folio); > } > - __folio_mod_stat(folio, nr, nr_pmdmapped); > + __folio_mod_stat(folio, -nr, -nr_pmdmapped); > > /* > * It would be tidy to reset folio_test_anon mapping when fully Missed that detail, thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb