From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00554C3DA79 for ; Mon, 15 Jan 2024 09:38:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889636B009E; Mon, 15 Jan 2024 04:38:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8361B6B009F; Mon, 15 Jan 2024 04:38:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 689F06B00A0; Mon, 15 Jan 2024 04:38:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 506916B009E for ; Mon, 15 Jan 2024 04:38:18 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F002B160811 for ; Mon, 15 Jan 2024 09:38:17 +0000 (UTC) X-FDA: 81681044634.21.7DEC064 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 840792000C for ; Mon, 15 Jan 2024 09:38:15 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iomzGtkP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705311495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=04z7be3ydmxMBIN88g4q9MNYi7AnUXEkoQiujmM8AuE=; b=T0wfsVG+lZiIHDjFVp4jVAoX66M+yfUdByVTzqjJ5IAR3SyLmBOJfg3zfqHfA/2OPn2h4L Bii9GPaNrNZSEXz011y4A6U+sSnBSbisz202teNnIwrXpDu3yBwr8zg4KsvUsRqIJxSRdO k3sIZfySmqf5lOj/elC7L1nWxNp/+Fs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iomzGtkP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705311495; a=rsa-sha256; cv=none; b=m0DP2A5jgOANBTS2/v8vUDqewNyrkwjOqwJmkg1pCaymPjrhmk0cMbtTyaKVOS+dMfiD7q KtQE2jIr2GjLOqVRIVCVtuUBBLdM70PN5+5IVrjb6sfLylJPrN/oUMcBe2Xw5cFUH0bKPk Fa+dDZ8Qs6buaTql3UKxITnyKjDtBxs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705311494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=04z7be3ydmxMBIN88g4q9MNYi7AnUXEkoQiujmM8AuE=; b=iomzGtkPSc1QfbxztkRmHSLOsQ+GQeJbNyRRFIINYvD96LUi1roV+2R4au0dhb3VhdR6tF oX6wAK1ChUANQ4Rxro69trl4LM064A7hLAnhPn1uc4qMXksVX0M7b7Mhra4bUDslUqH6PZ C5zC0YE6Or+65mX3P61Lg0zf0shGQeg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-YRSaEYFlPC2FN0bFjrEjjQ-1; Mon, 15 Jan 2024 04:38:12 -0500 X-MC-Unique: YRSaEYFlPC2FN0bFjrEjjQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40e6d2dbd63so15136155e9.2 for ; Mon, 15 Jan 2024 01:38:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705311491; x=1705916291; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=04z7be3ydmxMBIN88g4q9MNYi7AnUXEkoQiujmM8AuE=; b=MWOg0Q2ELVxlqvptD5CMWCTb++QUEGgKnVCK+3PCCsXMSpgzS9UQuDn5g4Z5OsccrQ 1/jKsLuENuK2qqG58OJBnDtbvVooH69XfrqeWtHEfSUo+j6vkdhqYBmETYYXBXBpYyI3 4osNwaOh7fDj23fNE+iAOJOG9lU101uyC3B7i14fY9BX6u4wmdKz1clgXzBRvYBnfyQu sljDOdK3HANxpAov1QfNduOvDoNXplf2JiJaZoYwAd6iv+rqiAMTSgvR/+ZfyX8XAPi2 lypUA7FsPZ/Ei3l/313RImkqSC1ch5PinBAgg1O9pMDH+ZYv2lkKmm99lnAXmnrIedG5 gMvw== X-Gm-Message-State: AOJu0YwKTJ/pWx+ddPgopxeXB000jTcoWc5ghvR1bHK7sBGVPdvYDRHl 6T8tfFuRMnfkTVhKeXy1wv+S5pnpV7tKqiQnIHw3GFkrFwqlFnARP0ogIMWU18lKDxzPEb9gD+w ctjd+V/Sg7+tCrLazx1U= X-Received: by 2002:a05:600c:5251:b0:40e:490a:ed59 with SMTP id fc17-20020a05600c525100b0040e490aed59mr2695309wmb.114.1705311491332; Mon, 15 Jan 2024 01:38:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFiMsyiLeZVc6pfCmCIBpNcg+aDQLzuKDWbKQWq7uu0ZIUyzoCXOg2hmRk3LmRmziY/x9F7g== X-Received: by 2002:a05:600c:5251:b0:40e:490a:ed59 with SMTP id fc17-20020a05600c525100b0040e490aed59mr2695292wmb.114.1705311490957; Mon, 15 Jan 2024 01:38:10 -0800 (PST) Received: from ?IPV6:2003:cb:c71e:fb00:b32e:3358:38cf:3cbc? (p200300cbc71efb00b32e335838cf3cbc.dip0.t-ipconnect.de. [2003:cb:c71e:fb00:b32e:3358:38cf:3cbc]) by smtp.gmail.com with ESMTPSA id b6-20020adfee86000000b00337478efa4fsm11298366wro.60.2024.01.15.01.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jan 2024 01:38:10 -0800 (PST) Message-ID: <03ee2bda-2c4d-49e1-b897-dd89042fc112@redhat.com> Date: Mon, 15 Jan 2024 10:38:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 02/10] mm: Non-pmd-mappable, large folios for folio_add_new_anon_rmap() To: Ryan Roberts , Jiri Olsa Cc: Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-3-ryan.roberts@arm.com> <41dc7dff-1ea8-4894-a487-88d46ec2b2d8@redhat.com> <1188e67e-5c04-4bb5-b242-78d92c3fc85c@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1188e67e-5c04-4bb5-b242-78d92c3fc85c@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 840792000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: sfxkw4688uiizjqabm144rtbdrqk53w7 X-HE-Tag: 1705311495-910323 X-HE-Meta: U2FsdGVkX193hsXjlToDahkUosCVF0X2+QsCraFvg1WSGlywAnbQLPIOpWPZz8Qf9kbN5t9YXm2D6wq2hix//aGDAZQahSpGY9C3HKNQeOW8mwYZdQN+y5ybJw8E/iLm54cqHEHHxWjIUPnfC+GoHEDisQkpp8LrL0b7uOBtXgW6CS9xrsmjEP5g0iBZuDOit6APW/EDV7oCg3lM3MILgdgB19q4q1rM2e8bXPpvtLLPiOv3wlMFKFzauJXj80Am6j7VDpBqSNyZNWuUQXIxpuCWoMhlGYH989caXvDyo5+Lsiq6OESiwJiQIGdppCki7zszEZuJxBOwa2gSP/8S0ZOoOLfK/lxKN6yMZKCINuBy9Xqaa/PW3dxxDZijHl78mO8EypfVoJMfWAom8FROe3ZcBxd8FBfw2wk5FOGGmjw9qWR9rdCnOnkivTTA4Avt71PQQ2QNrebKVBaBJo64sXQ7b1btr8L0hOZZKTWc1MgaDcTzCGyLgAMsZ+Y9CRZk/UXjriqqDOCcU210xW0072u+tYxSiGdUGRevbXtqnNC8DkBskwavQyVzj4FagjQxarMCaMHvpD53d1c3Wu6eQ5nneFxO67SoJyvai8kSTYOgH5/ZqdcL7r5RgVCHW7Y+EQz/SqwP1XkQGIfHOrL4sw/cTGDz4Ru5+vIwN/B+j3x1nBOvsYCPXKJIGMlael7r49FxNBxDCX0GLK/Z7tqzr2aaPTNTMpW8PdTv6eYFAHB9OCeLLAWAxa2bEwqXFAq3C3NJXL3L5SmdGS77MMLxmadVQ2EWYWEZv6Fyaw64QIJhSTk/1qf21sGS2oCodMtJDm/qN83tZaWSU1taHLoz+k6QTrA8krh5wJYfDNwMIPkygXV6QdYTsRT+I/vV1BMaqqgO/hdt8RfYgJj3+6T+MkHafuFfVn5QB2wMNIDp+cv0mDuuvA7kDyrhi+E/FvuWT81eI2wbllWddwmNisP 7SOxq+Wq D8S9HVSs3ooSxsEM1/n6cyLYKsT0U3ffFV05XoY2ESVU2yfL8RmssHkS+76DeiYxtSuQMWGF9WAZpU6fyZyZD02a3+OADbW/qBFo6ebpxP3XU3CiwwubaX6IHJ3owg+pKQTcKkL82g3BjgASiVXJY0rWlP4HD6UV9of8Ccg+XSKiu0GFOGBEi4YjnhV5yd0lGhIsEseGTuT4anLcXwpewRzwW6pAhJ6zx8Wcc26rNd/GM6aI2hpESjYcQLSU+bT1U6RXyfkgsWZnX+m1Wfyrkd4+v2m2IxitL8Qtw9vlOD5BDvrrITDndlOqEoU7a+oAxVqMwb97QYhnVy4l3Of6xNQfzKJ2zcboGK8hianLJLV/TLqAfNjwu9nooNrFDx4MWqe4GK76DLQZmhIKnD8PQo5NOAtiAygSYwkJDhvhiuzxvXtyntbNCSvgPI9TwZsQSh/hv5xphjKZTfKiaRtgc0vAwNuZEzvQnSO0w1/FzF/kfXAq0e7WGeCdRp3KW2Pf7sS4A8D8IUBLBrxyrPgqCi8jRxD39aUiksBTMwWCywgFOqf3TGFjDPS02fU0x9tqXMITP2jyps8XKQf5N5rleEKRzomQcG5ttLU/S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c >>> index 485bb0389b488..929e98c629652 100644 >>> --- a/kernel/events/uprobes.c >>> +++ b/kernel/events/uprobes.c >>> @@ -537,7 +537,7 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm, >>> } >>> } >>> - ret = __replace_page(vma, vaddr, old_page, new_page); >>> + ret = __replace_page(vma, vaddr & PAGE_MASK, old_page, new_page); >>> if (new_page) >>> put_page(new_page); >>> put_old: >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index f5d43edad529a..a903db4df6b97 100644 >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -1408,6 +1408,7 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, >>> { >>> int nr = folio_nr_pages(folio); >>> + VM_WARN_ON_FOLIO(!IS_ALIGNED(address, PAGE_SIZE), folio); > > nit: Is it worth also adding this to __folio_add_anon_rmap() so that > folio_add_anon_rmap_ptes() and folio_add_anon_rmap_pmd() also benefit? > Yes, same thoughts. Just included it so we would catch if still something goes wrong here. I'll split that change out either way. > Regardless: > > Reviewed-by: Ryan Roberts Thanks! -- Cheers, David / dhildenb