From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A96EC4332F for ; Thu, 29 Dec 2022 06:27:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D0428E0002; Thu, 29 Dec 2022 01:27:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 680998E0001; Thu, 29 Dec 2022 01:27:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 547AE8E0002; Thu, 29 Dec 2022 01:27:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 490AC8E0001 for ; Thu, 29 Dec 2022 01:27:26 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 171C2140680 for ; Thu, 29 Dec 2022 06:27:26 +0000 (UTC) X-FDA: 80294362092.27.006BE41 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 5645416000B for ; Thu, 29 Dec 2022 06:27:24 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nvmp5uWL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of the.latticeheart@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=the.latticeheart@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672295244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wp7a/SqxkJQiBzNObkC8yuL3dMlA3/D0swG9wS0+8cI=; b=YRqNncKAtckGsoF11LWvUJI2/B6IbwBQSJnGVU7mp8nYCHulDCm8CL0wEaW+6r9Q3f3OX/ 4p5TzY65kZtapfzJGLsZ4k0PU9WtfSUHvsG9kkWjyVIdKnPoZhrTuFVm3uJDZEGIcsctyC PF61jv4POeckjM1MhqQI2esBQhIO+Nk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nvmp5uWL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of the.latticeheart@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=the.latticeheart@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672295244; a=rsa-sha256; cv=none; b=3coZvWazCKiLUDtlHbWXCNFLgV6rDuzAgvqofEt1CFt6YUX3+Go/wbLKs69lKYIFGJNTT9 UmxqlHjllRybWVij0j2neTkLsjXoELKH+c4eRZNSpVPWJE8gTypkTFsmi/b5psGA/ACi+8 QU7Rn2orBfBF2B/BgAJIV5R4LmDOtT4= Received: by mail-pl1-f172.google.com with SMTP id jn22so18054230plb.13 for ; Wed, 28 Dec 2022 22:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wp7a/SqxkJQiBzNObkC8yuL3dMlA3/D0swG9wS0+8cI=; b=nvmp5uWL2MCA7VFC+xj2NcKawctJVWIVLQ/dOq9XgsrR4yNKTrP3E78LO9oVdpKjBE rzlmlntfj5UVzNju5fBtj20Xll4DXBF14wk8VGayE4QXdG67kilB6PCmAZdUDAJDEbpa rLtcZTPpyEiSSuH5BbF84VRrVRutdNCt0CiQiH1xYME9L0YH3O3RVy2EwIRrOb7ePKcH Tu62W/erGqOlpEd8omExuIjfN7237/xC4KWTAIx9J/l6DgTm2yNu+lJnmDpPpvuXrEL6 cufvuYx/vDK+COa+jCak6hCzrWfcrxNOosOVPaDX46prvbpIy0HWV96xUVJcma54lyu4 BQSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wp7a/SqxkJQiBzNObkC8yuL3dMlA3/D0swG9wS0+8cI=; b=6yZwOsMfPflVbiHMZ6eTY85UgonrfcJfMrJh+cJY+zHdocptoVtNdXpJDhbDmVZy4E YgwXqewwJB58Ob8+EZvuRCH00x9qdDVJACQTaMzD8EAMPPa+KApFJOUE6FqQCH2PJwsv PI72d4IlRuLl32tauIe07CEaDP/GBLiIRjTNR7wkjk1Vf1qWuCSjVmQcDc6pblG3Ox/c 4YeYRHwuDwsEjlxx66NrKe/I0tGgSrwBX5Rh/ICrKfYRQSn6M1yHhM4Xg4zgrNuViw4Q LoAheDfo89mIanq2vEjMZm+Y9a7MQ/T3DmbEUoouzx0ZBnKLGxOz4UPWZh+S6rhj8lt2 wvBw== X-Gm-Message-State: AFqh2krsx/we6N9biTUBbuHFwbVZpERGQuEu3MQ02P9/YSVgnKK6ibo8 wb2RvmMk2u+8rdVeGmViYtI= X-Google-Smtp-Source: AMrXdXvouxlTS5q6FeDiLy5aU5YcHYFqVnKOe57Ma/nRuF4I7JRhIKzb1XgiczitPxdkQGNQwxYNhw== X-Received: by 2002:a05:6a21:3290:b0:af:757d:a8b0 with SMTP id yt16-20020a056a21329000b000af757da8b0mr40845162pzb.9.1672295243170; Wed, 28 Dec 2022 22:27:23 -0800 (PST) Received: from [192.168.10.103] (ab137057.f.west.v6connect.net. [183.76.137.57]) by smtp.gmail.com with ESMTPSA id b6-20020a63d306000000b0047850cecbdesm10081737pgg.69.2022.12.28.22.27.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Dec 2022 22:27:22 -0800 (PST) Message-ID: <03cb5a7d-a10a-91b0-9e10-6a1147e56963@gmail.com> Date: Thu, 29 Dec 2022 15:27:19 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] virtio_balloon: high order allocation Content-Language: en-US To: Liu Shixin , mst@redhat.com, david@redhat.com, jasowang@redhat.com, akpm@linux-foundation.org Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kalutes@google.com, mhiramat@kernel.org, cwd@google.com References: <20221223093527.12424-1-the.latticeheart@gmail.com> <3fabf076-0fd8-2ad2-52e7-3c2913308156@huawei.com> From: Soichiro Ueda In-Reply-To: <3fabf076-0fd8-2ad2-52e7-3c2913308156@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5645416000B X-Stat-Signature: uizo34h1abigfrp8q89g8ctgjgqcu7pu X-HE-Tag: 1672295244-437980 X-HE-Meta: U2FsdGVkX1/bOO2S3SxrY3RXglukErvbOuerzt+ELjENIeLpM9xGMPbh7Tm3rl/4EU+Iskg7ISUFJKlEJ2ZlernL2VuDfzuWbIbe6LB1UthXxmGPeXxjFy0d/A/48H5aIx9YIZo7gD9pyHfAkLE/SC8IJvOUpBOMEjrYpyeo4drPeK1MSd/orVXpXEV+po0Rd8KV+mmyZBDVUmHANon7OXIZCD/ugP+4a9dWz85jaPJuubTJQj/xdjVwkpnOEBCZo88Or1GhWjkiXAeLtrD0jEhTvl+xoHbg1Q0LIoubFl7JAtkLqaeDvmDvm/b9052gpmIpCSh1jjcBI9FgpbuT4my+9H5wl+5YRigxtWFAn47xd8cYl16oHFJRz8uI9+x1PmuUv17SRyIV4EN+2A8kHvo5yAUNSomOg+1RK9JdxBRL/fFt3nJkkMvZQ3EyQ0nb9zj3eR/TkwAdP/ILAB0okKpUB2l8R8ZTenw1YS96DuaYAs9pqbNenY6EmPcPQRlsf9q1nsvsh7LULKpwv6Nqb2IdlQYdBwF3Wm2JHgqQyMHdgZS9ddNXqeU/2ka3w3OucG9bsPKebbxk+ZyyQ3KwmJV510xD6dENBIwNwrhzMGwDwsohVnzggSKWsg0gSLiM5iOLqNisLC5vIpFgT4DsFgAhNliUR9XKTJ8y8i+/xpPPGQrdXqStX6PH0iuei5R/AzyjRk/XhdVyeJD65/l7Z65/OBIKP1Se2G1HFkdtFHI51xQs5xB5+pAEqCrX2M6dU74tIJmnbjA/CtrxTwWq+mSO/lW74R0nDOSPXZzhXxpX/l/2UTTa1tzrpKVS4FBcGXSqoweNiZg+urOEbPckhd1bMgkdh8q+3A60OJXm5q7JlCFHY3Kp/oEMvhuF+Ywh73vrN/R8mgc606SsbzAXKo+L2ISxIdKJOrLvKAAaq/I6fc5NQuMyrll6K4y5baX/XwDV4Et8Uw81WktspF/ 60jYF0gJ 0cxpEv7PziT7IwJe8Xur8vh7szpwg96JLLMXGn2LBCtjUCim5squFRgRg4ImwF6OhFqzd+IXoArqtdp010odj3s3rqINmF2uk8amua+J9AcakFHT/yqbEVkSvrBZ7HfkN29sJpt2Pxobun+yVS9yIGWnlv1wBFMQjSEfO/JIt/JvD0jI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Shixin. Thanks for checking the patch! >> + for (i = 0; i < num_pfns; i++) { >> + set_page_pfns(vb, vb->pfns + vb->num_pfns + i, >> + nth_page(page, i)); >> + } > Since the interval of vb->num_pfns is VIRTIO_BALLOON_PAGES_PER_PAGE, > it seems that the pfns[] should be vb->pfns + vb->num_pfns + i * VIRTIO_BALLOON_PAGES_PER_PAGE. Definitely. >> + vb->num_pages += >> + num_pfns * VIRTIO_BALLOON_PAGES_PER_PAGE; >> + if (!virtio_has_feature( >> + vb->vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM)) >> + adjust_managed_page_count(page, -num_pfns); > num_pfns is of the unsigned int type so need be to converted to long manually. Oh, the second argument of adjust_managed_page_count is long type. So it needs casting as you say. I'll fix these problems in the v2 patch. Thank you,