From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14859C4167B for ; Wed, 29 Nov 2023 22:20:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A53106B03FA; Wed, 29 Nov 2023 17:20:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A03986B03FB; Wed, 29 Nov 2023 17:20:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A4D16B03FC; Wed, 29 Nov 2023 17:20:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 766E06B03FA for ; Wed, 29 Nov 2023 17:20:17 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4E16CA069A for ; Wed, 29 Nov 2023 22:20:17 +0000 (UTC) X-FDA: 81512411274.05.AF6E2FF Received: from mx.manguebit.com (mx.manguebit.com [167.235.159.17]) by imf18.hostedemail.com (Postfix) with ESMTP id 6D8D31C0012 for ; Wed, 29 Nov 2023 22:20:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=manguebit.com header.s=dkim header.b=K3EUNDrh; spf=pass (imf18.hostedemail.com: domain of pc@manguebit.com designates 167.235.159.17 as permitted sender) smtp.mailfrom=pc@manguebit.com; arc=pass ("manguebit.com:s=dkim:i=1"); dmarc=pass (policy=quarantine) header.from=manguebit.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701296415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lAhLSQiYSgh1S91e8MfKxtWrN+vewtZutl2e/zqiHg4=; b=XErqtjbA7US0dXvOv3ly6qC8yFogxT6/6Ps8TSMcf6xNwsHgZjaGPox0Y4bYsUodY9R+25 /rP0VXX6wopeWP5/qfbL9UBqa7daaKi/ESHNgMMx4X1xjUewPfaBnI0XBzh+GQNQoqDqLv muKqbIzM4VOz5m+CBGZTNF/KsD7/AkA= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=manguebit.com header.s=dkim header.b=K3EUNDrh; spf=pass (imf18.hostedemail.com: domain of pc@manguebit.com designates 167.235.159.17 as permitted sender) smtp.mailfrom=pc@manguebit.com; arc=pass ("manguebit.com:s=dkim:i=1"); dmarc=pass (policy=quarantine) header.from=manguebit.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1701296415; a=rsa-sha256; cv=pass; b=sxbClkqsjhiF45OkZKUvGR+d8dOsfuhJSH83LMVGnqWl9wySOLRSP1KDSLn+C9jIPWJl7l OKT4tqTGhH0DKPi3G4bL45PJEf0F9Y2vcV2Ns83PXgoSJnpmqVAQx9fqJkIiyTWLvqPhL1 QKXjL222qCkMLEMYZ6mO2ym56mRU6PE= Message-ID: <03c9be922f4aa266fa74f44c21027e50@manguebit.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1701296414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lAhLSQiYSgh1S91e8MfKxtWrN+vewtZutl2e/zqiHg4=; b=K3EUNDrhp73skkmFRZ6csfp3ZsSDmFJFVXdpLP4zLVF0AX/7rtH804wmQhaw1tjeztGY+P IM4lOStnXpMVP0xW23/qVdazWC4x0EeKmhNEMKWWyVWsTymTTdEXN4hc13lwdJCSwh4HfM vc6kQzQsnsTQUWiH+WgJLiavpUrzp1OxaM9+ADd5v4CaUu2GmfPftFPcf7CQAloXj+bBA+ lnM/WKxKtnUFhJ5R7+g5T8Kq/kzh6LzTsnDb3bWidI9cU8aeSggKXRxvlPwL/k/LEj2W1z FRcguIsxDgxsLokR3CQS06n7B+XCuOh8zsJQ9nhxePRtWgDIe42XqkBUmF7Itw== ARC-Seal: i=1; s=dkim; d=manguebit.com; t=1701296414; a=rsa-sha256; cv=none; b=TfelgFgAT+x+A2MOAp/U96xwT6RnZINU39mv8glRyDV/HSGHywYJx3vL7cdObp3BzzIqi5 Tih8nUHbnPiilODl3lPXmhLSioWajZ1U+t6T26wqrWDPK7Tlc7yKVIjbnV/vYVuoUITXKu 1i0yXYOmPNU+OXGIMgeVhc+R9G2osiYshjnUqGi0F2dM0F8m0E5fDcSKz635J3UcwB4P5v 6dEKQCGRF+Y6CJ2seWD7fsCFCi42R60WSxmx6ARDro3q65WXKNWytyXd933nXArvG9Xbhv F/7uK66st1/SJo4lTk9MYIKrgjctd1/2NLzP+Rr+28dKaKy8yD4XGFixu+iAeA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=pc@manguebit.com smtp.mailfrom=pc@manguebit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1701296414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lAhLSQiYSgh1S91e8MfKxtWrN+vewtZutl2e/zqiHg4=; b=rkx/YODpkyl84yTIbM4EqxSwYg6PJmh5s8cOAlI3GoT6rx4TYFIwi0fso/k3bh5H4Jt4sf NF7Fgp+qqv1/E0R7//VRN1GZRIzNhCclsWuzbnfEeKRMhf18EaOI+frRyZd3c4UXBQY2Oy 6PCOaF5H0cRjZN9Bd01wiZ3GNvqSmHRYb6m5tljrfCRx+iMlog2JkfJnZY/bfEETH/17SM Z8Qd5jqLEpGeQJV0pbQPFtpMrq3GWNfTk+o+9hf6yl1I8baG8Xc3IwEmluw+7MlzeGz3V9 sfLOt1WnMKVZdUCcYrOhZDhNaBi9P1k3KQXw5+11R4Ao6bG6zDYnj1MapBJ7ZQ== From: Paulo Alcantara To: David Howells , Steve French Cc: David Howells , Shyam Prasad N , Rohith Surabattula , Matthew Wilcox , Jeff Layton , linux-cifs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/3] cifs: Fix FALLOC_FL_INSERT_RANGE by setting i_size after EOF moved In-Reply-To: <20231129165619.2339490-3-dhowells@redhat.com> References: <20231129165619.2339490-1-dhowells@redhat.com> <20231129165619.2339490-3-dhowells@redhat.com> Date: Wed, 29 Nov 2023 19:20:10 -0300 MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 6D8D31C0012 X-Rspam-User: X-Stat-Signature: sz7fynn5pzmunafwbotjwqednjdjz97i X-Rspamd-Server: rspam01 X-HE-Tag: 1701296415-215601 X-HE-Meta: U2FsdGVkX19mE5I97h5fTNY0dc16HEh8rUyLdUqhh8divW2Ds4MBVRD1twtGE57thninl0E59/ZS/l+pYf9QPCDoTqQ65dV3q1FMpxiJP9GDxfAe1QnIApqzgb8MC3+8Go7xB0lm24WfTRA6Jyq0+tMx9LDgofAQG2/g6l59VpD1fgK2XPq3mUM6xf/QN0IjvOc8WaFdC52c+quX47XdyJNQ3pBgh4QncOgVcdtWNNrVp3qCQDNS6ziNC+8XjsYYnT/SD9PwEBz0crdFbbSQgZTxgtYBq+ZkGrxpMFvvyshCFAByArpNASmKZQYyJaEwkki4MQ9MQ/Da/MvoNC5TPIdDNHuRStbCN7F8hs2k8jW+nZqDcEPr+Jc/j2L/Kn/eVXPN3RDGJC4D3wwB57rxETPD0JGKcwRT38cXzTMNEL1NrmEi5ABf1aynY32FLFb1AdA1kAx+drqA04pQjio6epZQcqYXyGMPFMgAgGFmTlx1+Z1ROIPEqL8sNd44JBGom7aEp2dZn0fFNPRly5xrOk825785Rr5ngpKKJMA0Zzs9ij2XmsoIzg47LKECPXajgC8KytGsBNUQKcgu9JL8s8hxzGR1J3J7s1VvY3ZEa/GZIHO2vXeDlh9osePxyVNjdj3KQt+J9Qzfzwnf/1rpqYtp2tf4dKW9sl400G7lzlAcsOPGEoNUW7+FgNgz58qn6vmZVZ4542kM6RAb80tT82uNu27Bd9BFQL+TEyKRFzRR7lnfLewMr18p/ylZMcYQX6U/0QfSoEbqG7EcOT9AhkhQzFDmFXiyQaFz1NrsJc7iIUxpZeB5Y/357N4I+iitIzslei4msJLj34RJ76OcFsiT9lHRQJ5A0bhZdk9vr18QcJRpsGZhEIDZt/bfdtu4/6zWcQWAVEG/QL8bRx1qSvotZlXz/lsiv9Z6KY4GB4HXbBhhOdtwEAkxSiY5hK0ZYPqy8C+BFMQwH6ncez6 LLVL3PBR 3zS0IHYq9TT8ypvXtjoobm3C74NcXO0/CJGPgqjldULw8C3npaac7h/g6U5jhsxt6f77eVBSrw6kl95UV5ELaJssoNcofJPZCnt4SJNgDZEP/867sKnpJrqxzAcKhf9yacFZ0v15cyiI0tw22XbLj6e8b8Fezr9Cyjxn3QmTDzJpMNZg6ejIWa8D2z5YAQWe6q+28Un6CaAMjbNg2yXUSOC1jisNH/5ybVNk0iBSrd9FA8Zq/8qvjtOBL8qxrTwzw/wHQ9ikx543Plleji9ZGFuC1XpwTgyas3n5hDSV+bzetiwEvXbGzfQU6+B5UOmTNNqYWdsNARl9+ybDxm5f3z6+9j3EM7tZ44fYyCFPeOgQgKsYYhk20tH6bV8UiwAM0LRwX+RB3Vl0/g7aeotDaK0S8nCMZQS9h4656gdMK4K3g+GO5vaQYW+2Popu4UOmGZXZUGH/KX+13EUiAljd7FhvuLPd9IKZbDb3tllHp0yRLaqA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells writes: > Fix the cifs filesystem implementations of FALLOC_FL_INSERT_RANGE, in > smb3_insert_range(), to set i_size after extending the file on the server > and before we do the copy to open the gap (as we don't clean up the EOF > marker if the copy fails). > > Fixes: 7fe6fe95b936 ("cifs: add FALLOC_FL_INSERT_RANGE support") > Signed-off-by: David Howells > cc: Steve French > cc: Paulo Alcantara > cc: Shyam Prasad N > cc: Rohith Surabattula > cc: Jeff Layton > cc: linux-cifs@vger.kernel.org > cc: linux-mm@kvack.org > --- > fs/smb/client/smb2ops.c | 3 +++ > 1 file changed, 3 insertions(+) Looks good, Acked-by: Paulo Alcantara (SUSE)