From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D6EC5AE59 for ; Thu, 5 Jun 2025 06:19:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7295E6B0092; Thu, 5 Jun 2025 02:19:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D8786B0093; Thu, 5 Jun 2025 02:19:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A04F6B0098; Thu, 5 Jun 2025 02:19:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 394736B0092 for ; Thu, 5 Jun 2025 02:19:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A6DBE141A4C for ; Thu, 5 Jun 2025 06:19:33 +0000 (UTC) X-FDA: 83520345426.17.736EAC3 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf17.hostedemail.com (Postfix) with ESMTP id 470F14000A for ; Thu, 5 Jun 2025 06:19:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="HJ/VLELa"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="53sHyl1/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="HJ/VLELa"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="53sHyl1/"; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749104371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OMbhcZbCeEqhLQVEpQtGmU6m8hH/pjgYtw6RJLlYjuk=; b=uobanisNUmwQJGk8qOQgXG8LWe13nV+X9fFbIhmqQZ17ixiH4QrkTWaeHf2lKpb93Tg/6Y P6XolXFsw+wCMOZ6yTHIw+W19Vm6nB38nDlVZhJLoFm8Ofc7I5oDKSUDdpfotHgg9LGrK/ GmBgrI7Wbg3Vf1JORARa2dOgSlu+/sU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="HJ/VLELa"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="53sHyl1/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="HJ/VLELa"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="53sHyl1/"; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749104371; a=rsa-sha256; cv=none; b=TRMrZV2f9Hz39VHOxQhk8rCAoDwJ9c4afk0EIGmudE0bCG5unqD/3c1/bMMvDL3lQS4E3W H4Xvlm6+Y/MLN/UgX6idzbByJgpKYneiW5u25Jgd8tCwgL/6/bRclF6grAy8mw8bHDfFci fyMzqLnp27rF29FGNs4JyrP8vQxLhv8= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 776DC20EB8; Thu, 5 Jun 2025 06:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1749104369; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OMbhcZbCeEqhLQVEpQtGmU6m8hH/pjgYtw6RJLlYjuk=; b=HJ/VLELatXJlV+UxFJEET8AnxMQAfqqNbKoO9sJYES8uV712/JE0PLGKObVBmQfZiTPtbY BtSPQ22SojiznZstWEuD0dq3SaFhisBDSyi2DcEkKTJ+R0VFkyflXAqQkN4GJXor9ktQSF h9DLqKeDhVhaX2Om1FZaTZx3ojd+p8k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1749104369; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OMbhcZbCeEqhLQVEpQtGmU6m8hH/pjgYtw6RJLlYjuk=; b=53sHyl1/OacrWNnQlL8wL+uhwhVY7E7OWpVh7tIAT5HrsqB34SCIgM7HfCpb4SC10jRXZZ CZL4z8QELecg8YCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1749104369; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OMbhcZbCeEqhLQVEpQtGmU6m8hH/pjgYtw6RJLlYjuk=; b=HJ/VLELatXJlV+UxFJEET8AnxMQAfqqNbKoO9sJYES8uV712/JE0PLGKObVBmQfZiTPtbY BtSPQ22SojiznZstWEuD0dq3SaFhisBDSyi2DcEkKTJ+R0VFkyflXAqQkN4GJXor9ktQSF h9DLqKeDhVhaX2Om1FZaTZx3ojd+p8k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1749104369; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OMbhcZbCeEqhLQVEpQtGmU6m8hH/pjgYtw6RJLlYjuk=; b=53sHyl1/OacrWNnQlL8wL+uhwhVY7E7OWpVh7tIAT5HrsqB34SCIgM7HfCpb4SC10jRXZZ CZL4z8QELecg8YCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 44D27137FE; Thu, 5 Jun 2025 06:19:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id v6j9D/E2QWhSFwAAD6G6ig (envelope-from ); Thu, 05 Jun 2025 06:19:29 +0000 Message-ID: <03c2b01b-18f5-4015-a19b-79b8af656697@suse.cz> Date: Thu, 5 Jun 2025 08:19:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmstat: Fix build with MEMCG=y and VM_EVENT_COUNTERS=n Content-Language: en-US To: Andrew Morton Cc: "Kirill A. Shutemov" , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Randy Dunlap , Konstantin Khlebnikov References: <20250604095111.533783-1-kirill.shutemov@linux.intel.com> <6fffd2fe-0cee-405f-af78-b57b5e5d02e8@suse.cz> <20250604142043.bdfdf4f9a6a6cbb57946f1a5@linux-foundation.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250604142043.bdfdf4f9a6a6cbb57946f1a5@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 470F14000A X-Stat-Signature: wik8x7pof3m7xwo5wornaxmc4on67qhc X-Rspam-User: X-HE-Tag: 1749104371-781605 X-HE-Meta: U2FsdGVkX1+F5ClB7Xr34IqcH1KWGkelEXs6tGUgEbSYpHWaEt4kedjJnJaK1eZ/6Viqxw1pap6BVXN4ED3yF4DqwP1qAZpCZsNMi/B1Jl6pgxMQymjt9ND+xmubUChdMSfm8lf95Gdut1E/1rmr1BcNI2GwmT+r2WmryqF6K9QfmJXbxWE0qomJ4bLgpIZ/2VKz9lI1vCpPygdwlu8pA3o6jC0Xa4xg0wI+um8/Pn3h7GJSub6R/A8w6PKFnQPYznWRrbPv0h9ukDgode8yTzfCehmPt0hJAKz3XUNDz/8rrXl/A43YN2dLDPrh8wgJLmjxB45NKFB1sdQ6EJH3nbT7vTIoro//QlmL/xxpa5WsOfsmp3yobJNTdNjwP1EZhA3zI8KZPnNems8RbYFu79UEi4XWSqwdx63U39W7sJd0WwL5OEaActFZYqSs0rb2YAWDeq4TRlLlEaWZZOMHsuGO49B+SFt/mcCUW4/ZnbPofPD/2z3LzeN3F44OKlgiqAczgWuI6D5Nujno73LudEpQxXCeysvr9XTB+ZGJc0fJJ9K+p7dqzBb2+wMPZvomAk3IqznCAtgMkmMHQdRAGPlZTOWph829jmg3L9+sz72aePpQWBCS60mxu81Ej4G0o64rlAq15tt5dhErPD9JBEm0fAkeLlAaL0Qi3kU4KWa0a1wEZ1oMyKVEPsps3S+Ui4lEtg2wrke+V4aGDINCYieTmMPE5j/xgO38M57sDeraAL+Jzd4o8sfe9Sdr9v0ddXeJ66u24+tpVoEWmqefylgw/tlK4VjISdxB5GtG9qAi0o/TgdTz58lUeFMYXNOt15hRWqUw5oH+gFtgWBQ4jCkR2JonnNBUnE7Wpp/kHIqNHx0VoaSxZCvPWOPvu/dGqyTLkUjzKMAMaKnrFGbKiXnHlCxDBhn4sAY3FvFSBlV3mmisG8Ti0/uIsO0DSPZGojgjKLmEn2Qx7TB5PWt Ko3tTCdz mRDNvSoSqy8w6rr9F2jw2fMSePn/OjEBZrKe+wLWTlZna1KehNespwsSJh1rkkVKqsM9EPiuwSS1uoNVGUpuNTB6sTGr5M1aKqNA/6nGNghDNfOetyst4NDP0rgjYCgR2wLa6pXwSuLuPki6RdRvPT67jAMFaLavYiO1zlDAAk8MWy1zp1y9Qn0gGF2DTDS3vXNMRp6mF1a3I+KHr9ea3D+kubHJnQI5MVRvLHoFB0OBLl3u56sI83oWoMSBca1C4YNyNHu+623nnlFi1XbQGA2bitWgOT00LoxE8d9y8yy46itpjhNQJPqHZ4S8HCKjC5DZUJfQLmERfO/OULxrqz5ugY8aZaG+h7SqVE+t2Tum2JsNRuG/m3T1WS+/57HB2kmSHpUvWaIO7u5ZWaVOJgsUzL6aj2MhhU5P+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/4/25 23:20, Andrew Morton wrote: > On Wed, 4 Jun 2025 11:56:42 +0200 Vlastimil Babka wrote: > >> > There is no need to backport this fix to stable trees. Without the >> > strict BUILD_BUG_ON(), the issue is not harmful. The elements in >> > question would only be read by the memcg code, not by /proc/vmstat. >> > >> > Signed-off-by: Kirill A. Shutemov >> > Reported-by: Randy Dunlap >> > Fixes: ebc5d83d0443 ("mm/memcontrol: use vmstat names for printing statistics") >> >> Well in that case I think we should put Fixes: to the BUILD_BUG_ON() change. >> And if it's not yet a stable sha1, squash that together with this? >> It doesn't seem ebc5d83d0443 alone needs this fix. > > I shuffled things around. > > I moved "mm: strictly check vmstat_text array size" from mm-hotfixes > and back into mm-new for the next cycle. > > I reworked "mm/vmstat: fix build with MEMCG=y and VM_EVENT_COUNTERS=n" > so it precedes "mm: strictly check vmstat_text array size". > > I reworked "mm/vmstat: utilize designated initializers for the > vmstat_text array" so it comes last. > > > So the applying order is now I checked and in general it looks good, except a nit below. > mm-hotfixes: > mm-fix-vmstat-after-removing-nr_bounce.patch > > mm-new: > mm-vmstat-fix-build-with-memcg=y-and-vm_event_counters=n.patch > mm-strictly-check-vmstat_text-array-size.patch The changelogs of these two don't reflect the new ordering though, maybe Kirill can provide updated ones? > mm-vmstat-utilize-designated-initializers-for-the-vmstat_text-array.patch > > and everything should land nicely.