From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6EE1C27C4F for ; Fri, 14 Jun 2024 00:45:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E57C6B009F; Thu, 13 Jun 2024 20:45:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 946906B00A1; Thu, 13 Jun 2024 20:45:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C17A6B00A2; Thu, 13 Jun 2024 20:45:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 73F136B009F for ; Thu, 13 Jun 2024 20:45:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D9CF7A03C2 for ; Fri, 14 Jun 2024 00:45:31 +0000 (UTC) X-FDA: 82227650862.15.303E2EF Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf29.hostedemail.com (Postfix) with ESMTP id AE9B412000B for ; Fri, 14 Jun 2024 00:45:29 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JoDBuXUo; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718325929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BSHGNJJW9QoXcHWB3k8CQMWS0eij0PY1paTcRNlGmA0=; b=tpLAfiBdVtGazewCYILibLu1SZvcRl7VQ8OhfNISKFWI8zChF2kXArz9qRoZQqDnAmek/d aWHihRC9OegUwW2qSIKbcFWsJciBLp8h+dECkdys0T3b+Xrb4CGyV5Le1QMuCjQOqVGtQ3 bPNJbEMReNzukB6tH1eZ9PWymWU7mT8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JoDBuXUo; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718325929; a=rsa-sha256; cv=none; b=Rvy3wxPHadLPCej8ftj1dWPH7Y+C5AXm8gnglEAnjN/8b2vIz3upCmxEz+ZfQtIYqvDDn3 wLQPqns40BraD3b2uykn4jPLEggcV3kjnzw7ZvoynjFKC4jhEJlCU/hkReXuns+xBKtiEa VzMGcZCGJIwx2+fzCgRD5djS3fhYEqg= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718325927; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=BSHGNJJW9QoXcHWB3k8CQMWS0eij0PY1paTcRNlGmA0=; b=JoDBuXUou9K3lzbtA7An+nv21ijA5s+M8+SEHdnbnnRQNRVW7yZ8PtCHrGjX9Dd+XPNjzL/6kExnJqHYg22FXN1hiU3vdKIcDMj2fns7O+R3IiK1vHQ3qA1EcQmWX8X8zxUkqFIULAoJB1uipT2N7fQ4rEGCXFu8ZMtEgKz5me0= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R861e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067113;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0W8PHSgM_1718325885; Received: from 30.97.56.56(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8PHSgM_1718325885) by smtp.aliyun-inc.com; Fri, 14 Jun 2024 08:45:25 +0800 Message-ID: <03b1c415-b86b-482c-ae9d-f8d0730fafbe@linux.alibaba.com> Date: Fri, 14 Jun 2024 08:45:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: shmem: fix getting incorrect lruvec when replacing a shmem folio To: Yosry Ahmed Cc: akpm@linux-foundation.org, hughd@google.com, hannes@cmpxchg.org, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <3c11000dd6c1df83015a8321a859e9775ebbc23e.1718266112.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: AE9B412000B X-Stat-Signature: j4poycy1rbc1jcibboahn4bfbw11r64x X-HE-Tag: 1718325929-448685 X-HE-Meta: U2FsdGVkX1/UD2HCvKd2gkLf1VxKtAN6DqXSSV28Z6NzxZ8G81/RwEAfk5ssK4Wd0D1NGkQLuZZwVWjvs0Ciz1bIHWUuFTDIOu6+klVETS/4N3bQBBMho2pHLtblmQ1ElZ/BaxS6Fc+yAO96m0Mm9WIYD7f54Ke2l/gAoX0ncf/PKwUhi8KxmNVIwYMucSWeATx9hPJeN94HlnQPe0jBOtTBH2fjYwyY/64O+XtlihS5dpVpssZrlUn7NhSnOgf2gt59Qvno53jnVHeK2DTTHxqVP3Eo0PRjET+AeQ5TAdXVjspeQDZ+YhrJfHl/patkJZ7SMctNQDWcCUtU1spJs7Dg0j9VBR06npr75LWifQv7VMxmddtz3m73e4qk8rwYdPSsQBs3XUaw/zGGh4CS4w/sn3qSWf62ZdhO2aDOt/gt5Uh3Regxpv3eLE3d95yG9/eoDmxOLdJHbdsWSce2S703+qdv+SfN2OcpGcIa8jgXnLn4pLJs/WzL785UGrQOuhli0ez1JLNNHgLNBNIDdHJXehSK0ERmoytRG3ozdl/w/o5Bm4egWUxnugOD7SoAx4R4V/4pskfB+O3lcINnbI8irHPQQJGbIuP8IwF0thmtvrr32U11PyPRiNJCjbOwmo0VsOmp2idTgljKahiUcgTSGVxoZw4deHg2r+PCZ75viQpn6PQSfVRqyJvzYWvEj4P5y3/Gn3w3alh3VBDL/CTPkhPiYqhKQIyDQwA8l3TdJxD7hQcBPKG1JrwwL4U40JSJyu4+x82NW7oa+otJq33ex9YzSU+B5HAyuFTukW8ck8WX42ock6tGjzh7uvcyjF780Lv6I64WBlUZ9Ekse2MW/O2qDueLGlkplbf0SVLkStcUfKFslV18/G2wN74RKNRhBrUqlyEYS8Ak0kQUh9oY6LYl1hv8RkIN1K6m6Nw/KUkman3RBC1krGwl/yiUZVtaqjoxRjVnpZMplJo akdqjldb AUCgVs36Q5m9FDGrQo3DbGfmtSbcxrPAF0VKjicX8cqO9YnXPxcwP8D7Gk1jCWjwhMEvXuaks4GODKk5efunaGvqbLjlK9OxzU7WHpXjjQ4z7Mqt6JHdXeufC8J1eCEo8M+0Fd+lPDlds1IgH1bMlx6xwdKo0fs3QzNy3Xcc0UdXj6o17LHYOWwzXLch523obJ3Kn/lmHHYbvlIE/jrJAn4Ft5cl0jeprX8J2cToCvKtBmIza9BTaXYl7qV1VdEWiKTQlxBw0aGSbGaB7kSOFI0lVYYBgUdDEMkfOz+xRADiAjNnWsVjodfITWkQz70IFeIoxuHiYACgtk0LwtPm14RKlKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/14 06:24, Yosry Ahmed wrote: > On Thu, Jun 13, 2024 at 1:21 AM Baolin Wang > wrote: >> >> When testing shmem swapin, I encountered the warning below on my machine. >> The reason is that replacing an old shmem folio with a new one causes >> mem_cgroup_migrate() to clear the old folio's memcg data. As a result, >> the old folio cannot get the correct memcg's lruvec needed to remove itself >> from the LRU list when it is being freed. This could lead to possible serious >> problems, such as LRU list crashes due to holding the wrong LRU lock, and >> incorrect LRU statistics. >> >> To fix this issue, we can fallback to use the mem_cgroup_replace_folio() >> to replace the old shmem folio. >> >> [ 5241.100311] page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x5d9960 >> [ 5241.100317] head: order:4 mapcount:0 entire_mapcount:0 nr_pages_mapped:0 pincount:0 >> [ 5241.100319] flags: 0x17fffe0000040068(uptodate|lru|head|swapbacked|node=0|zone=2|lastcpupid=0x3ffff) >> [ 5241.100323] raw: 17fffe0000040068 fffffdffd6687948 fffffdffd69ae008 0000000000000000 >> [ 5241.100325] raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 >> [ 5241.100326] head: 17fffe0000040068 fffffdffd6687948 fffffdffd69ae008 0000000000000000 >> [ 5241.100327] head: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 >> [ 5241.100328] head: 17fffe0000000204 fffffdffd6665801 ffffffffffffffff 0000000000000000 >> [ 5241.100329] head: 0000000a00000010 0000000000000000 00000000ffffffff 0000000000000000 >> [ 5241.100330] page dumped because: VM_WARN_ON_ONCE_FOLIO(!memcg && !mem_cgroup_disabled()) >> [ 5241.100338] ------------[ cut here ]------------ >> [ 5241.100339] WARNING: CPU: 19 PID: 78402 at include/linux/memcontrol.h:775 folio_lruvec_lock_irqsave+0x140/0x150 >> [...] >> [ 5241.100374] pc : folio_lruvec_lock_irqsave+0x140/0x150 >> [ 5241.100375] lr : folio_lruvec_lock_irqsave+0x138/0x150 >> [ 5241.100376] sp : ffff80008b38b930 >> [...] >> [ 5241.100398] Call trace: >> [ 5241.100399] folio_lruvec_lock_irqsave+0x140/0x150 >> [ 5241.100401] __page_cache_release+0x90/0x300 >> [ 5241.100404] __folio_put+0x50/0x108 >> [ 5241.100406] shmem_replace_folio+0x1b4/0x240 >> [ 5241.100409] shmem_swapin_folio+0x314/0x528 >> [ 5241.100411] shmem_get_folio_gfp+0x3b4/0x930 >> [ 5241.100412] shmem_fault+0x74/0x160 >> [ 5241.100414] __do_fault+0x40/0x218 >> [ 5241.100417] do_shared_fault+0x34/0x1b0 >> [ 5241.100419] do_fault+0x40/0x168 >> [ 5241.100420] handle_pte_fault+0x80/0x228 >> [ 5241.100422] __handle_mm_fault+0x1c4/0x440 >> [ 5241.100424] handle_mm_fault+0x60/0x1f0 >> [ 5241.100426] do_page_fault+0x120/0x488 >> [ 5241.100429] do_translation_fault+0x4c/0x68 >> [ 5241.100431] do_mem_abort+0x48/0xa0 >> [ 5241.100434] el0_da+0x38/0xc0 >> [ 5241.100436] el0t_64_sync_handler+0x68/0xc0 >> [ 5241.100437] el0t_64_sync+0x14c/0x150 >> [ 5241.100439] ---[ end trace 0000000000000000 ]--- >> >> Fixes: 85ce2c517ade ("memcontrol: only transfer the memcg data for migration") >> Signed-off-by: Baolin Wang >> --- >> mm/shmem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/shmem.c b/mm/shmem.c >> index 99bd3c34f0fb..4acaf02bfe44 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -1908,7 +1908,7 @@ static int shmem_replace_folio(struct folio **foliop, gfp_t gfp, >> xa_lock_irq(&swap_mapping->i_pages); >> error = shmem_replace_entry(swap_mapping, swap_index, old, new); >> if (!error) { >> - mem_cgroup_migrate(old, new); >> + mem_cgroup_replace_folio(old, new); > > The comment above the definition of mem_cgroup_replace_folio() needs > to be updated with this change. It mentions that it is only used in > replace_page_cache_folio(), which is no longer true. Indeed, will update the related comments in v2. Thanks.