From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96455C021A4 for ; Fri, 14 Feb 2025 07:26:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 361156B008C; Fri, 14 Feb 2025 02:26:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30F77280001; Fri, 14 Feb 2025 02:26:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FE456B0093; Fri, 14 Feb 2025 02:26:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0032E6B008C for ; Fri, 14 Feb 2025 02:26:20 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B0B2B161FA3 for ; Fri, 14 Feb 2025 07:26:20 +0000 (UTC) X-FDA: 83117716920.24.CC9E0A0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 05DF510000C for ; Fri, 14 Feb 2025 07:26:18 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739517979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zSCjFfR20TU7hwUMrS4urDZFjwQFxtUiglQqA7+Ae/0=; b=uxfmQSbK9F8ClVgmnYD2GoTyBHHkXZVPz7HlsYwsltYAhIal1dXb5c9LabRNJ1VfjVUDFc xE6s22OLXrlly7ShImQzIU7egHiaFN/2sKbvOYSjZn8/3v8ViHJKaDzkfaD4DJ/jrKvhyw ZAiOkTonYadFBHwuh6rjM32w9fFmX1c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739517979; a=rsa-sha256; cv=none; b=ycVunD03klCp+Ng7g8OctwbCm1yJ5xxRBTi6PgCt0fvxhzI00VHEHEvJ99FJlnGAyiyyA6 nUD2gqa+6TsYW5OsjgcrQLTDUHoJIZRRjyeRhGBWyqcxMAWWqUXpRLkmRGRTEQgeQPtE1u 3BB7WeNi1Tcl886sTyUokNK9Kd6EVnQ= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2A3D113E; Thu, 13 Feb 2025 23:26:38 -0800 (PST) Received: from [10.163.37.128] (unknown [10.163.37.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 57E413F58B; Thu, 13 Feb 2025 23:26:08 -0800 (PST) Message-ID: <03b042ec-1cb7-4419-8741-c65e74e49d51@arm.com> Date: Fri, 14 Feb 2025 12:56:01 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE To: Christophe Leroy , Steven Price , linux-mm@kvack.org Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-5-anshuman.khandual@arm.com> <8e75c5ff-a97b-4a6f-9c8b-ac2598eafe60@arm.com> <6e1201a1-60c1-40a3-951f-d603b6341a11@csgroup.eu> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <6e1201a1-60c1-40a3-951f-d603b6341a11@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: is6k6z6kmwoagsdxwb4yt36me86dd7xm X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 05DF510000C X-HE-Tag: 1739517978-228317 X-HE-Meta: U2FsdGVkX18kQCRJ1FP74V1lQKsOi08O09zAuGNQv6/mdGNKRjodSFX54ns/vm0dRENmuyX+R0JgHB+hAb3oYgDWseKHh/fAzk1dC3r6HfG1s3L2G5EyoTNiZYIP6YUBe1HHx64FYUeKK/cK9YYXsZ/fV3WuHEJma0D8YLUyNj9qb1TanFkJ4CGI5faDPhMAkBGnjci3GKe0DJm/R/oml2zBI8+Winh+eCe/dNdDm3Yy50Ob0ScEyReFfW+jm2/hX3Nxo+j+/7buiavEJnC6lP2KsG5Pju8G4RulSTmeX0wMFjmFVzB6gQlYH1x9FBNPoXZN5B528AU2GvmdJziXjrWIRipcpmeAMbt11QLq9bZakevZRzb+Mg7+NDkbfyOfhE2p2TlVSKmN3WAqhU3QCFX+aL+6kGG0XHXYST6lXtNuBxI9f+YgzD5KwUTopJkPnF8x4OZ6VBChPlRQNR67dzASnmafEnYqJpPZ4M96mJZU3OCIa6qGDSwK/o/cBnoFvmiueRvqpik/EfeR4onf6Wriq5we8R0daNt67dUPjqJIcysIyvwFcMgeC4P6gqp72VM7eEyUsFDiWX3shYJCzZQrTtbxVYGj8OvQcnPYh3HAK+KOa1hiWkQ95UGUGde+awN7NV+Gev5p6ofJ1txWTQrdARYvDhyF5hkrXhxaWRbB9Q8g5N4myPJrEE7vS2GgGoC7HezN4/zLjzNc3hdyUOP9XLDdrq+v/v+youQrguOkc6fjZgGX16yzNJdZ9Apft13jynvqbJu24AR5oz4j5Luu09pG/N4P/WwcwVrIPJ2ioiCbrKjk96e0fj6m8zxt/2FEo+2qKwdW0XwN8NsTE7AZt+9FOCk6I4AmcWfl3GOijXnmPxFkc5wWRPxPAIKA07nBzlJaa75bx98LJba0CGmJpq0+cvyVw3mr7jxo2DfwbkcXt7aXXF12irTVgkY6cMUYewWeU6qjuasSl5u StduF9Qj qleYBcy6hIUb8UvWnzlMU8pIoDKhga/Mfb0KkFXhiMlBnUPM8SjvKuOl29PolzULxVp6hanAxOLWG+24esdGamFcwwyMlRYtyLW7tkTO2scTpbeFSxgfDCTSF65RAC5t5LlYpOq3YZSOdDJIDQWxB3js1ozj7WeUQIAnuAHmLiPDipyyG4Zmdkj23eibH1DRejGzOyDmrRAY9ePGldLXaVjWWZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 17:19, Christophe Leroy wrote: > > > Le 13/02/2025 à 12:23, Steven Price a écrit : >> On 13/02/2025 04:09, Anshuman Khandual wrote: >>> Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. >>> But generic ptdump gets enabled via PTDUMP_CORE. These configs combination >>> is confusing as they sound very similar and does not differentiate between >>> platform's feature subscription and feature enablement for ptdump. Rename >>> the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve >>> readability. >> >> [...] >>> diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig >>> index 77306be62e9e..db005618690b 100644 >>> --- a/arch/powerpc/configs/mpc885_ads_defconfig >>> +++ b/arch/powerpc/configs/mpc885_ads_defconfig >>> @@ -78,4 +78,4 @@ CONFIG_DEBUG_VM_PGTABLE=y >>>   CONFIG_DETECT_HUNG_TASK=y >>>   CONFIG_BDI_SWITCH=y >>>   CONFIG_PPC_EARLY_DEBUG=y >>> -CONFIG_GENERIC_PTDUMP=y >>> +CONFIG_PTDUMP=y >> >> I'd suggest dropp this from the defconfig too, just like patch 1 dropped >> it from debug.config. >> > > Thanks for spotting that. > > That one is wrong. Was introduced by commit d210ee3fdfe8 ("powerpc/configs: Update config files for removed/renamed symbols") which aimed at fixing commit e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") but it did it wrong. > > It is CONFIG_PTDUMP_DEBUGFS that is wanted. Should this replacement be done in the series or would you like it to be handled in powerpc later ?