From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D26C4332F for ; Mon, 14 Nov 2022 03:59:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4B566B0072; Sun, 13 Nov 2022 22:59:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFAC76B0073; Sun, 13 Nov 2022 22:59:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE9658E0001; Sun, 13 Nov 2022 22:59:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 98E0D6B0072 for ; Sun, 13 Nov 2022 22:59:58 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 63479120438 for ; Mon, 14 Nov 2022 03:59:58 +0000 (UTC) X-FDA: 80130694476.08.4A5E24C Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf03.hostedemail.com (Postfix) with ESMTP id 18ABB20008 for ; Mon, 14 Nov 2022 03:59:56 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id k22so9911559pfd.3 for ; Sun, 13 Nov 2022 19:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SQZZjpNqvZsbs1aZ+f9L6Zj8PA0ItCU0rBc0b1FARyw=; b=vdB5fAHXaRnl7hEGIoiRCjv4822lI+8QizRapf66BmUN2RvoLmk1izUL25FAw8x4c0 Fg1r5WnIaf5BUQwu7KlU9RU+15lhg9x+V0K9tRRu6XunTvyOe2M+d9p0Z8UCfB+IjmFo 6HgrdONadSO1rj4QGrvMn46maeMM1yZeED2aU8PhbJvHIo1pyk7Ggu4QDktXJlqbQ3zH GR3dlDfqu/90Dwu8sr159TzENYpVbOaHtEYQmJ7PVkmtlxE2QQbo6Mq1E2yM+i4kxQ4p 2HyTY4R02QmKE+UbuWvcM2grft8OfjzohGFcD0oJs2HAifkoivRgDqMQbopDaKIVW7kS kYyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SQZZjpNqvZsbs1aZ+f9L6Zj8PA0ItCU0rBc0b1FARyw=; b=4XkJtGcK/ok0qbPi/czPfYugAt/W1EQTiGsZkGIP9ZjPpUuHp4ZqQp+bN5+LdBqgDv 7tBv8noIMDNlaXH1E3I4SgJJrcngsHkcSD656pWxUw3b0/pXMYDCUGSF6kpREFTrajIT rJnGg+ReALJbTq2t5Dt8Ok83mpFT3K5hm1hR7q41aVWjSzkxcg+6Knu2w7Nac4m3PmLv rOZcOIsxpRK3iLSqjFvC366QYk/OBFDMdgxCwCPQps11P+G16SmSBVIWXKZRYacFoKdw J3P/EBsJOBUMzbtDlbWP4lW6cUoY+XrK8O8kvGQOfNCafT4eFvw2uSsbW6TGN3LQj0K3 qeSg== X-Gm-Message-State: ANoB5pm8Q1yjgqm7VzCGpbCkQ563C04Wzujw96ypZtLv6Fp/vnxWKu+9 SxIigUyysQjx35/LHQEQNzst4w== X-Google-Smtp-Source: AA0mqf72JWncrSTFwDOEPs30Ny/aQyU6SBZ2m0gCMhNu13fXnwcY9AQ7OCeL8R/ZUFswDSD0+buZ2w== X-Received: by 2002:a63:1d49:0:b0:476:898c:ded5 with SMTP id d9-20020a631d49000000b00476898cded5mr2276339pgm.299.1668398395776; Sun, 13 Nov 2022 19:59:55 -0800 (PST) Received: from [10.254.69.19] ([139.177.225.231]) by smtp.gmail.com with ESMTPSA id g3-20020a170902868300b00168dadc7354sm6061996plo.78.2022.11.13.19.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Nov 2022 19:59:55 -0800 (PST) Message-ID: <039ce475-f935-e0c2-4734-1dd57519d961@bytedance.com> Date: Mon, 14 Nov 2022 11:59:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2] mm: fix unexpected changes to {failslab|fail_page_alloc}.attr To: Akinobu Mita , Andrew Morton Cc: dvyukov@google.com, jgg@nvidia.com, willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org References: <20221108035232.87180-1-zhengqi.arch@bytedance.com> Content-Language: en-US From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668398398; a=rsa-sha256; cv=none; b=J0jjl5dcx1SJ0dOD7zODP+bzo/EsgyZM53ASGwYoBSNfjr93LBPUSh7455ErJpHceRYhV3 CzsbLEZ4v+vorid3o3Ws1US2p8oKd9UY7XUcRq/BaDhqe4/N71duL0Hr66M1bK893aqHaP biKKpMcyV4PmvVRrORyk+A2G6e3Uqgw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=vdB5fAHX; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668398398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SQZZjpNqvZsbs1aZ+f9L6Zj8PA0ItCU0rBc0b1FARyw=; b=rB9dM5e4cDPIkTw1Z0ZMZDDn2/MOjox7oJwewAKRXX/sVovXKQYBT/zGRXiA0ZR86y9RYj lHy4J/P5yl+9ZpZwgS0/x2fq9JG2Uc3dJrar709F4TpVfBwDfPJzbMWnB/eOHXFUNE6TnP Kl4TgdGAg0WFfWbzxvEbOBhU84f6J0I= X-Rspamd-Queue-Id: 18ABB20008 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=vdB5fAHX; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: 99caok5t5mqu1fphckptqx9nn9a3qju7 X-HE-Tag: 1668398396-664758 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/11/9 01:36, Akinobu Mita wrote: > 2022年11月8日(火) 12:52 Qi Zheng : >> >> When we specify __GFP_NOWARN, we only expect that no warnings >> will be issued for current caller. But in the __should_failslab() >> and __should_fail_alloc_page(), the local GFP flags alter the >> global {failslab|fail_page_alloc}.attr, which is persistent and >> shared by all tasks. This is not what we expected, let's fix it. >> >> Cc: stable@vger.kernel.org >> Fixes: 3f913fc5f974 ("mm: fix missing handler for __GFP_NOWARN") >> Reported-by: Dmitry Vyukov >> Signed-off-by: Qi Zheng >> --- >> v1: https://lore.kernel.org/lkml/20221107033109.59709-1-zhengqi.arch@bytedance.com/ >> >> Changelog in v1 -> v2: >> - add comment for __should_failslab() and __should_fail_alloc_page() >> (suggested by Jason) > > Looks good. > > Reviewed-by: Akinobu Mita Thanks. And hi Andrew, seems no action left for me, can this patch be applied to mm-unstable tree for testing? :) -- Thanks, Qi