From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AFC9C433E0 for ; Tue, 23 Mar 2021 15:45:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4DF39619BD for ; Tue, 23 Mar 2021 15:45:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DF39619BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C3B636B024A; Tue, 23 Mar 2021 11:45:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C11FF6B024C; Tue, 23 Mar 2021 11:45:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A65276B024D; Tue, 23 Mar 2021 11:45:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 892E76B024A for ; Tue, 23 Mar 2021 11:45:28 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2C860365A for ; Tue, 23 Mar 2021 15:45:28 +0000 (UTC) X-FDA: 77951563536.38.38BED65 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) by imf11.hostedemail.com (Postfix) with ESMTP id E1F3D2000257 for ; Tue, 23 Mar 2021 15:45:25 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBhHjwCeAAaElmPGdQvvjMnmhEQNEyYcM3F0rYlVld5Qe1foS6ApTDLkGCRIBfZAuIDg0SUSYWGgFKaKqhxkrSzeR/I0JmxLXivV9YNYnfNLgiyNPqY2EjGJG+sVRvqsTcJZb0o/TIe5HugMwOU73wsX29GfIMkJR5b0mIZiHSkAxhhnWsFuecQu9jzgijS3XTPynvhNDis9TAhNBqnBQfW48J6mou3izAcvB4Cp3sNG3Av1Tdtn2fxoEm6q67KZkWwr7n8v+OpnuoSxJUEs03RNbG/SL0mSP6NZI5Jk65q0VKcfx3t1SQuiNC3UIH7XI7k14AA42nVZxp8ctDrJ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v4U61BS2trJgpplcdkKuoMyfx+TIaCkjHWXxdAG1wck=; b=gJfDp7ABLn0eeHMREP1B3ZrlJLhZg7gjslum9yOMTPjLFNKWihenqMzD+96QVZF3u8ncOGfM3HGtH8Bvkqp8hhOSPBXpWFHfEXfErIJkQJD9MWjQqZDO7donraxjObihDbXqG2O9H52YvNL76feM88/w8+6av4Rqi00QSShOdrgBd/Fwod99ZZsGH8MkOyo0JZ/Vxibyx+k88VXx/N16Goax8HrX4J/XCd9yWIRvCXW9ChqJyYb2cOiQuJ56HPFKLc0HaaaEAem5xCiQqTHrzDUWnYJ3S/bOMIiKkBC+XdaD4o4t9InQxR6cYHFZsK6ubdxTufNDIB4t8Uq7KvGXhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v4U61BS2trJgpplcdkKuoMyfx+TIaCkjHWXxdAG1wck=; b=tQCuB14kQ/NY0ccPyQL6aXkTJTIJ+rljqcovq6Cr+xoWNLf1e9UoznQR3/dWyPwLNc6MhFo78yEqUmDWFBf1KVESiNGAe3J1SAQszDKrss5QligRsrtazmYxl0Teu1q42HAvi0M/G5lRsM8kj3pcLu/I6K9fWyN4tmfe1X5tY5U= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) by MN2PR12MB4142.namprd12.prod.outlook.com (2603:10b6:208:1dd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 15:45:24 +0000 Received: from MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::c1ff:dcf1:9536:a1f2]) by MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::c1ff:dcf1:9536:a1f2%2]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 15:45:24 +0000 Subject: Re: [PATCH] drm/ttm: stop warning on TT shrinker failure To: Michal Hocko Cc: Matthew Wilcox , dri-devel , Linux MM , amd-gfx list , Dave Chinner , Leo Liu References: <75ff80c5-a054-d13d-85c1-0040addb45d2@gmail.com> <20808d08-b66c-13c3-f672-ebce216b2fa2@gmail.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <03889c00-bb5d-ef20-12c6-7e77df073dd9@amd.com> Date: Tue, 23 Mar 2021 16:45:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Originating-IP: [2a02:908:1252:fb60:59b1:f458:60ca:becd] X-ClientProxiedBy: AM0PR01CA0167.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::36) To MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a02:908:1252:fb60:59b1:f458:60ca:becd] (2a02:908:1252:fb60:59b1:f458:60ca:becd) by AM0PR01CA0167.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 23 Mar 2021 15:45:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 04f94538-3b4d-47e1-260b-08d8ee12ac67 X-MS-TrafficTypeDiagnostic: MN2PR12MB4142: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tH/GPmNHSofsVtYTSIoUmKYnzWeV6iV9rgrzdUzUwqGYJlPxSlKbrrZW/F5DrKIpTdE1ppFdmrc16VrBMY1X1tr+T4uI4ai28RQvkjdq6kNM4yogKnUrKloRyLMiZaD90a4u1FtBx9MsuWF0Os4P2S1ChJeV+SqPH9fZ/jSYXCDXO6OwFTp/sbvk9DjZ3r6YQZjHMEBsXIjtXdhyi/uoxNM60K+Bly0uVKpAHUUR9zSxk0rprNHFJ9ilHUCMmxxJieOuDXIN1INFHbrYC3mDqUq3PmE+jU1pwymEyRAND1BIG6gSznv6k6AA1tu4urUNG3inOkG7LFSZqYC0nPNWSfgM81xjmmVcVxQWrpIunvr9QNKDtmfA+pXNnuqPi322Vj1GptN+d0SeEFay7MGReeJ+MIHUC21SUKrdaPMEH+s/QKhTO/f4lHvfyUvVUHBsY74SKCLEZxEeuvdcKMZ8I8/zOl0+KwMG7b7BGY70al+xUnXdoZiUuCD0uuyOyHKshb67PCdytfZF42Ug5YDR7PqxCu0qtjKHo9JXlRFZM0uTGH2GKuyTqQdAn8n/TmtiVTnrqZx/qdAqbTIDPaoPpiHGHuW7F/T82OrTCA7DKR3qukXCi1qQEqJlkVcBdl07FOEhs13vdjcmHg6qBrr7ulmlOrQZU2eo+fU3JBmYOoNZjim7ggsWHal5jiSE7r7l X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(136003)(39850400004)(396003)(4326008)(66946007)(36756003)(16526019)(66574015)(186003)(83380400001)(66476007)(54906003)(316002)(6486002)(66556008)(52116002)(38100700001)(31686004)(5660300002)(478600001)(31696002)(8936002)(6666004)(6916009)(2616005)(8676002)(86362001)(2906002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dWNLWVcwSFEvaEpNS0wyc3dsN0M3RW95ZGpncWlOTnhjVlhQS0VnU0thTktE?= =?utf-8?B?MXE2V3VQMk5oNVVJd0lUWHRZbmRQc3RuSGltQ0hpMTBQblVjeFdvMjRxMWN6?= =?utf-8?B?R05zd1JUKzJDT3gwNkYrdlNKSnlQcXVZSnZJbnl0Z0REdXRtSVdwbnFUM1dQ?= =?utf-8?B?WSt6dDNSV3FFa1J6ZjJoSFlCWDlCeDJLUWQ3WnRRVlgyY2RTNTIrTlNsck5O?= =?utf-8?B?K2FjRkxuZ0JjamRGRnpJeEkwM2UwbmZOWFFZM1NueHlhd1Bsd21xbHZrVlQz?= =?utf-8?B?ZFJ5SjIyNEZyMzRNNDNNSFhYNUxxK1R5Ry92KzVkTjliYngwa2ZiQndKVTNH?= =?utf-8?B?ZmtEYkNsSTIvdEgzUEhRVnIzV2FrRWhPYWNqdU9lei9sT2p2V0xCWnZUYzhV?= =?utf-8?B?cC9mSHA2dnFxK0RkQWpFMkhuT2dHa3EwdDdSUlY4dmNXTzdremEvbEJQVmZ6?= =?utf-8?B?ZGVRd2JmQ0FicU1PYm5xRTdZVjVlNW02QTh3eExSSERjZ0U1TVkzc3AwYzBt?= =?utf-8?B?RlNlRXVoeWQ4b2pHaVh5RzZOcmVveU1LL0lyaTgwSEYwOFRRUVBNRnN1NVpH?= =?utf-8?B?S0dUMDZRSWo4MkxMZWpjamt0NnBsL2NZa3lkTUYwSEJ6UGhXa1VnLzVPZUsr?= =?utf-8?B?NmV2VTdNdTZoczE1N2pXSVh3cE9SMCtrdVQya3N4RFJpS3R5dkZtb2FXZy8r?= =?utf-8?B?UlNxRXpLeDdnRE1MdGZrSzBsVlMrSjE4UEVNRW5DN3IyMjcvNGFJeE1qWDli?= =?utf-8?B?OFR5eFJhVStud3RMUUtwcGZhM0NBVmdDR29NR1NXb0ppclV2bUpvN3VyMFM0?= =?utf-8?B?MHZHZ3pFbVNxV01mSlZkQ0NJcmlxdm1NWHpyUm1JelVFbjdRY0FBMEpNNzR3?= =?utf-8?B?NkExbU8xQUVERXpoTDh2NU9TWG9nOGtGQlhxZ1pwZEJRMjMyS1U3Zm1GSDNH?= =?utf-8?B?Z2Rya3RybCtKYmREUElFSGs3bDdJamFMVW1QSTRUQ25paVhyaWllQTJxaDdM?= =?utf-8?B?NTIzWGpzK0Uxcm94TWJuQ3Q1RlhaTWU1eUo4em5UM2tMTWFjQWNpWnVmWnlh?= =?utf-8?B?MjZGSDd1TktCYVVyTFVEdzNLeElTeFlKUFdlbGdjd1NacG9VMjl6NEVFUkYz?= =?utf-8?B?OXFXRTJFSXZSZ0JYQnhwTmlTK3pQYjZkN3ErckZwUTA1VnFJbGI5cjdLUUNu?= =?utf-8?B?Z0xlRmxiSU9MeDRzRG5FL3ROY0VtRzBUSU9LSWNBZU12eHZIcFZvMUg3ZjRN?= =?utf-8?B?Wnd5dk5wYXdkUFRPdmtDQ3ZnUVQzNGRJYTk3N1hHWlZTRXErWXBoUkcrcGk1?= =?utf-8?B?RS9BRUhBdUhjTGx6c21LU1ZmUHZZalBzS0xzSENRYXJrbTRjaWp4TXRIZlBm?= =?utf-8?B?bWFmNmdTUGJIYVBvRVVvbzhESk8wRWdaRlRhTXpqSFY0eE5vbGxEZEpqRUJv?= =?utf-8?B?cDFmSXl5enIyOTNpZ3VKc2lRbUN0QUQ0aEl6VGgvTmhVbFMxN3ludFJGdFk4?= =?utf-8?B?VzYvcm1MZnlxWkZBU2xWL3RuZVh0R21zME9mQ1A4YjdkNVR1TC9RdmRtY0V2?= =?utf-8?B?WnRqc1VLU1hvRXd3NUlKdzVVcS9Td3V1dWhEOG9Yc0hkVCtLNmQvaWxqb2Rr?= =?utf-8?B?My9WNURQRGQ0bVRwOEZ4NlJGVHhHTzlybkhVNjZqNW1zbVFITHU5Q1ZsU0tG?= =?utf-8?B?R0I5d2xIY0JHYWVNZ2ZQK25jaWpha1JhTVQwQjRBWFpvL1c0RzdJc1M3TGJz?= =?utf-8?B?cnZ5NGlBVERjNUUrSnFsNG1TSkdTUm9aVFJ2a3J3c3BLdEE1MXhHTGZaZ1ZP?= =?utf-8?B?N2lud3ZIZHZ5dVJvOEEwK2RDUWFSc0RuT29nRDdKMDUwQ011dWN0UU40TjYz?= =?utf-8?Q?/XV6VdEFuj3uP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04f94538-3b4d-47e1-260b-08d8ee12ac67 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 15:45:24.4506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gSl6z/teCSMI9aASO/y0JIDqIN5Mnq7MYKazAS7h6rpdsN+EM2HS7qlU9eAmIWgP X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4142 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E1F3D2000257 X-Stat-Signature: y7j9raft4tk7uwrcp3w78stu98dqsxic Received-SPF: none (amd.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=NAM12-BN8-obe.outbound.protection.outlook.com; client-ip=40.107.237.54 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616514325-100354 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 23.03.21 um 16:13 schrieb Michal Hocko: > On Tue 23-03-21 14:56:54, Christian K=C3=B6nig wrote: >> Am 23.03.21 um 14:41 schrieb Michal Hocko: > [...] >>> Anyway, I am wondering whether the overall approach is sound. Why don= 't >>> you simply use shmem as your backing storage from the beginning and p= in >>> those pages if they are used by the device? >> Yeah, that is exactly what the Intel guys are doing for their integrat= ed >> GPUs :) >> >> Problem is for TTM I need to be able to handle dGPUs and those have al= l >> kinds of funny allocation restrictions. In other words I need to guara= ntee >> that the allocated memory is coherent accessible to the GPU without us= ing >> SWIOTLB. >> >> The simple case is that the device can only do DMA32, but you also got >> device which can only do 40bits or 48bits. >> >> On top of that you also got AGP, CMA and stuff like CPU cache behavior >> changes (write back vs. write through, vs. uncached). > OK, so the underlying problem seems to be that gfp mask (thus > mapping_gfp_mask) cannot really reflect your requirements, right? Woul= d > it help if shmem would allow to provide an allocation callback to > override alloc_page_vma which is used currently? I am pretty sure there > will be more to handle but going through shmem for the whole life time > is just so much easier to reason about than some tricks to abuse shmem > just for the swapout path. Well it's a start, but the pages can have special CPU cache settings. So=20 direct IO from/to them usually doesn't work as expected. Additional to that for AGP and CMA I need to make sure that I give those=20 pages back to the relevant subsystems instead of just dropping the page=20 reference. So I would need to block for the swapio to be completed. Anyway I probably need to revert those patches for now since this isn't=20 working as we hoped it would. Thanks for the explanation how stuff works here. Christian.