From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22AE2C433F5 for ; Tue, 26 Apr 2022 16:06:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABAB66B0073; Tue, 26 Apr 2022 12:06:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A43F76B0074; Tue, 26 Apr 2022 12:06:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86FBE6B0075; Tue, 26 Apr 2022 12:06:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 754E36B0073 for ; Tue, 26 Apr 2022 12:06:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 444DF2085C for ; Tue, 26 Apr 2022 16:06:39 +0000 (UTC) X-FDA: 79399508118.22.314E354 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf06.hostedemail.com (Postfix) with ESMTP id 66841180050 for ; Tue, 26 Apr 2022 16:06:37 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id r12so20590633iod.6 for ; Tue, 26 Apr 2022 09:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=48HTw/rBGTX9w0BVqolReo8yB9AAi0BaZFQxJTNNLy4=; b=ZD1m7Y4nVS7PfQ4Kjhtcx2pWQRTgJwYNx2+YXbk1O2CUO2UxP5EWmPra4LFir6/Taw RpW0It155qOW40r+x6bxxHSyaWqdAxyZPQbArFGFnVhID+wD8iVD1c4L/8kFEbTKgLUz EJZN4+mqFAvk4fkU1MkgFX4lHN0a0xfTh0KQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=48HTw/rBGTX9w0BVqolReo8yB9AAi0BaZFQxJTNNLy4=; b=pJ8oo5vCLjcFteVkyWeqm7zdrcCbZPWm2S7WnF1hTVah8x5xYh1zWrfd9qPnUvy3hQ JSfhkkJCCAlTJhb3Bm0KfNwwz8kNSrTQqFNolXposv92SYQMrCzN8Weo7Z3ntYl6F+b8 wEgB2a4L32jLRACuSXQ33rHvZEVVvajSvcAoEyNrDKi7Piz/+Z+zky9uplVAI3EDrCpv 0hswygHQjnt9x/CvYsHRnOtJUqjaRM6BFeuCU87tu7agprppAQu8BiKFlobJrIumuPoL +ktZ4LG7itjkk7lfQuzNaB0QdimXuyrlXKaLzH6QSGCCCxHTtANMD1JKORbpEldbUo4a egHQ== X-Gm-Message-State: AOAM533b5921FkPnfaA1/tTEC/LnS6ukrv4Kfw+a8587ReQ0QezVVwjJ fR4BTa3rjitkB4VP/oNaIuQF3Q== X-Google-Smtp-Source: ABdhPJxlhTF/uJw3gqLA3Hj0XRaHwykEJis0oX2P2Zrd5M2rhYKz2s635umapHwjfAZEV7w+j3mLVw== X-Received: by 2002:a05:6638:1652:b0:328:5357:7acb with SMTP id a18-20020a056638165200b0032853577acbmr11320817jat.71.1650989197839; Tue, 26 Apr 2022 09:06:37 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id s21-20020a6bd315000000b006573987c4fcsm9786770iob.3.2022.04.26.09.06.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 09:06:37 -0700 (PDT) Subject: Re: [PATCH v2 1/6] selftests: vm: add hugetlb_shared userfaultfd test to run_vmtests.sh To: Axel Rasmussen , Alexander Viro , Andrew Morton , Charan Teja Reddy , Dave Hansen , "Dmitry V . Levin" , Gleb Fotengauer-Malinovskiy , Hugh Dickins , Jan Kara , Jonathan Corbet , Mel Gorman , Mike Kravetz , Mike Rapoport , Nadav Amit , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , zhangyi Cc: linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220422212945.2227722-1-axelrasmussen@google.com> <20220422212945.2227722-2-axelrasmussen@google.com> From: Shuah Khan Message-ID: <037ea7ee-5248-86a5-55a2-f1726567af81@linuxfoundation.org> Date: Tue, 26 Apr 2022 10:06:36 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220422212945.2227722-2-axelrasmussen@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 66841180050 X-Stat-Signature: hd4emsx8zggmtnq7actzxk9m4z597pns X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ZD1m7Y4n; spf=pass (imf06.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.41 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1650989197-737581 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/22/22 3:29 PM, Axel Rasmussen wrote: > This not being included was just a simple oversight. There are certain > features (like minor fault support) which are only enabled on shared > mappings, so without including hugetlb_shared we actually lose a > significant amount of test coverage. > > Signed-off-by: Axel Rasmussen > --- > tools/testing/selftests/vm/run_vmtests.sh | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index a2302b5faaf2..5065dbd89bdb 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -121,9 +121,11 @@ run_test ./gup_test -a > run_test ./gup_test -ct -F 0x1 0 19 0x1000 > > run_test ./userfaultfd anon 20 16 > -# Test requires source and destination huge pages. Size of source > -# (half_ufd_size_MB) is passed as argument to test. > +# Hugetlb tests require source and destination huge pages. Pass in half the > +# size ($half_ufd_size_MB), which is used for *each*. > run_test ./userfaultfd hugetlb "$half_ufd_size_MB" 32 > +run_test ./userfaultfd hugetlb_shared "$half_ufd_size_MB" 32 "$mnt"/uffd-test > +rm -f "$mnt"/uffd-test > run_test ./userfaultfd shmem 20 16 > > #cleanup > Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah