From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F6DC433EF for ; Tue, 31 May 2022 16:59:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84FEA6B0073; Tue, 31 May 2022 12:59:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FEFE6B0074; Tue, 31 May 2022 12:59:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69AD56B0075; Tue, 31 May 2022 12:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5B9556B0073 for ; Tue, 31 May 2022 12:59:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 9952D12125A for ; Tue, 31 May 2022 16:59:34 +0000 (UTC) X-FDA: 79526649468.09.38D083A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 764A24005C for ; Tue, 31 May 2022 16:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654016372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YFVf3FQTHnnpBcCv/Sa9qOVc2P7A/ezzUy7/eKZdeIk=; b=VBTmX2H0CVpTVSr0PyzerHSlo5DC644MJ6l2z9R/3OpLJsbFj+FazE6O3RcQW6Lcoiydzg nnUaCW3nnfddTX8beUf4nF9Xs5Z/Ei+gvT+/HFwZk5pm9yT97tn3zHxF0kwFAl/vO3nZ88 NqMz4QmIlptM00IoFQELUdPa/Bdx8KQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-125-QCPoZ8MiMQm89oRHlg9Aug-1; Tue, 31 May 2022 12:59:31 -0400 X-MC-Unique: QCPoZ8MiMQm89oRHlg9Aug-1 Received: by mail-wm1-f70.google.com with SMTP id bg40-20020a05600c3ca800b00394779649b1so1802204wmb.3 for ; Tue, 31 May 2022 09:59:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=YFVf3FQTHnnpBcCv/Sa9qOVc2P7A/ezzUy7/eKZdeIk=; b=1jE5CpyP3FNtCQSVBbS+M7BLCSzv1CYICjuHXyW9+8RfUhLsgSpKuk+8Lamh87J+YP F0HO9nypjjuVcYsndwCsBkR7Hxg44DSkBYxIn0Glic5IvwiRgNjGzxfEmTHWCkXa2iJ5 nKN/bwCMObI75D/2TEheuCxUVyNYYYYWcuJ1+U2WUi71zM1zf1OCm42ruoRnQK9xs8IV epDgHrf5hcpBW8+eyYvoUXl2j+g365xfFAe1GDaDJj+6k66J93tQERL7MG2qdeClw0K6 wEcNWqWA2C4uXv/Xrfi7ZNX5KWrEJaPP+Zm9hwBCFZwLT8ORXyvFFC5Vq9YRwQ3op9Ba CKYA== X-Gm-Message-State: AOAM530jCr6doILDRP5fS37oBrk72Yr2lgHixWJ+69dV486gQRBO9rYb DHDSZDTh2nHKmEVo88ZcHzlNIcFMlWv0DCxXSlqGdg+c1mG85bUlNrkHBOFcTwVcro32CGgkLrd B5a6Xtf++uTM= X-Received: by 2002:a5d:5452:0:b0:210:139:b1b6 with SMTP id w18-20020a5d5452000000b002100139b1b6mr25823064wrv.5.1654016370155; Tue, 31 May 2022 09:59:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfVBYkvo4gPlgpPYwOdS9fqHHluF9/5WUvV2NIJolZso6oCCNHiXvwxbFwxBIoGh+yozVS9g== X-Received: by 2002:a5d:5452:0:b0:210:139:b1b6 with SMTP id w18-20020a5d5452000000b002100139b1b6mr25823051wrv.5.1654016369858; Tue, 31 May 2022 09:59:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:f100:8096:9368:ba52:a341? (p200300cbc708f10080969368ba52a341.dip0.t-ipconnect.de. [2003:cb:c708:f100:8096:9368:ba52:a341]) by smtp.gmail.com with ESMTPSA id f1-20020a5d5681000000b0021033caa332sm6037532wrv.42.2022.05.31.09.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 09:59:29 -0700 (PDT) Message-ID: <037b1c3d-da1b-11a0-5186-dcc440900a2e@redhat.com> Date: Tue, 31 May 2022 18:59:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/6] mm/page_alloc: Remove zone parameter from free_one_page() To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org References: <20220531150611.1303156-1-willy@infradead.org> <20220531150611.1303156-2-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220531150611.1303156-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VBTmX2H0; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf27.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: cf5rab47z1obecihdtnnm1mjg1fqy6kh X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 764A24005C X-HE-Tag: 1654016369-172913 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.05.22 17:06, Matthew Wilcox (Oracle) wrote: > Both callers pass in page_zone(page), so move that into free_one_page(). > Shrinks page_alloc.o by 196 bytes with allmodconfig. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/page_alloc.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 29d775b60cf9..68bb77900f67 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1529,11 +1529,10 @@ static void free_pcppages_bulk(struct zone *zone, int count, > spin_unlock(&zone->lock); > } > > -static void free_one_page(struct zone *zone, > - struct page *page, unsigned long pfn, > - unsigned int order, > - int migratetype, fpi_t fpi_flags) > +static void free_one_page(struct page *page, unsigned long pfn, > + unsigned int order, int migratetype, fpi_t fpi_flags) > { > + struct zone *zone = page_zone(page); > unsigned long flags; > > spin_lock_irqsave(&zone->lock, flags); > @@ -3448,7 +3447,7 @@ void free_unref_page(struct page *page, unsigned int order) > migratetype = get_pcppage_migratetype(page); > if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { > if (unlikely(is_migrate_isolate(migratetype))) { > - free_one_page(page_zone(page), page, pfn, order, migratetype, FPI_NONE); > + free_one_page(page, pfn, order, migratetype, FPI_NONE); > return; > } > migratetype = MIGRATE_MOVABLE; > @@ -3484,7 +3483,7 @@ void free_unref_page_list(struct list_head *list) > migratetype = get_pcppage_migratetype(page); > if (unlikely(is_migrate_isolate(migratetype))) { > list_del(&page->lru); > - free_one_page(page_zone(page), page, pfn, 0, migratetype, FPI_NONE); > + free_one_page(page, pfn, 0, migratetype, FPI_NONE); > continue; > } > } Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb