From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465C2CF11E1 for ; Thu, 10 Oct 2024 12:40:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D13316B0083; Thu, 10 Oct 2024 08:40:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC2DB6B0085; Thu, 10 Oct 2024 08:40:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B63276B0088; Thu, 10 Oct 2024 08:40:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9BD8E6B0083 for ; Thu, 10 Oct 2024 08:40:55 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 63D1580282 for ; Thu, 10 Oct 2024 12:40:52 +0000 (UTC) X-FDA: 82657652070.16.E60EEDB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id DF0FF160005 for ; Thu, 10 Oct 2024 12:40:51 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WvQOwJu1; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728563916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lMFODkR2vW9a0hERyrHa5UI56idc0n9E0W4rHG9DS2g=; b=xZx6aC2A9FFI4QdlUUnzkNM/IkULtr8QUbBkmL1nP4ffxuUBBgDabdH5M6pS2KIagUmrox HSFkLQHIxVv72XJNxu+0Gpw1vexWMQG3WP5qlBP/QIzGRao3ygQnqRkRA57PWueBC6xSMf Xtod3JiBnc9+BC6lCvtgXGur9A0yCPQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728563916; a=rsa-sha256; cv=none; b=obuYyBfscFbckKd/xyJTPrkkEtRsipy7uzFhmvMqsUgoHCY+AkhbFrkMw+lfnp/rqYZeXr S2K54jkah7IaggkILDK13KFFPDPSu1dcYBy3uuguGJE7GV3+wP3TyWtMkdRDAs8ukJbVob 0UZJLCykVl9b12bR3g5Glqwj9Rcc84A= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WvQOwJu1; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728564052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lMFODkR2vW9a0hERyrHa5UI56idc0n9E0W4rHG9DS2g=; b=WvQOwJu1drxxue2JtZrOsz/C6wzKYzR/pOV86TS0oCuEzV4ZkN24s1QNHfT4IWLsLz9zX7 I2GXHaEJP6aLEu+iRIe8KFns7a2ky/vVkaDM58AzEuUwFBo2W7FDBiAKu4qr+6sa7fan6a bOcac17efUekizYzwImJ2E47ii9F+u4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-_4LRIMQPPeezDCqP5BvLZw-1; Thu, 10 Oct 2024 08:40:51 -0400 X-MC-Unique: _4LRIMQPPeezDCqP5BvLZw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d462b64e3so310065f8f.3 for ; Thu, 10 Oct 2024 05:40:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728564050; x=1729168850; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lMFODkR2vW9a0hERyrHa5UI56idc0n9E0W4rHG9DS2g=; b=pW2ZbWkOURbZ1cdmlVc3EJ7tub5gr++bFQ7yHEGmBput30YLAP/KKZsWFB9CEUZyKF dLuMJHoOrwIKTPmkEAYeilgKZeU3N7aynKCMkgu9auAOR4sqC/TNI1/ubuBYT+1z5rCv Omk+AMIryuj3kFWwbNsQY2jR7rB6NEHwOEOCGBp9+5fHmKX72A1/MfKOUde9aDD16/Cm voDTzKw+c42uPt6ZHdz1XtDqFEcjiUdD+IHMryc0XgUXbHc0pOKDe2lugoQegouqQK1q sLkxPKwzH1KWEfsc143Eg8Z7zon7CuDlV6gpI9iu7ebpx0ZneV3nHWgzbJM4R5osJA1W dP8g== X-Forwarded-Encrypted: i=1; AJvYcCVEjX/JHZFLSxgC9euVyPBKsW/y7O6e5mdaTahyGt0D7P2mFOjSzstKoLZpXZft0dt4EQRDg2VURg==@kvack.org X-Gm-Message-State: AOJu0Yzmd7RuBfvQr053nDyRcVpWVQGlJlVMchOdi9DrSPXpuXxD8ZAU wXkJjYzjHmaximcFveRdkS+i2zJfVN/67l/1I4fcp4Od6gogW4grA/L95N9nidW6xYvSGBuFWLe wKjZ7070ZKFH3qLOSuU+/6uf9/Na4Y24WGaymdrc+mE5qtt1n X-Received: by 2002:adf:f6d1:0:b0:37c:d569:97b with SMTP id ffacd0b85a97d-37d3a9d3c7dmr3829042f8f.19.1728564049959; Thu, 10 Oct 2024 05:40:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhRH0ZpjXpF9EqcbW90ozg8Hyr1TAYd4ehAfCcOhkuuhD0Unrx1FsjGmhIuRLbrpNtk4DKGw== X-Received: by 2002:adf:f6d1:0:b0:37c:d569:97b with SMTP id ffacd0b85a97d-37d3a9d3c7dmr3829026f8f.19.1728564049570; Thu, 10 Oct 2024 05:40:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:9200:eb2e:74f9:6f5c:3040? (p200300cbc7429200eb2e74f96f5c3040.dip0.t-ipconnect.de. [2003:cb:c742:9200:eb2e:74f9:6f5c:3040]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6bd266sm1469333f8f.40.2024.10.10.05.40.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 05:40:49 -0700 (PDT) Message-ID: <037801d9-8923-4d49-8423-072fd7c73069@redhat.com> Date: Thu, 10 Oct 2024 14:40:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -V2] tdx, memory hotplug: Check whole hot-adding memory range for TDX To: Huang Ying , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Kirill A . Shutemov" Cc: x86@kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Kai Huang , "H. Peter Anvin" , Andy Lutomirski , Oscar Salvador References: <20241010074726.1397820-1-ying.huang@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241010074726.1397820-1-ying.huang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DF0FF160005 X-Stat-Signature: kii7a4cbruw4t4c98wupmhy3aoszo7cn X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728564051-274456 X-HE-Meta: U2FsdGVkX18+dm1Pv08m3KoX2zJ1WQUySpvCNbgWC9HO3jpaIWY7KeV8h5L/MnfRzbLihklxFbAndq06SCqKNBqdGHIf8kcTtG5IzcO0hrYjkftv156K8iVsK9JjLtuhUYDDeX8/i4Ci1IOKqUhxE80paNAB/jdMnqqVlVWu4shAM4jrT6LR1IVsiXjoGEquWIBAb58dF+8qSkxLFGj4QsBdzVIZxUjZCYLyPxN0TVGDdGTYUuENBcNqEOyMTr47QDdfWc/fhFy/j2nVIzm4xKRpAhMuTetr2fJ0IgxhqbANUm36aknQRiw6pkVtHvsCcSrKZj/6hf6d45YPmwsKOU8fvzP0bFYo3/7vwvAEfuwjEIl8TAF+OcCkW4t2vZu/ybNQ9wbMumKKcHDTcrLknEH9a9IDz/RpDRDhFHt9l6YnEhTegNmmxdAQPnR0/4U0hsNLei6L+UxGuMllZSiLQcLcPDTKgAKug4NL1TOhP6GTkeyIP9LJTdpBBcm450dp2mcLhI1QkO4PW56LbN703+c2me/Ik9XVbrzjjsI+z2OP8vPdho86HMn/GUmzGwMwXTzgLuX031uGvr11cKiZhqKARWv742qmTDrW6NJRnYpL2J7C5i9Dka6sqSe/q51rOMaucilo46D2cYzzKsOp6sJGk56uGSSHDdx3iH4Fc7okHJg3O9kUY3lM8B1ObCwUd6Y2vda/J6neSD5HoRPhE6iaXEi4/ImEZ29MMz2xuBI7qdoEklKH5htYxcLqTh+ZhSpFhNyT5whwOAshiohpyVQQzAmqKYMGCD0+vgxURO4eeTgV/nLIOM8SxABBfnOUeWlgxvWdSm0nhijECEu2Bg7D0sUn8SrB51uS3kI3W40Hl67HHVrevRLoewHBws/enQc8R5hF2m6jhU0F54l9jHpEqbKePyNnhz+9YRG55d5wM35QXOR6h0RrwFfaDyUYvotZs1baTPHGAoSVfHN jc4S75p/ igLBGRWZWsj3xN0WwgylLe1XytONOn/OlJkynJXmTg1lPdeLPacET9RFMiut6hhidAmwR6EAyxkVLJagYErO9X1ZHSCEeYHPv9zGbQ+00IOFWrXIoOBnnFj4Rit7QcFNbYN8D/jER97Uy3Ova7/Q26Qq/KcDkVobQ05DQyb18r2AmWAIy5uNS9onwPs9gyAwFdmIGAMKMoFawEmnhQKdFvoeSl+mB6owqNXOR9e3pRoDaIuyF/peH4+fwVltlYYDTFx5bd0SCnFl7xdrNSUZAtS3sdvoj41Fx2Q98+u+qrbQZQ4Yiap5/FCZwFVqyKBPTt7R0IlzjSWkjo+bjwOk9XPoP198O1uM2U7d38xilgTl6dEP7+74iwsrChrMO6yVn4B128n7paLwr/zg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > extern u64 max_mem_size; > > extern int mhp_online_type_from_str(const char *str); > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 621ae1015106..c4769f24b1e2 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1305,6 +1305,11 @@ int try_online_node(int nid) > return ret; > } > > +int __weak arch_check_hotplug_memory_range(u64 start, u64 size) > +{ > + return 0; > +} BTW, I remember that "__weak" doesn't always behave the way it would seem, which is the reason we're usually using #define arch_check_hotplug_memory_range arch_check_hotplug_memory_range #ifndef arch_check_hotplug_memory_range ... #endif Not that I remember the details, just that it can result in rather surprising outcomes (e.g., the wrong function getting called). -- Cheers, David / dhildenb