From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A87EC54E71 for ; Wed, 21 May 2025 15:28:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A536D6B0085; Wed, 21 May 2025 11:28:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2AD86B0089; Wed, 21 May 2025 11:28:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 941646B008A; Wed, 21 May 2025 11:28:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7325C6B0085 for ; Wed, 21 May 2025 11:28:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 10B7B1A096D for ; Wed, 21 May 2025 15:28:28 +0000 (UTC) X-FDA: 83467296696.18.79F3936 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf23.hostedemail.com (Postfix) with ESMTP id A224A14000A for ; Wed, 21 May 2025 15:28:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZmB6iy26; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZmB6iy26; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747841305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4BxyJ3v262BMPMjjt2e6XIRbsmDdWt6DtbrcOXFN06I=; b=DedKu4/sVNtW6fbcGnmsJ9xZDdK2IR25Ao5ddx9a7e3Bs44rOMiTMEiYd/QiWQ0ZDTbJYi f6vU0HnIlpaV582LJ0WfEo5uLo4bo+bHUnDE9JUELfa86pMzrlbnZ6h/QwTXhKTFUTelSz GoQtljYtt+rJv6r5sNmGSBVpDFjXXK8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747841305; a=rsa-sha256; cv=none; b=2SarmK5eLyr4enOz7nbUUc8lkxDomCmNVKBAhVBn8ZRY++34nsP9lvGOKF6zMFHlhJt5O1 2kSPAqNSedZnq9PNsXVTyJq0cNLZuX0WP/PGx1A6FrrqwL23n5RU9uKiFeHoYYhmLGk4yV xBDIKWLe0Z7Tmf5PESLYCVo1O7VsmMo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747841306; x=1779377306; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+z86RSDec0qYkezODUVlCk6BWpT4zU4CzST6s1ksFbE=; b=ZmB6iy26Y9HGO45RuGwkUV1Ahh12iEDfhFqKidAmJGmS2nEeSbtWREXw NTdJ01czq5sS1E+Ry/pRXLFsvCY3+kocSXxBk5oqGU0OtAxJpx0EhzS8x Q5hFJGlxykteePhT2hhjli7RIjK38eYKrz0+cTclykp45U5LumujEtOst sXpmwCl6DpoKZLa7tveoqUvYilg33H/ABTTO7hIXuksas1r0jbUKjcE/D aPgAbA7SiE7wyQZYDUBWqVBvEvtYfO2jTsr17yPutB90p5ZBvRqAG7tOO ej1x7h99MVzKkgdCveuGLwG6aizDphZErLezcXWczMRaOKKNYenwigMvd w==; X-CSE-ConnectionGUID: wyjZGJGgTsOQ7fDaCIUEYg== X-CSE-MsgGUID: ExWkWeBqQiiWwe9K80jveQ== X-IronPort-AV: E=McAfee;i="6700,10204,11440"; a="72344817" X-IronPort-AV: E=Sophos;i="6.15,303,1739865600"; d="scan'208";a="72344817" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2025 08:28:24 -0700 X-CSE-ConnectionGUID: 2ks/NKwoQEGj5bXuyKEKqA== X-CSE-MsgGUID: y5+U2LApQFqPaXGjMmzNgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,303,1739865600"; d="scan'208";a="141044428" Received: from iherna2-mobl4.amr.corp.intel.com (HELO [10.125.109.100]) ([10.125.109.100]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2025 08:28:23 -0700 Message-ID: <036f8679-485a-4c99-92e7-f271a972fbf8@intel.com> Date: Wed, 21 May 2025 08:28:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 6/9] x86/apic: Introduce Remote Action Request Operations To: Rik van Riel , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, nadav.amit@gmail.com, Rik van Riel , Yu-cheng Yu References: <20250520010350.1740223-1-riel@surriel.com> <20250520010350.1740223-7-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250520010350.1740223-7-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A224A14000A X-Stat-Signature: i3n8eteyjwi48ndpfsar4mudjfucguke X-Rspam-User: X-HE-Tag: 1747841305-22917 X-HE-Meta: U2FsdGVkX18YKH2GJL3oymzxKJmwVXeLWqUNEeAX4+V0hfsX8ryorH5i1qwe78hYT04N3L67uDHcl01Z6xECKnWcERuv1ivufUUkQe9XHe8XqjbuzYfj1M59GCNTe3AUMF1x9lQtrluk3IR5d51tI0Z1/K/RKaC4PX+AOrcZh83BbNpxF1rHB+lA9oG5cu+h7Gn6gkZaIJkgg8ehVXvC1P4OFXbyaaYyKClULmGHpm2Te5nPybdY0UwTNwh6o0bNFWyyWxvjjXvs18Uh+C1a1IkH/AicCU8v7Y6puPR7PDpfk/Wdypua4+FBy+21Ly9Au0Oe84YNEBCRLbA8qOKod5xCHctJaofEff/tjTARo2524VnzPclu7qR+6Th3qYROqnDJVWFjpiCgjLdFQB9lrBHXdL8skcTXzVSZax++mGLgSWGx4tkiaQR2li99XiNrHtk0IXBhNckgj9xKFaOc4vH8HsGLLb8SxJLefBXpEiIl/MStIWPfJCu/mh+eaVIsmUXUjTnB/TWaZKxIEwWv26OU2LBC8vMN2IYHIsgIGN3DztsFZOlsuRYODyVacxbXSSRQhrSML/5p4As/nvKNqrMr8MKG1MJSowyo8VnFQmGr9YpoHfjKnbTlET4J1ETi5iSvkK3Zh19Fx8lBSr92U9Xww+sJ2+MFpfAabZFUfeWxj0pe0/n6z/fVGl7xhLViIk1bGRAg8d0NPNZCadHzAq7fY7lCid8tVNLAqlueYmxGxKNy6oJC+JQq/Eolm3n+KRF959aCZu45DBYawWO+CttTIdsNWNtZ1FDyO+NiFq28+I3vHO9XfZY+5HRqAvI3pwYEZfccEYJHZtZngkzK3SvuHK3EMWz9YlTpDb9PUj77bcF0aadvNZU8+DVUoDLA/oRPG01tCMBC6ETPfg0/KmKHOc9s6zfmyU/MapPBCMwgCUFHxGq6kBdOITsNeUPM5ZKbMHYc5OIvS1MkMam sMqUNpJn czklhyoIzFP1eLtdLaF808bqD4DkyR6reQHOAGODxLuGhIXFl/j7X1xSHFBWIZwDAIpCm93fwM4Dq+1sXoM5jt6f20K4fpVabda2sFTGdwJ5wLXM920kKESx41nCedLEcXKlBm4PMH1B06fIBIPnxHtgKYpDTXX1IhxK7nfd6HjvxSs6Na0+JS989AxFx2pmbDkb4A79kCA5XomvwPUp5e8FJX5z3aChLQKI7t4QPwjij+9vTbnQYPYD59GxD3apN/ZUNaY81WlMAhYTdIy/mmvaWIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h > index 0c1c68039d6f..1ab9f5fcac8a 100644 > --- a/arch/x86/include/asm/smp.h > +++ b/arch/x86/include/asm/smp.h > @@ -40,6 +40,9 @@ struct smp_ops { > > void (*send_call_func_ipi)(const struct cpumask *mask); > void (*send_call_func_single_ipi)(int cpu); > + > + void (*send_rar_ipi)(const struct cpumask *mask); > + void (*send_rar_single_ipi)(int cpu); > }; I assume Yu-cheng did it this way. I'm curios why new smp_ops are needed for this, though. It's not like there are a bunch of different implementations to pick between. > -void native_send_call_func_ipi(const struct cpumask *mask) > +static void do_native_send_ipi(const struct cpumask *mask, int vector) > { > if (static_branch_likely(&apic_use_ipi_shorthand)) { > unsigned int cpu = smp_processor_id(); > @@ -88,14 +88,19 @@ void native_send_call_func_ipi(const struct cpumask *mask) > goto sendmask; > > if (cpumask_test_cpu(cpu, mask)) > - __apic_send_IPI_all(CALL_FUNCTION_VECTOR); > + __apic_send_IPI_all(vector); > else if (num_online_cpus() > 1) > - __apic_send_IPI_allbutself(CALL_FUNCTION_VECTOR); > + __apic_send_IPI_allbutself(vector); > return; > } > > sendmask: > - __apic_send_IPI_mask(mask, CALL_FUNCTION_VECTOR); > + __apic_send_IPI_mask(mask, vector); > +} > + > +void native_send_call_func_ipi(const struct cpumask *mask) > +{ > + do_native_send_ipi(mask, CALL_FUNCTION_VECTOR); > } This refactoring probably belongs in a separate patch. > void apic_send_nmi_to_offline_cpu(unsigned int cpu) > @@ -106,6 +111,16 @@ void apic_send_nmi_to_offline_cpu(unsigned int cpu) > return; > apic->send_IPI(cpu, NMI_VECTOR); > } > + > +void native_send_rar_single_ipi(int cpu) > +{ > + apic->send_IPI_mask(cpumask_of(cpu), RAR_VECTOR); > +} > + > +void native_send_rar_ipi(const struct cpumask *mask) > +{ > + do_native_send_ipi(mask, RAR_VECTOR); > +} > #endif /* CONFIG_SMP */ > > static inline int __prepare_ICR2(unsigned int mask) > diff --git a/arch/x86/kernel/apic/local.h b/arch/x86/kernel/apic/local.h > index bdcf609eb283..833669174267 100644 > --- a/arch/x86/kernel/apic/local.h > +++ b/arch/x86/kernel/apic/local.h > @@ -38,6 +38,9 @@ static inline unsigned int __prepare_ICR(unsigned int shortcut, int vector, > case NMI_VECTOR: > icr |= APIC_DM_NMI; > break; > + case RAR_VECTOR: > + icr |= APIC_DM_RAR; > + break; > } > return icr; > } I feel like this patch is doing three separate things: 1. Adds smp_ops 2. Refactors native_send_call_func_ipi() 3. Adds RAR support None of those are huge, but it would make a lot more sense to break those out. I'm also still not sure of the point of the smp_ops.