From: Igor Stoppa <igor.stoppa@gmail.com>
To: Matthew Wilcox <willy@infradead.org>, dave.hansen@linux.intel.com
Cc: linux-security-module@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Igor Stoppa <igor.stoppa@huawei.com>
Subject: Correct way to access the physmap? - Was: Re: [PATCH 7/9] Pmalloc Rare Write: modify selected pools
Date: Fri, 4 May 2018 01:52:29 +0400 [thread overview]
Message-ID: <035f2bba-ebb1-06a0-fb88-3d40f7e484a7@gmail.com> (raw)
In-Reply-To: <20180424115050.GD26636@bombadil.infradead.org>
On 24/04/18 15:50, Matthew Wilcox wrote:
> On Mon, Apr 23, 2018 at 04:54:56PM +0400, Igor Stoppa wrote:
>> While the vanilla version of pmalloc provides support for permanently
>> transitioning between writable and read-only of a memory pool, this
>> patch seeks to support a separate class of data, which would still
>> benefit from write protection, most of the time, but it still needs to
>> be modifiable. Maybe very seldom, but still cannot be permanently marked
>> as read-only.
>
> This seems like a horrible idea that basically makes this feature useless.
> I would say the right way to do this is to have:
>
> struct modifiable_data {
> struct immutable_data *d;
> ...
> };
>
> Then allocate a new pool, change d and destroy the old pool.
At the end of the summit, we agreed that I would go through the physmap.
But I'm not sure of what is the correct way to access it :-/
Starting from a vmalloc address, say:
int *i = vmalloc(sizeof(int));
I can get its linear counterpart:
int *j = page_to_virt(vmalloc_to_page(i));
and the physical address:
int *k = virt_to_phys(j);
But how do I get to the physmap?
I did not find much about it, apart from papers that talk about specific
hardcoded addresses, but I would expect that if there is any hardcoded
constant, by now, it's hidden behind some macro.
What I have verified, so far, at least on qemu x86_64, is that
protecting "i" will also make "j" unwritable.
--
igor
next prev parent reply other threads:[~2018-05-03 21:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 12:54 [RFC PATCH v23 0/6] mm: security: write protection for dynamic data Igor Stoppa
2018-04-23 12:54 ` [PATCH 1/9] struct page: add field for vm_struct Igor Stoppa
2018-04-23 12:54 ` [PATCH 2/9] vmalloc: rename llist field in vmap_area Igor Stoppa
2018-04-23 12:54 ` [PATCH 3/9] Protectable Memory Igor Stoppa
2018-04-23 12:54 ` [PATCH 4/9] Documentation for Pmalloc Igor Stoppa
2018-04-23 12:54 ` [PATCH 5/9] Pmalloc selftest Igor Stoppa
2018-04-23 12:54 ` [PATCH 6/9] lkdtm: crash on overwriting protected pmalloc var Igor Stoppa
2018-04-23 12:54 ` [PATCH 7/9] Pmalloc Rare Write: modify selected pools Igor Stoppa
2018-04-24 11:50 ` Matthew Wilcox
2018-04-24 12:32 ` lazytyped
2018-04-24 12:39 ` Igor Stoppa
2018-04-24 14:44 ` Matthew Wilcox
2018-04-24 15:03 ` lazytyped
2018-04-24 15:29 ` Igor Stoppa
2018-04-25 20:58 ` Igor Stoppa
2018-04-24 12:33 ` Igor Stoppa
2018-04-24 17:04 ` Igor Stoppa
2018-05-03 21:52 ` Igor Stoppa [this message]
2018-05-03 21:55 ` Correct way to access the physmap? - Was: " Dave Hansen
2018-05-03 22:52 ` Igor Stoppa
2018-04-23 12:54 ` [PATCH 8/9] Preliminary self test for pmalloc rare write Igor Stoppa
2018-04-23 12:54 ` [PATCH 9/9] Protect SELinux initialized state with pmalloc Igor Stoppa
2018-04-24 5:58 ` kbuild test robot
2018-04-24 12:49 ` Stephen Smalley
2018-04-24 14:35 ` Igor Stoppa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=035f2bba-ebb1-06a0-fb88-3d40f7e484a7@gmail.com \
--to=igor.stoppa@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=igor.stoppa@huawei.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox