From: "Yang Shi" <yang.s@alibaba-inc.com>
To: Michal Hocko <mhocko@kernel.org>, David Rientjes <rientjes@google.com>
Cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory
Date: Fri, 20 Oct 2017 07:12:56 +0800 [thread overview]
Message-ID: <0353184c-7cad-7222-6fea-2c5df3dbe851@alibaba-inc.com> (raw)
In-Reply-To: <20171019072809.xykifzpsiabdjv6m@dhcp22.suse.cz>
On 10/19/17 12:28 AM, Michal Hocko wrote:
> On Tue 17-10-17 15:39:08, David Rientjes wrote:
>> On Wed, 18 Oct 2017, Yang Shi wrote:
>>
>>>> Yes, this should catch occurrences of "huge unreclaimable slabs", right?
>>>
>>> Yes, it sounds so. Although single "huge" unreclaimable slab might not result
>>> in excessive slabs use in a whole, but this would help to filter out "small"
>>> unreclaimable slab.
>>>
>>
>> Keep in mind this is regardless of SLAB_RECLAIM_ACCOUNT: your patch has
>> value beyond only unreclaimable slab, it can also be used to show
>> instances where the oom killer was invoked without properly reclaiming
>> slab. If the total footprint of a slab cache exceeds 5%, I think a line
>> should be emitted unconditionally to the kernel log.
>
> agreed. I am not sure 5% is the greatest fit but we can tune that later.
5% might be too few. For example, on a machine with 200G memory, if
there is 80G page cache, radix_tree_node might consume 10G. IMHO, 10%
might be better.
Yang
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-19 23:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 17:25 [PATCH 0/3 v11] oom: capture unreclaimable slab info in oom message Yang Shi
2017-10-10 17:25 ` [PATCH 1/3] tools: slabinfo: add "-U" option to show unreclaimable slabs only Yang Shi
2017-10-10 17:25 ` [PATCH 2/3] mm: slabinfo: dump CONFIG_SLABINFO Yang Shi
2017-10-17 0:17 ` David Rientjes
2017-10-10 17:25 ` [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory Yang Shi
2017-10-17 0:15 ` David Rientjes
2017-10-17 7:44 ` Michal Hocko
2017-10-17 20:59 ` David Rientjes
2017-10-17 21:40 ` Yang Shi
2017-10-17 21:50 ` David Rientjes
2017-10-17 22:20 ` Yang Shi
2017-10-17 22:39 ` David Rientjes
2017-10-18 19:09 ` Yang Shi
2017-10-19 7:28 ` Michal Hocko
2017-10-19 23:12 ` Yang Shi [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-04 21:29 [PATCH 0/3 v10] oom: capture unreclaimable slab info in oom message Yang Shi
2017-10-04 21:29 ` [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory Yang Shi
2017-10-06 9:37 ` Michal Hocko
2017-10-06 16:37 ` Yang Shi
2017-10-09 6:33 ` Michal Hocko
2017-10-09 6:36 ` Michal Hocko
2017-10-09 16:44 ` Yang Shi
2017-10-09 18:53 ` Yang Shi
2017-10-09 21:00 ` Yang Shi
2017-10-07 10:10 ` kbuild test robot
2017-10-07 13:05 ` kbuild test robot
2017-10-03 18:06 [PATCH 0/3 v8] oom: capture unreclaimable slab info in oom message Yang Shi
2017-10-03 18:06 ` [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory Yang Shi
2017-10-04 14:27 ` Michal Hocko
2017-10-04 17:37 ` Yang Shi
2017-10-04 18:08 ` Yang Shi
2017-10-05 7:57 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0353184c-7cad-7222-6fea-2c5df3dbe851@alibaba-inc.com \
--to=yang.s@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox