From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D203CC001DC for ; Wed, 26 Jul 2023 10:34:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 180C06B0074; Wed, 26 Jul 2023 06:34:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E3506B0075; Wed, 26 Jul 2023 06:34:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9E988D0001; Wed, 26 Jul 2023 06:34:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D52D56B0074 for ; Wed, 26 Jul 2023 06:34:21 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9CF58C01F5 for ; Wed, 26 Jul 2023 10:34:21 +0000 (UTC) X-FDA: 81053403522.11.63D3ED1 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf26.hostedemail.com (Postfix) with ESMTP id 9D0FE140005 for ; Wed, 26 Jul 2023 10:34:18 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=FU9mgCuf; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf26.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690367659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6pBhJZIIkh5Y0ZegeYnaNPrsKup8SfYVJ8Ax7qMD0bM=; b=AWVa4oFYJU7f9LFCJRg2yGowHOIuHwe/ORn/UGQ0l9/QgVWx1wzl+fzOfjBlGs2371jkjy VwYR8C3OuzUV5sxeRgBD1lYNowY4PdzceR4ZGqev53fSS6iXMjP20gzOhnFmBtL2IpEb34 Ov66cWwtxC+jsc1XxNfx6ouK+3ultzw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=FU9mgCuf; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf26.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690367659; a=rsa-sha256; cv=none; b=Rwrn5aqqiicdc+gz3HIaKB6cph+vByC98V2r0BGhLVNT+jIth9hyuBVHx68XOE0jpL0Ub9 IE1jfGtJWVnvwM9G8DdsUD9B6R82C22PZ76lEZc0wo2+68aOCAnQDe5zHcaeRqB2uP5Z0U lHO1LqeX4tJBl3eTe5PRLEsbBmopeEo= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4fdfefdf5abso3285673e87.1 for ; Wed, 26 Jul 2023 03:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690367656; x=1690972456; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6pBhJZIIkh5Y0ZegeYnaNPrsKup8SfYVJ8Ax7qMD0bM=; b=FU9mgCufp8+t0IW6faQAPl5Iyi4wcOnZOizZwNmJU76ZXU7xiOWIITjHX2EIGK1Oal Ei/6g+rsdQ4mETerF5Pv+aR7SpDCp135DImT99F+vRQlDrJPNFcFq/uXLREViUgA4nAs 4V/SH5e4kF0nckxnWhIjVwPHlo6zI8uWN4PBph1S5DQXLK3ygU2aFl2/k5v5DPy4ynDN ZYfj36ZAE3iVvhO1/AXnqxpup1RnND1DG5+/LAtbZBvR0wbMIKj5F2W5TVKUzre187RU tlyogaTGkfVgIRxhdyIJi5XTe7+SNuLeS+7+2UF9pEWEjFtOEp8tluS2xZZbLRwF/GlH pfeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690367656; x=1690972456; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6pBhJZIIkh5Y0ZegeYnaNPrsKup8SfYVJ8Ax7qMD0bM=; b=FzlGwg2CIbAr0iRbo4jA5WGaJ9cDHS8HTXgfq+QJITNeVQ6V0+awg+Rz4e2ihRYa1e r6xIvllXpaeQ9NnL9ELQ5Gn6aTvECL2sdo8T+UuROH8IJ6uOC9AF2gbyGDq7P7lAIW4s pUKXCVCn9146cY+FtrA40iT+lU/HSTGupTngf3WweV7taSOin2gqCq+gBJ06CAiNa6lQ H0oUkPAzivKTWStyZHzLP8PlZxgbNO8XXDoL1HauK9DrmfG4y02aNJvgnX4DLhqIm2Nf IyFfDMTYL1D5GNnNdF1H1bfY2qqBtjcwtXPScpkIhNUecBoaQUlfFQZQB00IZE7OJ36p VyOQ== X-Gm-Message-State: ABy/qLZZBtbkt+3Zw/LnM0seCXXx+TNWVQ97P0YPgLCCZb1WB02eLonw 40mCqAe3umKT7g2m7SXt6KCNDWckSRglnESSOk4= X-Google-Smtp-Source: APBJJlGJC+4Vw7ybsGTQvxNelxSmpvS0+CLSLRChw/6Kg32BWyc7brBDAHFPjsTUB/+9mvQi04/Caw== X-Received: by 2002:a05:6512:2824:b0:4f9:5196:5ed0 with SMTP id cf36-20020a056512282400b004f951965ed0mr1336227lfb.7.1690367656268; Wed, 26 Jul 2023 03:34:16 -0700 (PDT) Received: from ?IPV6:2a02:6b6a:b465:0:2a3c:96a:1b3a:ab94? ([2a02:6b6a:b465:0:2a3c:96a:1b3a:ab94]) by smtp.gmail.com with ESMTPSA id 18-20020a05600c235200b003fc07e1908csm1591999wmq.43.2023.07.26.03.34.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 03:34:15 -0700 (PDT) Message-ID: <03476b1d-c825-0ab6-73bc-b98419d3dff6@bytedance.com> Date: Wed, 26 Jul 2023 11:34:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC 0/4] mm/memblock: Skip prep and initialization of struct pages freed later by HVO To: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, rppt@kernel.org Cc: linux-kernel@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, simon.evans@bytedance.com, punit.agrawal@bytedance.com References: <20230724134644.1299963-1-usama.arif@bytedance.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20230724134644.1299963-1-usama.arif@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: pyfrgtidear88js46qhcf9cj18brruew X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9D0FE140005 X-HE-Tag: 1690367658-905146 X-HE-Meta: U2FsdGVkX1+VC+VBJQgTp8+DQzaCZiOJWX0wUs6HAoExUH0brrwgr1M7h3Flxy+f+07rrjZYRDlIWPR7H9gtr3iTiE2Kqhe21WTtEFaHgDjdFQX8IcAcw/SHAWD7mIuvdRUctqkLiWD7BPsHIVaiaXUVm+KniIHpnYkpyQ5rZRmkmcZ/qnm5kVcXjetPO6WnI0ZXhg2Bz1N1Ri7bbXQqOMonqZtVc8ViLM3BlWtFaiDj1ncqA+U0DXevWg1NpSdhUIFdyfCDEc1dUvukPfz62G/oiIDwNuYappAiWHz9Axo4f618cxA8c/a3NqyfCKOJoismCz99TiGOSD2AsFg29seiCYlKRZZEIQvKkpVayCDmaL3jfh1sURkJSo36lC/Z0ve5PjJDGL+tHf3gQZ85iqv12BLiqXUrBKqkuMMDZPZenRJYL7uvOdaUP00Ys9r86ZkEM4zeUntozqZ64Tp+8ykeRi9PKXafSSyPUEwBn4JKA8oHE7yF2YpZSOLa3gLYM4nQAv+qG/5tUeDieKbjnJVsFTN5OOdo8NvwDxrszzLGmLgeNo3m0aRs4V5zMYmDArVwOq7Qp712JBdeGWF4uoBrldt+p8I/HoF71f4xeYEoKpcO+cAramOjGg6ZXa6g31i7nmbDJJAzoWMO/LUDIpVPYaUdDyW5osga8dno+awWXIg+3jc2GI1us+I3b7aox2dNhdrUxFsZeTWMV6cfB9xD299HKGVy1q2OOnu2Mh4FiCS4bz3WBBJKAzOESgeNtza9YIAcMY3Ss4YP2vMwnc0LndCcGV92GHXz7AymPYOxAzpPt6gETcnhqa2tyLhybArB3rRXZzA9rYl5NoP9VAunKKXk+F3Gkyiui8OGpAzws5OUzcpoCwp18sqCrXq5l1kpFltgqzx9ZEQfKUMQyQepJQ/g49cW6VhGRN2GkPYeKQlncd1evBRetoW3qZqD85JKYh12p32Tx9hRmSB aW9DvwiI F2MFP1/Oq9mCUINa75ctG8AXLxJQtjm3+rl6/TJxlOCh6b06rsMDytsAN2TASKR2Wj41bqATltkWKsTBTUwBhijZZIVGB86lsgIF/JELcTHVVhsUYs08Lfk+NuhDjolvaITwggm86a5RrqIJbh8DK/Ye/geDjvLQnrzEPE/1V8S4AI0/CrPUy1eOdigNtLOJuLgZpjYgnv5HABlhHL4zP62MVJb9s80aS57LbgFfIsTzAe38+VUER/hJ2dHxWmqFUCLtVTB1K9ZZu5hGpk/iJyFIlh9xdr0MW94qnbbESC3O0cjk0HdpWraxy6fm0Q0TkSaIKEaUXQFunDrIitDs16E1aEklqSugDWovIRNEbNBmE9vQFoESUiQdODQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24/07/2023 14:46, Usama Arif wrote: > If the region is for gigantic hugepages and if HVO is enabled, then those > struct pages which will be freed later by HVO don't need to be prepared and > initialized. This can save significant time when a large number of hugepages > are allocated at boot time. > > For a 1G hugepage, this series avoid initialization and preparation of > 262144 - 64 = 262080 struct pages per hugepage. > > When tested on a 512G system (which can allocate max 500 1G hugepages), the > kexec-boot time with HVO and DEFERRED_STRUCT_PAGE_INIT enabled without this > patchseries to running init is 3.9 seconds. With this patch it is 1.2 seconds. > This represents an approximately 70% reduction in boot time and will > significantly reduce server downtime when using a large number of > gigantic pages. There were a few errors reported by kernel-bot if different config options were changed (CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP disabled, CONFIG_CMA enabled). I will fix these in the next revision if the general approach in the patches looks good to the community to start review. Thanks, Usama > > Thanks, > Usama > > Usama Arif (4): > mm/hugetlb: Skip prep of tail pages when HVO is enabled > mm/memblock: Add hugepage_size member to struct memblock_region > mm/hugetlb_vmemmap: Use nid of the head page to reallocate it > mm/memblock: Skip initialization of struct pages freed later by HVO > > arch/arm64/mm/kasan_init.c | 2 +- > arch/powerpc/platforms/pasemi/iommu.c | 2 +- > arch/powerpc/platforms/pseries/setup.c | 4 +- > arch/powerpc/sysdev/dart_iommu.c | 2 +- > include/linux/memblock.h | 8 +- > mm/cma.c | 4 +- > mm/hugetlb.c | 36 +++++--- > mm/hugetlb_vmemmap.c | 6 +- > mm/hugetlb_vmemmap.h | 4 + > mm/memblock.c | 87 +++++++++++++------- > mm/mm_init.c | 2 +- > mm/sparse-vmemmap.c | 2 +- > tools/testing/memblock/tests/alloc_nid_api.c | 2 +- > 13 files changed, 106 insertions(+), 55 deletions(-) >