From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C2FCD6138 for ; Mon, 9 Oct 2023 21:10:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 013728D0094; Mon, 9 Oct 2023 17:10:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F062A8D0089; Mon, 9 Oct 2023 17:10:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCDCC8D0094; Mon, 9 Oct 2023 17:10:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CCF598D0089 for ; Mon, 9 Oct 2023 17:10:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A85AE1A039D for ; Mon, 9 Oct 2023 21:10:00 +0000 (UTC) X-FDA: 81327165360.02.EE3D85A Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf25.hostedemail.com (Postfix) with ESMTP id A0062A000A for ; Mon, 9 Oct 2023 21:09:58 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=KjfV819L; spf=pass (imf25.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696885798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1TU4GqFpyKx+szQTs3GpdZdYoNMAHrbMfWPpl7iHi/E=; b=2KXUvAZKzSaTBYxR7b8m+b3+5urPJjw2Qmp/QHsbsJkT64exTHz32gI7m3l2BBbDOYjRvQ uPIy8KWRCEfoqb4LCQ/bmXNWcfq+bAQ0aKw8BX7sZCxwNaYyBNcmNgz6UZaTXoX6EpcXEK 7x2w1zAcKBjS8AWCDYqEag+D3vkA9T4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696885798; a=rsa-sha256; cv=none; b=B8NnK2Widep3cCmFds4y19sRpjQ5blqXREPhP9M9hBaGBP1eyTF5HOUM5bUYwsy7qnvHiC hrZrHgTnJUHhm07M1IQr/9fo+dKmfstI3x1VwPP9zy+serQSiFqFJJxWb/vh6ytAbCvAS6 UYoJy87Ut/zB425qXUXhZwKDW0gYChI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=KjfV819L; spf=pass (imf25.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-503397ee920so6222097e87.1 for ; Mon, 09 Oct 2023 14:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696885797; x=1697490597; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1TU4GqFpyKx+szQTs3GpdZdYoNMAHrbMfWPpl7iHi/E=; b=KjfV819LlwEdtTVVO+8MNHXF9Qh9cZ77vJU8VnV4/2Yw8yQKnm/F8yy2A69Ogb6OIm wnH7byeHbdyBVvwhAT+OucqxNbpeExkuDFbbS321X/d29UsTVHbueELKLHprOMqt1Gpb H4A99qLhp4cyEs0ILQY2fbb/mDTcNeHwZnjjJ1l7JAOiAsus0nsDQB2bnXyEQ9bqrTvj O0rHnGRPkrz5cQOw5PTNOtzSZCGL0oxMdEGVfhWkDU1IYpcKGrgRpzTVU2CXeoT81it9 ocIMvEjplp7nbyH+36Zuoij0BzAXMJE2f+sp7Fcd6qG2zk+MK2MzIpLzduZQsL4F2RPo RyHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696885797; x=1697490597; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1TU4GqFpyKx+szQTs3GpdZdYoNMAHrbMfWPpl7iHi/E=; b=kGRa94+Vc5L6l2pNRdPugy/K+UcCLjbaZOt6UqJlVY2okjTPP8URLPZ3VA3cBmBWbs tU3pDL5gfd5FB77auKT14DBkdCC9oPuXYSy/P0yCaskzb3sDpq9rgZqNjW4kzPHc7rId +8a5QaFZLaB5nmxLil/ViY0oCnzQ5tcsMxoyoACZ1RBtCbqoo0NonC88odAksltp6cIi wnP38XqgatqSMwVwJHYRjpkDoXaTYmiqvYi94BE+IZKYCL6lvT7VLmwmY9lhP+d72M/J Guh5WXlB4FcHTWjtl2L1zpSNabiEN6pXcST/Jdztw6iq7Y/izjZELItCB3apCvB1dVKH Jh0Q== X-Gm-Message-State: AOJu0Ywk/0L/VYihICrvtzdTiniHFJ3todltJCzql7c9FOG6Pdw3DXlm rhxn9/F/LrGSMuCeviAcr1zr9w== X-Google-Smtp-Source: AGHT+IGwECwTllJuzDm281Ve4ATbJY/7Wftg82qOVyDB+KpdpskIxF5YLycq0aHOuDixXp0dy01Xmw== X-Received: by 2002:a19:2d14:0:b0:505:84c8:c640 with SMTP id k20-20020a192d14000000b0050584c8c640mr14717972lfj.48.1696885796954; Mon, 09 Oct 2023 14:09:56 -0700 (PDT) Received: from [172.30.204.90] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id q10-20020ac25a0a000000b004ff8cd27a61sm1532825lfn.213.2023.10.09.14.09.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 14:09:56 -0700 (PDT) Message-ID: <0343c1d5-8706-4cf8-a17e-25ab27f654d8@linaro.org> Date: Mon, 9 Oct 2023 23:09:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations Content-Language: en-US To: Mike Kravetz Cc: Anshuman Khandual , Andrew Morton , Xiongchun Duan , Barry Song <21cnbao@gmail.com>, David Rientjes , Miaohe Lin , Matthew Wilcox , linux-mm@kvack.org, Naoya Horiguchi , Joao Martins , David Hildenbrand , Michal Hocko , Oscar Salvador , linux-kernel@vger.kernel.org References: <20230925234837.86786-3-mike.kravetz@oracle.com> <20230929205731.GA10357@monkey> <20231006030836.GC86415@monkey> <5d14b681-a2c9-4210-a0c1-bf38708b7998@linaro.org> <20231006223512.GC3861@monkey> <20231009032926.GA3376@monkey> <070bd916-d4d6-41c2-9f51-af35e80c96b9@linaro.org> <20231009150401.GA3846@monkey> <20231009151513.GB3846@monkey> From: Konrad Dybcio In-Reply-To: <20231009151513.GB3846@monkey> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A0062A000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9zkcwcrtk4cx7wjjqpcmmssp983ukcxg X-HE-Tag: 1696885798-469872 X-HE-Meta: U2FsdGVkX1/VZQi8FgnexNq7lRLi9Z28JAuURIt7SHCvVjJ/4R71jMal71KzONSzcY874bB6PyIhMEYAIv/KjWzE0+JQ6s1sPA5D5iaxFnYnf8H6yykctlGAnhpcmqi6tl95NQQz1K5u4cHXFvEWhC0Qgzs3wCfQcM7pOLhcf7UyYMAXoEoFj7/b4UQEoe41PDTlXrgmaLmIFexJubL0DlMk1lXMncfVoURUZVdn3trGdRg4mkjDHFwLlmNBgisPw7XUIF3YrZwunguWsSjq9itcw7BjNvXbxWjRf3cqes4JwvgcAn2DK0QfRro3ZFUL0gZJRW7ioQcczuEwu+CzUajhKmXwUjCRMYbYh7oytQJSgVJ8gb+/PiztjPnWBqVGnVYmk2CSL+bgk5c6BnT3txA8Zql3HLN1gnLhAuR+1T4yIO7/tB8CTD3pUUVbiwv/R+anxt7INaolfaki2Bg+nCWq00qP6ldAikkFYBlSbMs76YeaCaVuNtrwsWr2GfGdGuV33fuSKDc6W2PcHSYexQZp4eOKJdIOxrciF9ExrFGDrE1XwcD57VN3gDUE7KOQZe+SggPlWQsx4Wecnejtu3T2OSJV8mDb2FpmwkKAYZUrhxGye5INSma5B1IfU6xpXcOKW/+y6HtrJsixjLQkl5p7YPBHNLwU5KPjrkZGods17qHZWInYLLc8fMXuzg16Bg32jAf/YbgIbMPSMEVvqDm5dU/l2+jFw5jWlYjBb7qHOF1aEfUG1UZsO3g7TakmPvstO4YnpVQIbDe7oCYEwyyhC6d31zF0dVJOio9nFztZF6gqwyo1NHPrR9yP8rlr7mtvYHPL5Moz2pC+2wZYK9LG0B006pNhw4aMVLRqGZyuqZPmRQnSL/XHCCurKdmLHHjLTK+R2q7CAgNTnhrJ2MQ2JraHAWE3bISbhw4pOqdEwYR/laSub/PapIw7JTvikVLxehMPMUj9diBUv3P 2qFvztCH DCI6poE0O4KCIS+FbppCszmbN9sk1tJw7wNz1S4U1gwVK207vxpQEM2nUiKBokduPtaE3CeM78R7EPKN65Sdvaaaui2O7ibCnC+eVOnyNaIkhvW+FzwcdPLQWthd4wUd8zfmfSqGLv9gOpqVFey40XHxsOYMFKuMlCzDCxkBZY94tfUctqWykEMd/QiBOz0KyU5ffRGQGdfmiB0rrq0M34xYnE9bdT1Mu7k2p0ePhhTf/hyQ9IBMess0ELGJu00Orjawf2RSHJ4Sb+qUPN9wjAKZB320SETvXP+X9Mwl0YNqxzKZEL4eIrJXrdjYa4iqvn+rYDX4tz0p/NAfjwo1OUBeXRm+0GUbCApeclqzsJSWnGPi6ESe1xWzo3DKnEBpxNzhjBTcGYxtxd7NOCuJiqe6f5bCp2lH5KzIQ7lvTSFhJFmNy5cbS3uhKAkEc4QBA8BC4DtgaT6/7FalTo1VPf0VxD+YBdb3ft3UIqQFGf4P/ZqGryYfD3bv4VhSKkk5yFCQMJQK87SNZTimtcvrEoT+FVSKlpP2vH607jp3k4uYvrO4XIymOQachkdNboDiF1yWjYdJUCk3wUxWFpdE9vp+zjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/9/23 17:15, Mike Kravetz wrote: > On 10/09/23 08:04, Mike Kravetz wrote: >> On 10/09/23 12:11, Konrad Dybcio wrote: >>> On 9.10.2023 05:29, Mike Kravetz wrote: >>>> On 10/06/23 15:35, Mike Kravetz wrote: >>>>> On 10/06/23 23:39, Konrad Dybcio wrote: >>>>>> On 6.10.2023 05:08, Mike Kravetz wrote: >>>>>>> On 10/02/23 11:57, Konrad Dybcio wrote: >>>>>>>> On 9/29/23 22:57, Mike Kravetz wrote: >>>>>>>>> On 09/27/23 13:26, Konrad Dybcio wrote: >>>>>>>>>> On 26.09.2023 01:48, Mike Kravetz wrote: >>> >>> I managed to get a boot log: >>> >>> https://pastebin.com/GwurpCw9 >>> >>> This is using arch/arm64/boot/dts/qcom/sm8550-mtp.dts for reference >>> >> >> Early on in boot log before the panic, I see this in the log: >> >> [ 0.000000] efi: UEFI not found. >> [ 0.000000] [Firmware Bug]: Kernel image misaligned at boot, please fix your bootloader! >> >> Isn't that misalignment pretty serious? Or, is is possible to run with that? >> >> There are no hugetlb pages allocated at boot time: >> >> [ 0.000000] Kernel command line: PMOS_NO_OUTPUT_REDIRECT console=ttyMSM0 earlycon clk_ignore_unused pd_ignore_unused androidboot.bootdevice=1d84000.ufshc androidboot.fstab_suffix=default androidboot.boot_devices=soc/1d84000.ufshc androidboot.serialno=ab855d8d androidboot.baseband=msm >> >> So, the routine where we are panic'ing (gather_bootmem_prealloc) should be a >> noop. The first thing it does is: >> list_for_each_entry(m, &huge_boot_pages, list) { >> ... >> } >> >> However, huge_boot_pages should be empty as initialized here: >> __initdata LIST_HEAD(huge_boot_pages); >> >> At the end of the routine, we call prep_and_add_bootmem_folios to >> process the local list created withing that above loop: >> >> LIST_HEAD(folio_list); >> >> This should also be empty and a noop. >> >> Is it possible that the misaligned kernel image could make these lists >> appear as non-empty? > > Actually, just saw this: > > https://lore.kernel.org/linux-mm/20231009145605.2150897-1-usama.arif@bytedance.com/ > > Will take a look, although as mentioned above prep_and_add_bootmem_folios on > an empty list should be a noop. I'll try it out atop the series tomorrow or so. Konrad