From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B012C4332F for ; Thu, 13 Jan 2022 21:32:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E95EC6B007B; Thu, 13 Jan 2022 16:32:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E44C56B007D; Thu, 13 Jan 2022 16:32:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0D3F6B007E; Thu, 13 Jan 2022 16:32:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id C2F116B007B for ; Thu, 13 Jan 2022 16:32:08 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7C0B88287E0C for ; Thu, 13 Jan 2022 21:32:08 +0000 (UTC) X-FDA: 79026561936.31.900F241 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id 1103420006 for ; Thu, 13 Jan 2022 21:32:07 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0F770B822C8; Thu, 13 Jan 2022 21:32:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02EB1C36AEA; Thu, 13 Jan 2022 21:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642109525; bh=hj29mHHG1QdwbI27RwfBUvkMrE2JljtHYAxHeD3RozE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VB3VA+Q9Q4VAp//nSyPbE/D7jCUAYkDOcvI0Rtb//6OkTbwsqAd98uJG9bDOw1gio SqFEabwiKBkCDf1zVVa72s5SVvndzELh2+7FQ9GxEvj5cbCZRNjtCOG/crWOT++dQz 9qETli9kW95feFBygDJl6gjtze6/Ybreizu6EcexeoKxfMMZZ4gzAfF4t+3BflTxTm SGl/9lCLYpc546IcCur46bzoVmh2oKnGeVrBbF+FUdka4yyXwjkDHsnVQ3AT4nOG1S T5C/i/Mf0YlpZLZHCxFJEDP40dBceEJe9EcMaPgnN4iCok4W8qsRiC0HDwPNAF3yGl CYqMVHczJScAA== Message-ID: <034075bd-aac5-9b97-6d09-02d9dd658a0b@kernel.org> Date: Thu, 13 Jan 2022 13:31:58 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 2/3] selftests/x86/Makefile: Support per-target $(LIBS) configuration Content-Language: en-US To: Florian Weimer Cc: linux-arch@vger.kernel.org, Linux API , linux-x86_64@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-mm@kvack.org, the arch/x86 maintainers , musl@lists.openwall.com, libc-alpha@sourceware.org, linux-kernel@vger.kernel.org, Dave Hansen , Kees Cook , Andrei Vagin References: <3a1c8280967b491bf6917a18fbff6c9b52e8df24.1641398395.git.fweimer@redhat.com> <54ae0e1f8928160c1c4120263ea21c8133aa3ec4.1641398395.git.fweimer@redhat.com> From: Andy Lutomirski In-Reply-To: <54ae0e1f8928160c1c4120263ea21c8133aa3ec4.1641398395.git.fweimer@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1103420006 X-Stat-Signature: oiro7w3nz1eoaouzgrfptqbjziqwnqya Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VB3VA+Q9; spf=pass (imf03.hostedemail.com: domain of luto@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=luto@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1642109527-578878 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/5/22 08:03, Florian Weimer wrote: > And avoid compiling PCHs by accident. > The patch seems fine, but I can't make heads or tails of the $SUBJECT. Can you help me? > Signed-off-by: Florian Weimer > --- > v3: Patch split out. > > tools/testing/selftests/x86/Makefile | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > index 8a1f62ab3c8e..0993d12f2c38 100644 > --- a/tools/testing/selftests/x86/Makefile > +++ b/tools/testing/selftests/x86/Makefile > @@ -72,10 +72,12 @@ all_64: $(BINARIES_64) > EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) > > $(BINARIES_32): $(OUTPUT)/%_32: %.c helpers.h > - $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl -lm > + $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $(filter-out %.h, $^) \ > + $(or $(LIBS), -lrt -ldl -lm) > > $(BINARIES_64): $(OUTPUT)/%_64: %.c helpers.h > - $(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl > + $(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $(filter-out %.h, $^) \ > + $(or $(LIBS), -lrt -ldl -lm) > > # x86_64 users should be encouraged to install 32-bit libraries > ifeq ($(CAN_BUILD_I386)$(CAN_BUILD_X86_64),01)