From: Vlastimil Babka <vbabka@suse.cz>
To: Shakeel Butt <shakeel.butt@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
Meta kernel team <kernel-team@meta.com>
Subject: Re: [PATCH v2 6/9] memcg: do obj_cgroup_put inside drain_obj_stock
Date: Fri, 11 Apr 2025 10:34:02 +0200 [thread overview]
Message-ID: <03330910-9fbb-452b-b817-5bc24462f8aa@suse.cz> (raw)
In-Reply-To: <20250404013913.1663035-7-shakeel.butt@linux.dev>
On 4/4/25 03:39, Shakeel Butt wrote:
> Previously we could not call obj_cgroup_put() inside the local lock
> because on the put on the last reference, the release function
> obj_cgroup_release() may try to re-acquire the local lock. However that
> chain has been broken. Now simply do obj_cgroup_put() inside
> drain_obj_stock() instead of returning the old objcg.
>
> Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
> Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2025-04-11 8:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 1:39 [PATCH v2 0/9] memcg: cleanup per-cpu stock Shakeel Butt
2025-04-04 1:39 ` [PATCH v2 1/9] memcg: remove root memcg check from refill_stock Shakeel Butt
2025-04-04 1:39 ` [PATCH v2 2/9] memcg: decouple drain_obj_stock from local stock Shakeel Butt
2025-04-04 1:39 ` [PATCH v2 3/9] memcg: introduce memcg_uncharge Shakeel Butt
2025-04-04 1:39 ` [PATCH v2 4/9] memcg: manually inline __refill_stock Shakeel Butt
2025-04-04 1:39 ` [PATCH v2 5/9] memcg: no refilling stock from obj_cgroup_release Shakeel Butt
2025-04-04 1:39 ` [PATCH v2 6/9] memcg: do obj_cgroup_put inside drain_obj_stock Shakeel Butt
2025-04-11 8:34 ` Vlastimil Babka [this message]
2025-04-04 1:39 ` [PATCH v2 7/9] memcg: use __mod_memcg_state in drain_obj_stock Shakeel Butt
2025-04-04 1:39 ` [PATCH v2 8/9] memcg: combine slab obj stock charging and accounting Shakeel Butt
2025-04-04 1:39 ` [PATCH v2 9/9] memcg: manually inline replace_stock_objcg Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03330910-9fbb-452b-b817-5bc24462f8aa@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox