From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38596C25B76 for ; Sat, 1 Jun 2024 21:05:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A05DF6B00A2; Sat, 1 Jun 2024 17:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B4F46B00A5; Sat, 1 Jun 2024 17:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82DC56B00A6; Sat, 1 Jun 2024 17:05:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 660926B00A2 for ; Sat, 1 Jun 2024 17:05:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B824DA0C40 for ; Sat, 1 Jun 2024 21:05:43 +0000 (UTC) X-FDA: 82183551366.04.D9E3AA4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 539454000A for ; Sat, 1 Jun 2024 21:05:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Op6iEKu4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dBvJNwmx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Op6iEKu4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dBvJNwmx; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717275941; a=rsa-sha256; cv=none; b=e7dQcbcQnbURhO6W2PgFsrUZAJHlPj4BQZFnl1fPEy0wkFHzCA47Z9oeMhiAIiH5iFkA8b tTlx92f833Efo1n3GKlReFF7AbU//R+NNtn+NimdtPMQ4T1pryhHFLOdUbo4udch0ZiPEk 7qpiUvIQcCJrN1YhjwZeXbooXW/goI0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Op6iEKu4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dBvJNwmx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Op6iEKu4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dBvJNwmx; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717275941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kwPPQFqT3GBMJ/jhWI+Nr3RwsaB4dK6fZEkpDAERYTQ=; b=NBRBEdw3X9UYDPczYWp0gcRJSYzIUZhgi+6yYJvCylJjus48is32W8Z0BI/k2Cwt7edFGa MSXM1/TtxVn/OkVAHR0735LnT7prszp4r4DF5lWl8Hdk3TYxUm2rWvw8+FfYf366rMyn7l Hp+RgnTcSFPGpIiA9OWVK7mkg95wVH8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A054E1FEEC; Sat, 1 Jun 2024 21:05:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717275939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kwPPQFqT3GBMJ/jhWI+Nr3RwsaB4dK6fZEkpDAERYTQ=; b=Op6iEKu4yTxsRDrm0d/07HPUnilBG3ZXoBOScKonAsdbpsdm8eG42Qb2u4gd9E458+Ii0q OPI50/Ik3a0JmhHkQ4PWipL+esmZc31VHBrpDiXvjhzWvP3OXrNckhvfOrvx8p/6cWHm5U lLpyyNM6Lxc/1mYsjXKh/dtqlSa+Kt0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717275939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kwPPQFqT3GBMJ/jhWI+Nr3RwsaB4dK6fZEkpDAERYTQ=; b=dBvJNwmxTHGgr7p0bqPedHGk44G5htsVc2XQKZ6S5UbiFHvwpMCe771SfHo1hi8dPSxi5H pDRq8raJlRoG1cDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717275939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kwPPQFqT3GBMJ/jhWI+Nr3RwsaB4dK6fZEkpDAERYTQ=; b=Op6iEKu4yTxsRDrm0d/07HPUnilBG3ZXoBOScKonAsdbpsdm8eG42Qb2u4gd9E458+Ii0q OPI50/Ik3a0JmhHkQ4PWipL+esmZc31VHBrpDiXvjhzWvP3OXrNckhvfOrvx8p/6cWHm5U lLpyyNM6Lxc/1mYsjXKh/dtqlSa+Kt0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717275939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kwPPQFqT3GBMJ/jhWI+Nr3RwsaB4dK6fZEkpDAERYTQ=; b=dBvJNwmxTHGgr7p0bqPedHGk44G5htsVc2XQKZ6S5UbiFHvwpMCe771SfHo1hi8dPSxi5H pDRq8raJlRoG1cDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8685D137C3; Sat, 1 Jun 2024 21:05:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id k45SICONW2YUUgAAD6G6ig (envelope-from ); Sat, 01 Jun 2024 21:05:39 +0000 Message-ID: <03207187-9e85-412e-98a9-1965f31b0003@suse.cz> Date: Sat, 1 Jun 2024 23:05:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kunit/fortify: Remove __kmalloc_node() test Content-Language: en-US To: Kees Cook Cc: linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240531185703.work.588-kees@kernel.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240531185703.work.588-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 539454000A X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: uhth7rb5a7pmk5tnns7gcpnp9ouqzhxs X-HE-Tag: 1717275941-284829 X-HE-Meta: U2FsdGVkX18XLdFlySrTuIjubP5oFfSIWsnpIxhY4+1p+I2StgH7RWSJpQQuTydEpmyrTHZBFF76PHYaiXsAsv+J5ECTQLysoFiwRmojKEpjlrRQalsUkOZL2zCPpGGFLa/W3U44rcYqh4CQSLXr3OZ74i/BpklBZExZyoq/iD8BotzcSoQARSUZNEY0CvbrBxg1fQPRRdwLdsAGYZ6yJMivdlr1ZsMqsUo2ck8ZuC1E4NhOabCZ92TsClkYBUkiGE1IW6Kb7w3fK7C+b+QHwHsrsAy7+9MNmF983TTLzPnFJcV8wOPysnGx881sobab9FvbT5/VPWg61z7aPoPb0qTWoX8kIGB+zufwXlTU13gzFoIPtIjDn1iIvJMubgx+zxIYLTkQAmwTQ0k53NLWYMR5tgBglnLWAevO/w/1WPZyMZ3QMls8O0l00rOKyLAgrQGyR4zL+q9cv/Nrsv3CfxCcbYW26LHlYhbFt8ka4fK6T0V+eVWNOzBAsM3eoaENgrQbBo//zbf3htoJ054abZapErY9jO19UmsDBCUz7kM+eH4Jn0+nXTUMRqJ/bxnE8JcuqnZmU3hLefpO01fY+Iv4TmP/lHIK69RGNqtExJqyF800Ee7ZwRh0pNY18H/8E7cOZIZiarMay0e9eJEzs3wQ+YTBczjGeRMp0nTcA0vMr3uB5MNVHvGgJh65Oko+SPl1fLqEqAI5sN/Rk56AtBOkiDCLfoHz3NIcH7rDgoomQIErbZU04a/ZIYO9yGSiL/UJ70nkt4Zfok/x2IHlGeqbnmKaJ4y+kl2L4YtA68M6ZdaW1VoQxcdqLlxx4yHlurSbVQRMDaH0vx5ZZrMy/L9O9JLy5lotz3OE8YzK/KAKQpa/nsMkULlcKxPiPZcLbhDfhbs8hWriIvwsU/a5X8sWecMwK3IrMvn/bz24LJGQmV7j8RtsLxUrDUHqrPSiUEjq1s9+xIePB0cxDNC lSm8bOb+ WB4EDzEavEV0qt96ayb8E5uV4aZN0kZD4hmw67rgwQ0cpep2MVWvA2pLEg0CHH1mNIr57NjtaUE/pL1LCumB1hk+5FkgMVLfH0zofQcJiiCUhVTwod8jYoBYX2U1flihXjsC7Ldeuqj9u11kkE9UUB6YPTKeiCpYI/i0z8LxbgkRavIsZgwtwVwzeJZvnb9aFQ2BBSuioMR6MiJuGQoTl+arJuxDykqJ6rCl9TQ1wx8A9DrwzR6NpqB941FKv7wDK0lExfHQ/Db0HT5EhkDUN0/ETJdJGoKXAfn9KFtVDQ6HrnzFPj9HuW2tBvzx5/6ovvNPrDUeIbpW9imVDwDA57oveCXYC1oVxO8OVniDd0dMzP6zTMiOTxaIpAkzlOKyT8IzYKPtRlJy8d/fTXV7EditXKBJLpqNu/Q/+kpksvgg3b3s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/24 8:57 PM, Kees Cook wrote: > __kmalloc_node() is considered an "internal" function to the Slab, so > drop it from explicit testing. So is __kmalloc() and so I have the removal of both as part of the cleanup here: https://lore.kernel.org/all/20240527090127.21979-2-vbabka@suse.cz/ which reminds me I should put it to -next at this point. Review still welcome :) > Signed-off-by: Kees Cook > --- > Cc: Vlastimil Babka > Cc: linux-mm@kvack.org > Cc: linux-hardening@vger.kernel.org > --- > lib/fortify_kunit.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/lib/fortify_kunit.c b/lib/fortify_kunit.c > index 39da5b3bc649..f9cc467334ce 100644 > --- a/lib/fortify_kunit.c > +++ b/lib/fortify_kunit.c > @@ -235,9 +235,6 @@ static void fortify_test_alloc_size_##allocator##_dynamic(struct kunit *test) \ > kmalloc_array_node(alloc_size, 1, gfp, NUMA_NO_NODE), \ > kfree(p)); \ > checker(expected_size, __kmalloc(alloc_size, gfp), \ > - kfree(p)); \ > - checker(expected_size, \ > - __kmalloc_node(alloc_size, gfp, NUMA_NO_NODE), \ > kfree(p)); \ > \ > orig = kmalloc(alloc_size, gfp); \