From: Vlastimil Babka <vbabka@suse.cz>
To: Kees Cook <kees@kernel.org>
Cc: linux-mm@kvack.org, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kunit/fortify: Remove __kmalloc_node() test
Date: Sat, 1 Jun 2024 23:05:39 +0200 [thread overview]
Message-ID: <03207187-9e85-412e-98a9-1965f31b0003@suse.cz> (raw)
In-Reply-To: <20240531185703.work.588-kees@kernel.org>
On 5/31/24 8:57 PM, Kees Cook wrote:
> __kmalloc_node() is considered an "internal" function to the Slab, so
> drop it from explicit testing.
So is __kmalloc() and so I have the removal of both as part of the cleanup here:
https://lore.kernel.org/all/20240527090127.21979-2-vbabka@suse.cz/
which reminds me I should put it to -next at this point. Review still welcome :)
> Signed-off-by: Kees Cook <kees@kernel.org>
> ---
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: linux-mm@kvack.org
> Cc: linux-hardening@vger.kernel.org
> ---
> lib/fortify_kunit.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/fortify_kunit.c b/lib/fortify_kunit.c
> index 39da5b3bc649..f9cc467334ce 100644
> --- a/lib/fortify_kunit.c
> +++ b/lib/fortify_kunit.c
> @@ -235,9 +235,6 @@ static void fortify_test_alloc_size_##allocator##_dynamic(struct kunit *test) \
> kmalloc_array_node(alloc_size, 1, gfp, NUMA_NO_NODE), \
> kfree(p)); \
> checker(expected_size, __kmalloc(alloc_size, gfp), \
> - kfree(p)); \
> - checker(expected_size, \
> - __kmalloc_node(alloc_size, gfp, NUMA_NO_NODE), \
> kfree(p)); \
> \
> orig = kmalloc(alloc_size, gfp); \
prev parent reply other threads:[~2024-06-01 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 18:57 Kees Cook
2024-06-01 21:05 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03207187-9e85-412e-98a9-1965f31b0003@suse.cz \
--to=vbabka@suse.cz \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox