From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F3FC77B72 for ; Fri, 14 Apr 2023 14:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F7B1900004; Fri, 14 Apr 2023 10:29:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 980B86B0075; Fri, 14 Apr 2023 10:29:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FBBC900004; Fri, 14 Apr 2023 10:29:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 69C7C6B0071 for ; Fri, 14 Apr 2023 10:29:40 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3F6BF16033C for ; Fri, 14 Apr 2023 14:29:40 +0000 (UTC) X-FDA: 80680230120.29.A626578 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id EC5271C0019 for ; Fri, 14 Apr 2023 14:29:36 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aDekCmm9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681482577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ciNfkS+DqWy2PbM1VAL60cecuqn9PuTT/O3WDgTfYTE=; b=uaDIoudigt9kOTgepzhaYVCdjKqbflJcN1Xx6g+/DPvTcMyhCIZBpJCyKzjvmyFYNFccN8 ZoiY4PZUq6TSj6zFyduj5au14otzeKth14lymUSXYzuG6lxPDgv1HijkT29mYIUaN/lBV4 ro6DKTMZl1bpFT8np9abCxMv+sCzECk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aDekCmm9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681482577; a=rsa-sha256; cv=none; b=Bwdm6g1Mp/seYiTjBbZNG7W9VkiQ4beGwR6BRmpU1JzlUxp6M5k3CmqVkBNe4oFncSjR3k gUjJHIfNuQicKKBem6pMeh7biedyvADZJfylK++mwiU6zBHKRmy7ALq5SJ2vz7thVNFloN EytaFPNriVDGDPBwJSt0WIgrR6HbLoc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681482576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ciNfkS+DqWy2PbM1VAL60cecuqn9PuTT/O3WDgTfYTE=; b=aDekCmm9SmvVEk0ySrICT0hO/ZDr6X8m5hAFduBYqrUY8lqrNqphBdeR4T4DnOc6e3fZj5 yJ1VLrLc1cworLTHHIgL38UROlJV8zV9HHqY7jQZMMHPrG1B/3OD7oeThpEh+TocuKACn0 ahgxxi6Jqsj5T2AVxET7wRUzhOAxNGk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-Pe1YK7RzObuIw3VXkrGacQ-1; Fri, 14 Apr 2023 10:29:35 -0400 X-MC-Unique: Pe1YK7RzObuIw3VXkrGacQ-1 Received: by mail-wr1-f69.google.com with SMTP id j25-20020adfb319000000b002f70ae9c545so663149wrd.22 for ; Fri, 14 Apr 2023 07:29:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681482574; x=1684074574; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ciNfkS+DqWy2PbM1VAL60cecuqn9PuTT/O3WDgTfYTE=; b=Sp7w6HnKmG9c5pbdFrpLXpC5JIMJWJVE+QwDyHgCLMl3S6ylp2cy5XGKz3PV+gSOUD 2FeQ+W2RdH8a78ZeTfnZDFMUDFbB8Ku15EsImDXaox205MSRNUxbBRHr41kBprsmPAO/ oLLmnCyL2d1uZ/WLJtISwQu9oMNDMwZEywiTGe6YM/C2mWUfoBUTHmmDRq0ityr/s1Dw C/e5uPz8z6KGsSb63GaBGYC5R12OgTsjAylvo5xUqmrBZprX3CYFdsEOFhuY+TOZ2dO4 e6mTxspPp/N9rVkDniEh1Zw3BdgXkebUP33D991RcJ/rgqhNkgQKpj76f8MpHtFfpxMG e1og== X-Gm-Message-State: AAQBX9drRvf/c2rBzINKEtHlb7BfVPo8jezfC0DQ0elfX+YBYkYrFqyj fc+aj3Qh3Kp0Xd31illfQp5HDv1UkwVFBl8LafAJAqR4qtPMClQ6r/OpPGkYdNcseMooL649VQT YDUTBMlPrqLA= X-Received: by 2002:a05:600c:c8f:b0:3ed:2346:44bd with SMTP id fj15-20020a05600c0c8f00b003ed234644bdmr3977786wmb.19.1681482573909; Fri, 14 Apr 2023 07:29:33 -0700 (PDT) X-Google-Smtp-Source: AKy350bI78tIuL9jBC1nxSwxc+mv+j6jNyVJ4ARXBJ1W0tmFVvNnqFckPh69mrWIuRNpCcRLhpWjsg== X-Received: by 2002:a05:600c:c8f:b0:3ed:2346:44bd with SMTP id fj15-20020a05600c0c8f00b003ed234644bdmr3977775wmb.19.1681482573551; Fri, 14 Apr 2023 07:29:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5700:cb5b:f73a:c650:1d9? (p200300cbc7025700cb5bf73ac65001d9.dip0.t-ipconnect.de. [2003:cb:c702:5700:cb5b:f73a:c650:1d9]) by smtp.gmail.com with ESMTPSA id c9-20020a05600c0a4900b003ee6aa4e6a9sm8242103wmq.5.2023.04.14.07.29.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 07:29:33 -0700 (PDT) Message-ID: <032003fc-997e-4dad-84d4-1590aeedc8ff@redhat.com> Date: Fri, 14 Apr 2023 16:29:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 5/6] selftests/mm: Rename COW_EXTRA_LIBS to IOURING_EXTRA_LIBS To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Axel Rasmussen , Andrew Morton , Mike Kravetz , Nadav Amit , Andrea Arcangeli References: <20230413231120.544685-1-peterx@redhat.com> <20230413231120.544685-6-peterx@redhat.com> <1a2544eb-7d42-eda3-fafa-9bed1377841d@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EC5271C0019 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: wx8bq8iidpwqqdkskx7hju5reuqncsty X-HE-Tag: 1681482576-643375 X-HE-Meta: U2FsdGVkX1+InSrlg+ugMq0MkcfOwZA/B6PFb1SyBoIJvmYnVmSaFYZcXDIPAkK7oufoRe37Ic7U75wXsFE3Caq18243x4xK32HGYFR2vh2UTXjNoQYLNWFC7Y3E2/Yqri468zFyjYQWshU7ScPA94Wredj+XvCshytd91exE3YvUqHVOSzAu0JgZBbUSuI6Hu88AFGRfVcx0tX8jlyvidM/mBGxue8EXHBT3f6fVK7UiZDlu3wf3UV8DL69MnsPZdJV/w74thn8u6oONmNdsnXoyUi4nm0L/B7RyOm/3I7gcgMvhLJs86pUZu570XkNIigb5uVGfQG9zrJ/9yZiAGJ4BRkLK+IXoTaXSZRsetXttDg2ouFr1w8I2mqEqwd1gpDulsqwQ9PLXCqZL+PR3QwsasqyCpi3PUdBq89ph28QlFFYgYWDhPPP34aX9G7xnMLnBbjBTZHWMBwCOi4GFcYkrPgluTN9qVSIPePGOeNdvvQIha9foJEiilUGtu9g/RWnEw2DP6+sT4tIYrBvPCFH0yOgRP14eM9V9Zz0S7yy3b3kMjXe/7bBBbikz6IHw62mcGxBQizhsSe4V6ia9b8oiJdgzGk8TZozcMc7Q4XCOhGYHqF0mEKaoQckwud3893dVQJ0n3tqlKtygl+gE6gqtCjR7M9gAmFIa2D3QxTcdJYrH+kxeHR2dFxw4B9k9jvxW/rOjAnKjqQWn9hqXYGw3kGAZgZk4SHCKsNX+nXSjZeLZEEZy/wU2g344C+vqaJAdfPpRKnLW7v3SaPx5bjg5WT97gxRN/p+MbtLY9H3JfWSsehgYsCynuRhAjP0i5q0sSlCHsgyCaE3bOZFpOO4Bghf4O9IpUDWoUmShq3BhMyar9vbS0okO+jYOV/wHzZVWGNJg8W6Pr9HFy+6IHKgnt1obsfxX4KM9Hgqebg6uanNmhs8HJXrIbsgC7L0v8CthupqzPXBcAr6eiD Dg49NuZL CivaKmqvFWxj/ClBTOZ8Q+nn+8yzM5wPkTxERsHja9oVL0NYoyK5oyUwAshJQOERKTqe20JSSBmRog/7K9t9Gk7sEJkLQLltg+kpcOuRQmOVj1npV/zysHZIm5nQ3caGjISuekqy15jalGmW3wdVd8xWCGr6Gu96CdZaZ+R2+/F7sCLr3ssPETs6h9HUCDOzbiYkSJbzUklVsmjEdSVIZIJB4oEX6Wmaj7+yQpO8KltemTHOhgZS2MOE+cwo9AQVwpH04A4FfrZqThfMZg9DI2F99HHNX5ojbjHSpUzR8m9hngvXbYt0Hd/cynaRljE55JvZqj5AaHP61Cq+OkloS2Rlv+mGtVtpAgGmFPoGG+zxSryQBB3kejj7yg8s17pAn22GZETld70o2kZrHSlKLVdsUN6WINPedtdWfijkhsv/jTzt4B/a1z4n0AuA8bqrEkf7CAwhFYE1Y5iWwr3lu2fhOiJjnsXREL0WtaAX3PLBmBFmbpxs9D8tiI4ML2LP7uulzb6lcpeat1nxFY+/udr9YfW2CZ8OMKGhM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.04.23 15:56, Peter Xu wrote: > On Fri, Apr 14, 2023 at 11:52:40AM +0200, David Hildenbrand wrote: >> On 14.04.23 01:11, Peter Xu wrote: >>> The macro and facility can be reused in other tests too. Make it general. >>> >>> Signed-off-by: Peter Xu >>> --- >>> tools/testing/selftests/mm/Makefile | 8 ++++---- >>> tools/testing/selftests/mm/check_config.sh | 4 ++-- >>> 2 files changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile >>> index 5a3434419403..9ffce175d5e6 100644 >>> --- a/tools/testing/selftests/mm/Makefile >>> +++ b/tools/testing/selftests/mm/Makefile >>> @@ -161,8 +161,8 @@ warn_32bit_failure: >>> endif >>> endif >>> -# cow_EXTRA_LIBS may get set in local_config.mk, or it may be left empty. >>> -$(OUTPUT)/cow: LDLIBS += $(COW_EXTRA_LIBS) >>> +# IOURING_EXTRA_LIBS may get set in local_config.mk, or it may be left empty. >>> +$(OUTPUT)/cow: LDLIBS += $(IOURING_EXTRA_LIBS) >>> $(OUTPUT)/mlock-random-test $(OUTPUT)/memfd_secret: LDLIBS += -lcap >>> @@ -175,11 +175,11 @@ local_config.mk local_config.h: check_config.sh >>> EXTRA_CLEAN += local_config.mk local_config.h >>> -ifeq ($(COW_EXTRA_LIBS),) >>> +ifeq ($(IOURING_EXTRA_LIBS),) >>> all: warn_missing_liburing >>> warn_missing_liburing: >>> @echo ; \ >>> - echo "Warning: missing liburing support. Some COW tests will be skipped." ; \ >>> + echo "Warning: missing liburing support. Some tests will be skipped." ; \ >>> echo >>> endif >>> diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh >>> index bcba3af0acea..3954f4746161 100644 >>> --- a/tools/testing/selftests/mm/check_config.sh >>> +++ b/tools/testing/selftests/mm/check_config.sh >>> @@ -21,11 +21,11 @@ $CC -c $tmpfile_c -o $tmpfile_o >/dev/null 2>&1 >>> if [ -f $tmpfile_o ]; then >>> echo "#define LOCAL_CONFIG_HAVE_LIBURING 1" > $OUTPUT_H_FILE >>> - echo "COW_EXTRA_LIBS = -luring" > $OUTPUT_MKFILE >>> + echo "IOURING_EXTRA_LIBS = -luring" > $OUTPUT_MKFILE >>> else >>> echo "// No liburing support found" > $OUTPUT_H_FILE >>> echo "# No liburing support found, so:" > $OUTPUT_MKFILE >>> - echo "COW_EXTRA_LIBS = " >> $OUTPUT_MKFILE >>> + echo "IOURING_EXTRA_LIBS = " >> $OUTPUT_MKFILE >>> fi >>> rm ${tmpname}.* >> >> Reviewed-by: David Hildenbrand > > Oops, I planned to drop this patch but I forgot.. I was planning to use > iouring but only later found that it cannot take RO pins so switched to > gup_test per your cow test. Hence this patch is not needed anymore. > Yeah, it's unfortunate ... I briefly thought about adding R/O fixed buffer support, but it looked like more work than eventual benefit. > But since it's already there and looks like still good to have.. let me > keep it around with your R-b then. Yes, makes sense to me. -- Thanks, David / dhildenb