From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73E5BC001DE for ; Tue, 15 Aug 2023 08:42:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D394D8D0005; Tue, 15 Aug 2023 04:42:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC1338D0001; Tue, 15 Aug 2023 04:42:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B61BD8D0005; Tue, 15 Aug 2023 04:42:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A272C8D0001 for ; Tue, 15 Aug 2023 04:42:30 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F0331A0C8D for ; Tue, 15 Aug 2023 08:42:30 +0000 (UTC) X-FDA: 81125697660.24.5A3BE31 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 6A73DC0005 for ; Tue, 15 Aug 2023 08:42:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692088947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKyCbAJF2sHNIgjEY+s/3LDmLzHSrKKRYynpuK0Byac=; b=dEU3mmSJVzTpnOt9MYSsFT9TRLK7ttsr3u5aV2toLVeYLTkWvOTLfXNf0bSfygq5MMl7et J8dajUZxutnAexp9hZ6nDbIE4l4dhg87n8ryEHmAapor/Mf2RwluNysftSXDjVT1j/gNac 0w3Lvohy4qFGXkCb/pxWw8GS5042HD4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692088947; a=rsa-sha256; cv=none; b=wxmQZzhJc/Oq/3sxw+w0e5Y2TTD4D+SqOmd0XLzw+/9cac/Y4W9U8yXq8k0ngQ3WWq7FiP dkJU7NjRlFm8oqrWtXzRvfBzhn5Hjorg+oKQ5J3Uii/thKp0FXub//6Hfriq3tkNgjF2lh vBUFzE0GyrxQkT2dHBYAdUN7eJmkEos= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VprFnC0_1692088940; Received: from 30.97.48.59(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VprFnC0_1692088940) by smtp.aliyun-inc.com; Tue, 15 Aug 2023 16:42:21 +0800 Message-ID: <031fb6f3-4f5b-2b3b-bc12-afa3d10ae0f0@linux.alibaba.com> Date: Tue, 15 Aug 2023 16:42:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 5/9] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> <20230805110711.2975149-6-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230805110711.2975149-6-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6A73DC0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wunfcgjupkdsnuoz7qfzm549kq9m5k4d X-HE-Tag: 1692088947-43295 X-HE-Meta: U2FsdGVkX1/ChWJ/MRYcDUVtgJ5V3NUjoJ9jKwY8sA0XAbT/83ABnCOHXO4iDbTY76OAd4jOZ82+afhkjoik7d9wK+MppAY1S+CHPbX1goWJt1UY7r7VGReCYh3Tk/OCYg1V5H5alH1SSYiEZLSoh6pcI6npiKN7WXY+dyqLPo7Rv62ErwxeNzZE20DY44DpPuFnqXkSj4WbPs9xLLxdgPW4cLamMwGg+Nv24naQC0wTWy5BVRCBfo0NVGbVNtk/0CYtLyP1YhFVbJjGxj1hC9/E+YY0Ecnmz/eaIkHJRWF2+H0N8OMrzkunB6OrVMRNCA3FTQ+gai3ehEVWR0kD8HjyaNcA/Fm8NRovnpCQtBBnxbDXVlWW+cJenDHReRMpmBqZ/TJ3pQLw/YcqRj/+m6Z4mDy09/3TAS7l3gcdmHrZ6NL94nM14NI+krRE+KtoVDykfauhd8CWvmlu0lvmUJTXmVhkio6MEMPPO3YlC4qVPsd73O9ZDPkcBASDA/g0QaTx5se+OTlWUo8Gdju/UfzkAPAF9LzAL0s3EBuOfjrHbhLG1V0ChP5vEC/Kr8IAQQiE7Ar1R8JIur9g3VMwPAQ/uAOLMity+mTcqTaYGHCyv/CSvae923eVJBFZjBkmucT+0l+p5ENuW7cxSUXQ70aL9IEjbfSaWDNLyy6CQ4wzOuziKi92CdjaQjguTFFZ9karPSyQ4vs7w5MBhPKbHYTPkHCifkX6uRyuVreKzApIAcDFjDKnvfX8jXXC3DX8layUAEaa+pLkjbgkIgo2e4+2WZOCTb13QAH03NjhYyvVPKtCEa+jxbAenbOgk5Za8Bmfj+QA2FaN+nXkUqeh4bwiRJaMzL+QZKDyugMWzW5CGNGv9ecwkUCxAS6C9xJYksrBabU5W8sT3AS0GEwAOmXIEdJRRABJ9elT6MSWEZVm0VZJbp4+NCMjpqj+W0cYbe4KOCvECcWOHiTcC/p P63z0U4X Pj3E8DLmrS2YWvWfIBVs2g6P3dWplVbHbEhWPp2piPK1FJmuSRI1oDu9ABvPOYq4Ryfl4vgitzqDFSHC6DA50Kkh7NBuG4A4m7dfMmnR5CgIhw8CI93n8PC5Csoilq7Nm781/T1y/32LMFWX+RaOzgiZWLL2QPmbixO0s/y35CfIi0vY7k9sEKA8u2AlPWbIDBqTy9ow5Qk807rMNZoEGua5ngw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/5/2023 7:07 PM, Kemeng Shi wrote: > We have compact_blockskip_flush check in __reset_isolation_suitable, just > remove repeat check before __reset_isolation_suitable in > compact_blockskip_flush. > > Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang > --- > mm/compaction.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 8d7d38073d30..d8416d3dd445 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -434,9 +434,7 @@ void reset_isolation_suitable(pg_data_t *pgdat) > if (!populated_zone(zone)) > continue; > > - /* Only flush if a full compaction finished recently */ > - if (zone->compact_blockskip_flush) > - __reset_isolation_suitable(zone); > + __reset_isolation_suitable(zone); > } > } >