From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68872C77B75 for ; Tue, 18 Apr 2023 07:10:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4FE58E0001; Tue, 18 Apr 2023 03:10:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D005E6B0072; Tue, 18 Apr 2023 03:10:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC8028E0001; Tue, 18 Apr 2023 03:10:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AB7556B0071 for ; Tue, 18 Apr 2023 03:10:12 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 858DD14016F for ; Tue, 18 Apr 2023 07:10:12 +0000 (UTC) X-FDA: 80693637864.13.91B9930 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf21.hostedemail.com (Postfix) with ESMTP id 13DF61C0003 for ; Tue, 18 Apr 2023 07:10:09 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=so4zQ8Ew; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+8hBlk8y; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681801810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dRH3eWeEGHDvPlwB5o7ZP/I1WDLHJ6RIIKKJIQqdE1A=; b=Nc5uyQWyhLGRR5cKMrXBxjCswrebqLyU6no6+6sIG7ufce/u4q3ydtFldEcG4Uik8rLz4X WROV+FRSoRonedHu0VkwFSdXELDVjtc102ErK5/Y1fOKEUHSjsP57TGyzfwxT97rSn1sYP azB4IxoOJhOC22nY/nx4t1Ah7tQGMRE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=so4zQ8Ew; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+8hBlk8y; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681801810; a=rsa-sha256; cv=none; b=wpzADIbllUwOdckjgpuxrCcH4kemolWes7WwpPovAwskFvALG4qoADiICvz+j419zjNj/7 jvjCoN8Cak2rJwOmrRUBqxqmqwbPti/xfl9azMdXurz8BuKO0p3qp/bLJtcZcafNkDtfkz OtFLZpgjlAyJOBN1GkJgCNLpG0Txc/w= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2EEF81F8D6; Tue, 18 Apr 2023 07:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1681801808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dRH3eWeEGHDvPlwB5o7ZP/I1WDLHJ6RIIKKJIQqdE1A=; b=so4zQ8EwJgUkGF0MgCPwmVLb9bk0I+asMlVdVPpISErxSfb+i83YtveAq+Qi0DGZ2iMlAk 9vyBCNCEW79KiKHD3UTvHqW3hUx7n8mJCgmVTplSW2euEhf3zB1ABtT6lW/GnKILOvu0Gh KXaKBZlDDHmFIOjj4IMYvG+fUi1SXw8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1681801808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dRH3eWeEGHDvPlwB5o7ZP/I1WDLHJ6RIIKKJIQqdE1A=; b=+8hBlk8yQAjosdSue4bgIic8LNRi4fkdwOZEOBroGaWoymfQN+3Q+JKjQ1AEnzilwO5ee9 tfWOHNTJw7ncFwCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 06A0B13581; Tue, 18 Apr 2023 07:10:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HTvXAFBCPmSZWAAAMHmgww (envelope-from ); Tue, 18 Apr 2023 07:10:08 +0000 Message-ID: <031c79dd-1927-0d81-bfef-6dc64adcad12@suse.cz> Date: Tue, 18 Apr 2023 09:10:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3] mm: Fixed incorrect comment for _kmem_cache_create function To: zhaoxinchao Cc: akpm@linux-foundation.org, bagasdotme@gmail.com, cl@linux.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com References: <24a0219d-b0a1-8b81-ff98-2fff107650c3@suse.cz> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 13DF61C0003 X-Stat-Signature: thtkwzzr14c9y33mbsez9jgf83ck54op X-Rspam-User: X-HE-Tag: 1681801809-393278 X-HE-Meta: U2FsdGVkX1/biK/lwcvwv4SMkPJLCArco7ibykxd5zJpHC6pZpTUhIUaaD/HMHmgaDlJHn3UbxNI5HLUyAsDuWYO4AMN1VWgwiYfERnsWgG/Ecdk1uKfC+4dg7wPe1rP8zluxHLaribUvzhS/X/izWXfguE4B13dOnPQgiS6sNjRbEeST7FRcNKlbT5UYbjr0PbCsymCqEF1dwWKgANuZs/BusJbKRnCJzADJkq+UHXQFRKir0gQCTWaFXSzRZmX9I68/ny0aNe7KHcYOBi7t9tUQ566iYqs/U1qhrfgyB3Qrb3cXf9wfnicJJA6EjeGABuRcE5LNgao8/prY0LvXLjRbdDtzmnAW9+w8dgz9Qt3RdmB7LdaUZodFUmfdDNm9SLRSlkmf82Q3Bn95Yo0y0H5HPBmpmIJRVTn62o5NxS4CtFkeSdmUmho5f0K/zs70XsGsI1AdpSRhQ+rzSNR6dSCw4I4CXhsrmMay+4uX84h3MdfTnxJ/s2LWx0OUcRW98xVf+0JMhkUHMIZUQlRgjVPz4VbCtsDInTkcBQxiCHgin0qNCiBifX7Lj4wB+FxXlKuyLMGi7rOimnV6bSN6GFOB+Ry4LbR78p0q9cb3bkO6kcYX8R4dWPnTdnOFleeQdDXzUZM2VGTMtp+5dSZV9dN4XYe1T8SpVoVIc7LzX4ovAiWJer0x1ez8MMQnjYsetYK8wEyGwP1UOCwM3xHWZ9waSMUi2unAyMqQeE8TvmLdN/+9ijs/0v5Os4/v3KNtik7MIm3C0Qi3qC9T9Mu14kzU4b9SfeJb+BuBx8uF8cCUVVeCSl81dxnISZaSPB3vjaFDhI+Bl1uL5gFToqJJ+ZbaY/jdLFqkPZXaZP6vDfutg1gA+/PiY/a7UJcSyH+A8es4q1E++QcJPT8Vt4ArBanJi2oPTBPV0FaT25uJxV76XZdCVLP0UqEYJ48/DdhBuVEJ2ohwXXSoUQDaNW vTMgTM/x Ggwfwzvicfcopbx0zT18v54v+tcLHTdjkFH7hETB+Ic8xI+2fBdkkRmIZgdhdBbuMMrBEkvdXDib3VcaCaZXcyByVBt0cr1X6GExPQw7qqQ8BtDeDudZQXeYxm4orS7ZyIX4+NBwtdzyoy6RtLtkUQCBEJKRIQgPzWTMEwOdSsfgvYTEc4VTdW+mlQQls1OHT/CRmjC4vSUfarwr7jpMRZDaZ3py4x47jYx83o+/KZRB44REmXb5oH7YRZ+ohzJi3Zdtcd+ol27D6J5lkch1lvCSvhCyHvbUl+M+j+A/ySukUE2q9kdwmYYPoRErYCLANP8KbIAPptBdJPEOxg1ggnV3pYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/18/23 04:05, zhaoxinchao wrote: > From: zhaoxinchao > > Actually __kmem_cache_create() returns a status : > 0 is success > nonezero are failed. > > This function has three return positions. In addition to successfully > return 0, the first failed position will return - E2BIG, and the second > position will return nonzero value for setup_cpu_cache function failure. Adjusted a bit. > Signed-off-by: zhaoxinchao > --- > mm/slab.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index edbe722fb..ebd326f07 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1888,14 +1888,17 @@ static bool set_on_slab_cache(struct kmem_cache *cachep, > return true; > } > > -/** > +/* > * __kmem_cache_create - Create a cache. > * @cachep: cache management descriptor > * @flags: SLAB flags > * > - * Returns a ptr to the cache on success, NULL on failure. > - * Cannot be called within an int, but can be interrupted. > - * The @ctor is run when new pages are allocated by the cache. > + * Returns zero on success, nonzero on failure. > + * This function has three return positions. > + * In addition to successfully return 0, the > + * first failed position will return - E2BIG, > + * and the second position will return nonzero > + * value for setup_cpu_cache function failure. In v2 I recommended dropping the detailed description. Removed it when merging. The result is merged for 6.5 here: https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/log/?h=slab/for-6.5/trivial Thanks! > * > * The flags are > * > @@ -1908,8 +1911,6 @@ static bool set_on_slab_cache(struct kmem_cache *cachep, > * %SLAB_HWCACHE_ALIGN - Align the objects in this cache to a hardware > * cacheline. This can be beneficial if you're counting cycles as closely > * as davem. > - * > - * Return: a pointer to the created cache or %NULL in case of error > */ > int __kmem_cache_create(struct kmem_cache *cachep, slab_flags_t flags) > {