From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E711C77B75 for ; Tue, 23 May 2023 13:47:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E49C2900004; Tue, 23 May 2023 09:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFA46900002; Tue, 23 May 2023 09:47:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0F98900004; Tue, 23 May 2023 09:47:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C26FE900002 for ; Tue, 23 May 2023 09:47:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3C002805BC for ; Tue, 23 May 2023 13:47:43 +0000 (UTC) X-FDA: 80821647606.11.41845D0 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf07.hostedemail.com (Postfix) with ESMTP id 2D86540019 for ; Tue, 23 May 2023 13:47:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684849661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qPIC87J5g6JTgg3jDwQGsxHZEhqjigQMZ97ARBJTSvI=; b=Wy3T+jAlc5kdFdVQxcYGsCnp0whTU+m3XQqeyKTpkpqqB7aphdk/sX43JllLviiQljoaGA vkTJg3tzJnYTalYgVDa3MgpDw5UBshoB+mlriMTpjAcpvhsJWbfSpCwihDiY89lBQkZJzX QKtmaqxZvcZ18oZj+CkMmr+u64WlJV0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684849661; a=rsa-sha256; cv=none; b=2cYtKIwMyxbU7ITAJGoTX6/treNj/52Z8ezxTK6REFWzXCYgQLTXoEEL2YYANexpKIb3G2 5gnpvpyEQ9Iu9+iAr9z2p9BqkwDq1E7fHxx+w0jKhekEBPGIAYo42r6vawr50KrZ6Jd9Dj nDQJs0E0z1nyuPDMG4D79aGutHMQRq0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R741e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VjKTIpJ_1684849653; Received: from 30.0.185.76(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VjKTIpJ_1684849653) by smtp.aliyun-inc.com; Tue, 23 May 2023 21:47:35 +0800 Message-ID: <0318d80c-4a4b-41af-1005-75947ba510d2@linux.alibaba.com> Date: Tue, 23 May 2023 21:47:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 0/4] Follow-up "Fix excessive CPU usage during compaction" To: Mel Gorman , Vlastimil Babka Cc: Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML References: <20230515113344.6869-1-mgorman@techsingularity.net> From: Baolin Wang In-Reply-To: <20230515113344.6869-1-mgorman@techsingularity.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: twpjzqi9o4qritz9qpkrqiuqzew41et5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2D86540019 X-Rspam-User: X-HE-Tag: 1684849659-721957 X-HE-Meta: U2FsdGVkX1/7ZOGuFFiVoOonDGE6mA4fG6CTZM9CiCoSmgYew5G+uy/BOboPgQaIc651PZOi7rn/rjOE3ockov62H6c3WlSGZDgr2jLLNpL7HDymKAvHryACVcN+DsFnvb+zWWHfGu5QC+xkJwTnrgs93XndsYHTAhP6JJ4Ww+Z5vZR7i+ix6eFeaE1XV8UQLmg9RBzld9u9pPZzZeuxJiHK0G5O6kCgiqJGe0lNyRH5xujPacs7eMSDA9BOnhodVwSDBbyiLITx/7FQqgg8PxmUkbKspimXBtuStf+OLMkJ/UuKbdjI7MTQ26icIqWq1cM+6eoTByf7XU4w0nzxcSkAAhCaQxGTtp8JJ8SCDtaCJ1vv0L8wk/r78ddD1nGqKvs41TfBXwb79eL12pXZ4RwJ0daGxXrv6ftPN4SMmO7IkpLXkbPk+qMgobPzR++Jo0TGHvct0mM0dQedYTsTtxTP/OtD2mAaUZy7M9QnNkFDlvhXFrfer47d5jgWojmPJlMnnOQTNuGfIbv8ZJ9wzB30cTCbK5p84yyKK87j1m/ZzTFisqrv+5jv5JrtsI5ipNXnR6XrgIYeFBYX163UsGfFFV02Nfo274PiL7ouiO5S4RmRETd8IkMgRBppF/Z9CusF+eF2yv1I6PdrL41a9s3jiRpjOXiRoajQGN96zfRd3xNzr0HWI1Zm6WBtBKvx2WP8UpTX52uIzG6wtwK2jyWiocz84WVq7ELXZMw2tedkIEuXUC7SfKQrVvNPiBvjvtYZOFmAjwwt2nIS+yieUEMlEQkhVK+RLaQtCdiB/XTkjAP7PWJ5Ct9D0VHHSbyMlveSQKjsqJWDAGPN5dYmrYqL+gbXejaHQ94SH1gUIBdbA3tu4v7MDF4CowvxAdw44FaBlljKOE/+wUKqDSONhmJu+LixaND6tuXcEN6PZZOpOQw/D6j4C1Jtzzto/f9q3CSHxb1efXJzFIOwlPc oM3bUg3z 77bh3ZX8NpOa7fyUPdqnJBLoc+pSZJQ3+//6hLxAtw437i6Nh7vnmwRuY/YiWykBjPyIzeHjg9qwv7/Ypj05xjB8VbWERbo9AD2wLyiosimrr0OOMML8EUbJd+XwQCmSafP1pxNcSBi+cryddpx36qQcSHWxf/xphxsJTMrZng2Wd+d9HHeK6435swxoH86Nd7GuLBZpZNzaCJWeRa4DVHPw4zdY4IkxGR+oNE2o7I4ZtE3Yg47xyYFut8YpdGFx6408ADhFFXrPADN9dvtgFalnf0nXZQHXP8IQtq0Mp/ZG+eGJ84oBCAEd8QqTKjuz1MKvgaTWTRQT0I08NAXlC+nE/cpuSpjbPtxb+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mel, On 5/15/2023 7:33 PM, Mel Gorman wrote: > The series "Fix excessive CPU usage during compaction" [1] attempted to > fix a bug [2] but Vlastimil noted that the fix was incomplete [3]. While > the series was merged, fast_find_migrateblock was still disabled. This > series should fix the corner cases and allow 95e7a450b819 ("Revert > "mm/compaction: fix set skip in fast_find_migrateblock"") to be safely > reverted. Details on how many pageblocks are rescanned are in the > changelog of the last patch. > > [1] https://lore.kernel.org/r/20230125134434.18017-1-mgorman@techsingularity.net > [2] https://bugzilla.suse.com/show_bug.cgi?id=1206848 > [3] https://lore.kernel.org/r/a55cf026-a2f9-ef01-9a4c-398693e048ea@suse.cz I've run this series on my machine, which can solve the regression I met before [1], and no other issues found. So please feel free to add: Tested-by: Baolin Wang [1] https://lore.kernel.org/all/3576e3520c044beb2a81860aecb2d4f597089300.1682521303.git.baolin.wang@linux.alibaba.com/ > > mm/compaction.c | 24 ++++++++++-------------- > 1 file changed, 10 insertions(+), 14 deletions(-) >