From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F87C27C4F for ; Tue, 18 Jun 2024 07:37:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA2FA8D001B; Tue, 18 Jun 2024 03:37:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D542B8D0001; Tue, 18 Jun 2024 03:37:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCC9C8D001B; Tue, 18 Jun 2024 03:37:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9F28C8D0001 for ; Tue, 18 Jun 2024 03:37:34 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4D49B1C05B6 for ; Tue, 18 Jun 2024 07:37:34 +0000 (UTC) X-FDA: 82243204428.04.BBF983E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 136E41C0012 for ; Tue, 18 Jun 2024 07:37:31 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JekiHeof; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718696249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K8FGdsJkQW+byEQkX1yS33c/wIMs4hmfFSLxQwVoRiY=; b=rnMPTO7n/5M+Veqmxx0ZLAoN+EmTJ5D8FxoDqcHdKpdd0pvJh8huJJ10hR8MT299cSeLAE T44SsWaXe6Y/lV4frA1nfUSLpFHuAr9XvSxrgztDHtr7Ne3Rha9iDSOVkDH3Ea+eHzkUsV Kxwsl3xbdazqzcP0l+Lm0qJqH/v1zNg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JekiHeof; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718696249; a=rsa-sha256; cv=none; b=XmcN4xMcmuig75qLkRq/o7nrIrt68OtsyafA4tXm5jidYNgcwSm389zaaNo4wrbYFbb82/ rhA14j8BIXfU+EW0Jae5gEV4irJ2+HK+F4hSkduRIXdtZnvuOi4CTkxiW4PyXILSIl2HMZ eessj+7120P/GsWXPznu6yvwlKbAj48= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718696251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=K8FGdsJkQW+byEQkX1yS33c/wIMs4hmfFSLxQwVoRiY=; b=JekiHeofLytkIuzCTtHV1Ft7Zrfl2CeArcnbIXg4ac2B5UyDFtlODZA8SriADsTecYKrS2 4T1XYW67DGaBF1vGsJgs3bpMHv43bSKNuAVsIq3+XYTFtUlamjBoC1FOpm+WpJTqPkUD02 d+XynEhZ71ZGJbtuBC1lME2f2knP8/I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-K8ZJp0F6OJCS49s-14xWvA-1; Tue, 18 Jun 2024 03:37:30 -0400 X-MC-Unique: K8ZJp0F6OJCS49s-14xWvA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4217a6a00d8so33999355e9.0 for ; Tue, 18 Jun 2024 00:37:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718696249; x=1719301049; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K8FGdsJkQW+byEQkX1yS33c/wIMs4hmfFSLxQwVoRiY=; b=hPT0QKQ5vvDxEozLbRIiWd/GI0dK4qEPYPouEq5SeE+l9cjfeKN2MLs8XqDavBZ8Hn ksQte04WPxdWcoPJMP+UvQ1QNx+Ld3ODuysG9t0IPiZZ2PdKstS7whk1TIA89ZL0mNkd hhcbH1zeFGmrS6MnLDzDh/BVQ7gYU0vyZo2NCnt20P3yxkoIauV2LWfog5rUYjw+qCFG ZUSlwKuKo7OpoQesyd5VKYDfiirzJCVzzesnWnOo7rWHzgPlv9vAT5X2YiDvz6/vlHzH Gwk0PXbfm2XJJ3HZYbRuac3l2F2kkItpVnQsPKBnbZam3A/9Z2zIcZF3clij1BggYhkK 50rA== X-Gm-Message-State: AOJu0Yyw3YdMFiz9uctMr2UOsRn73c/ZSxmsch4C9yhdI42mTUYws1l2 4EqoEZQtoyDz1GkeKuFCfyEosonFYR1u3TLL2rRHJXnp+zhcgbCELrc3uhSOiYIl/MAJkgTUhf6 /JTplGJcPI60nteyysNIdoXizKN7aYi7OEdk0C2kImMJjM2jl X-Received: by 2002:a05:600c:4b16:b0:421:8060:f772 with SMTP id 5b1f17b1804b1-423bc08c155mr51871715e9.0.1718696248847; Tue, 18 Jun 2024 00:37:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfgclri3NxDFiUz/oariusZFRsh1RRo8IZxCVzJtH92orM3Jg4zKGg5HrECllAq8yhBp8d5Q== X-Received: by 2002:a05:600c:4b16:b0:421:8060:f772 with SMTP id 5b1f17b1804b1-423bc08c155mr51871585e9.0.1718696248428; Tue, 18 Jun 2024 00:37:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1400:78ba:c2d2:22a1:8858? (p200300cbc705140078bac2d222a18858.dip0.t-ipconnect.de. [2003:cb:c705:1400:78ba:c2d2:22a1:8858]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f8be0c69sm182381445e9.33.2024.06.18.00.37.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 00:37:28 -0700 (PDT) Message-ID: <030ba6a5-d3ff-429b-8672-59b7f7d44208@redhat.com> Date: Tue, 18 Jun 2024 09:37:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] khugepaged: Simplify the allocation of slab caches To: Hongfu Li , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240618014517.25954-1-lihongfu@kylinos.cn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240618014517.25954-1-lihongfu@kylinos.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 136E41C0012 X-Stat-Signature: 7yab1h7zddz41mbczsz64bg7xzrhowby X-HE-Tag: 1718696251-397876 X-HE-Meta: U2FsdGVkX1/P14Pyy+8QOmjF9//Q46lnt62yBK1P/OuwgWHrnC8C6gvdW+/IUSJeIT+pLODt3YSchjUfKEnHio/uLci+Id1gqwDcxQzaZfgpI2qZUEY2ULFZGZUOeHr9ZKtV7Xle6YUkCGiSkZTXTwDo1sFnWHe63WmAxQU+h14tUNZZuOXbBB4QPKIFJhaPI0edTceZ3BMf1m1/oDNgrpaB24DkwbpFz9NSQD08DJBCSb5dnUuJx58ui6gVjGUIl+NcQEZ64NpqhJ+9ztV8lRYay5my16wi9wApY5D9fYDbGwY/IPPeNNLapEClqyxmpLrBTod5f/ymuyhqnUbTPaxr5mGWwRvGN1wejDw2nuVzBXGkl/YoiQ54K+a7EZwBvaqgg5JY0goNjR9fDu3CiTpEk1DKa1776cd2/Q3JlsHfG63CPCt2eA2sVYtMni2/PiVeQgu+jpXZw6uP5AqZ0CmzRNCPeE6xy/pfdPcRBj1fyXy6rn0Ek4bJc3yDnGHyAcq60Q3zsBEEHckDeZmyMl1s9CNA9TvuCRvmeKyTka8g/DgvqsUddq6f95+EDq1CtzZZoQxhaO0KeH9Hu5PsoPBECuybDWOFmk62YXLjvodFac7kkLacZt2FE53tu/A7xd6Kl9noIa+A5iG3/Gbt1gbJE3P5Ch56d1kziboXeCQIkoirh3iZRhyALtN2M6V4rr0+2HLV8d7ITn5xY78eDsoPhOu+h8rnzElIl1O+jY5FxUorBixxmWnFiwEH9Y6A9nS+tYPWCctfCoG4Z0Bc7iVREQd7zH7cIdagZU5rsnJplcRBVcldHCpnzeSF2kiFozb3Lywjd66MD3YZSff5CxskGYjYwUGoHUqKOq2STeJH6qts1vLz3hJLSFnzLdpJcPeXFQ0XC9pxHsjIuQ57EIGxm5d7fur5AGMGhvd/CPqLQDDJY5d57iJkjNrsUYXMIvhGp38/IJFMk2CiemS 8H3JXtHI coOVYjnYSnAPajyZJCoua5t4Jmu+BtGnxfUswienKHa8nqfwIE29G4xTSKzpusx0u8St1Gzt184oGo2eiZOq5jcEWJy7EHYLNfA3SlxxTL55IlWpISWF2g25Qk1FTY7PxN2/PWDIcDWLyUFLCVEzKzFSYngIqaJfJnH26sqs6EWppkd26fohcIWg3zHTZLxaLa4S+zR1LlLssYLAycTxhgzdpcTXT1OLUriHsjL9U0fsvHkZcacBYzLFNm7rHlrt0qnFqTgERwDf5boQfaICbaTJq35iv3CSa6g5md+L5MzPDrvM9q6Gmw+3nTUu5J4/BLTqqf1nCZ+y+gTDjB+sJE25CUhoE5XKZumvv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.24 03:45, Hongfu Li wrote: > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create > to simplify the creation of SLAB caches. > > Signed-off-by: Hongfu Li > --- > mm/khugepaged.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 774a97e6e2da..f8d08b49420c 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -385,10 +385,7 @@ int hugepage_madvise(struct vm_area_struct *vma, > > int __init khugepaged_init(void) > { > - mm_slot_cache = kmem_cache_create("khugepaged_mm_slot", > - sizeof(struct khugepaged_mm_slot), > - __alignof__(struct khugepaged_mm_slot), > - 0, NULL); > + mm_slot_cache = KMEM_CACHE(khugepaged_mm_slot, 0); > if (!mm_slot_cache) > return -ENOMEM; > Acked-by: David Hildenbrand -- Cheers, David / dhildenb