From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4CA7C5321E for ; Wed, 21 Aug 2024 14:20:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18A2E6B0122; Wed, 21 Aug 2024 10:20:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B046B0123; Wed, 21 Aug 2024 10:20:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1C9F6B0124; Wed, 21 Aug 2024 10:20:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D32C96B0122 for ; Wed, 21 Aug 2024 10:20:14 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 40756160DA7 for ; Wed, 21 Aug 2024 14:20:14 +0000 (UTC) X-FDA: 82476462348.28.723F5DC Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf22.hostedemail.com (Postfix) with ESMTP id 3D3B1C001B for ; Wed, 21 Aug 2024 14:20:09 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724249972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Z5iou/9dTLdQeKfXNJ/QTnaTdk+jllIwNOQX4HJugc=; b=UY9IoUkKld0UbEJqnHE9570pv8u1Itp0nc87bdETpTDiCd5NQhphdPJ4HBwYW6g0ZOW2Bj bVavsDJUhpLD+7Z9IkeG31cYcGD4uHo9gLmaMOtRHQHz1e9dcahbkx2OcGRtRPrKQnBMBg PM5ovr+6mW5kNMPsU0m3pIp94tXl8ek= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724249972; a=rsa-sha256; cv=none; b=WmqzmUn/6M/nQVQ4fEL2wtWgpgwQS0489WDQncBVFNEkMl4HXFuhj8c1XrEAjbs9PHl8pc aiK5IdJByIFCeHqlELUhNlRdF31UFbnmAVgDcxbd8tD7wZ77e2n/DOOKcUGc2yAgFxWGg+ tMQktT558ySHpkzggHAXz7Qy+Ho0Buo= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WppPW1s7qzcdVM; Wed, 21 Aug 2024 22:19:43 +0800 (CST) Received: from kwepemm600017.china.huawei.com (unknown [7.193.23.234]) by mail.maildlp.com (Postfix) with ESMTPS id 0C36E18009B; Wed, 21 Aug 2024 22:20:06 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 21 Aug 2024 22:20:03 +0800 Message-ID: <030ac65e-29cb-ea29-6728-e820bc188203@huawei.com> Date: Wed, 21 Aug 2024 22:20:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v12 4/6] arm64: support copy_mc_[user]_highpage() To: Jonathan Cameron CC: Mark Rutland , Catalin Marinas , Will Deacon , Andrew Morton , James Morse , Robin Murphy , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Michael Ellerman , Nicholas Piggin , Andrey Ryabinin , Alexander Potapenko , Christophe Leroy , Aneesh Kumar K.V , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , , , , , , Guohanjun References: <20240528085915.1955987-1-tongtiangen@huawei.com> <20240528085915.1955987-5-tongtiangen@huawei.com> <20240819125601.0000687b@Huawei.com> <8257d76b-c700-89a6-0e29-f194d2e1cd61@huawei.com> <20240821122848.00004047@Huawei.com> From: Tong Tiangen In-Reply-To: <20240821122848.00004047@Huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600017.china.huawei.com (7.193.23.234) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 3D3B1C001B X-Stat-Signature: tor9oxnpa9gj99fd47qqy35poz4duktg X-HE-Tag: 1724250009-43166 X-HE-Meta: U2FsdGVkX19ArTz49jLTxd3eR8DUfo7ab/N9UNiFc6xT8UqAnnCpYuE/UbZjPlC8dkAHRRBKqe9dahz27gNtFHuz8qNSSqMnmpL9oRp7l+7fOe1v19Mp9eTgHtp7YO1+yPw2srf3XA8k2RlTiepG1bAWaEr+jZasrmrQlpKEFYBwAk5/WUGe+/4piFPWtlWq+XxQjRf8j+88VMowPYynFzIdF1xuyxbZT2WPZc4ZhBQdSRphL4LNoeC/Si6J6rqOFgZuLXKm2dJM0MPVeA1YMnWmuWS7ky/aMHeHPKEgcCJpc8gttGoYxpWmwl7Qzew/0/gpRkfqUqx3nwuvB6pSAQTmGOeo0TPtSs+sGJ/yZo0Eon3bf8I8J5fi9WEdE+ATQnoX3LjjbBKUQ7VOmtixgiq2am3M933pR+7JZTOiPVv/NQLwwwRmhuAOoc1Sewkkb+/HbzyGfgIItMyjA5aiDyM/1rrM40SJhaXBSQm002QLrCllAsP6ZddopCkNioKri8fHocV4ga5L26KXEmKZIDwm99oNXHNFbWdoVSc2ZOZaXiw6pQSkJH5VphVVriHVJHe3OfSai7ujLvXScYaFI9rnWCRLarQ9Lj95InKObKXDg2OgeEh9w2tYqdlhDjV3CEShiPDwpC7ta88EyAPT8VG71m+i21lPYqmtXbV+dqsdJ7h6NLXiTwaAjtEDUgQP1moC82YSLlXrYP020Baf/6nZzwVeXO3lwDr3Xi9VZCBL86OYO7wrc5Jd03vYrtyQF5+v//iT9cgkD0+RTEDoP6TnLJLqHdnCC3FJ7Vs3PdpxL7QGw+g1jNS+SNo/KN9OAGYkmsxzawe3xoYeDboQH+z03lRGMo8EahluCSzLg2GoUz/DAmknN/ARHw9Gh3SS3xCyHdDbnPoyVZ0g8bBns8FOt884UA5Z1gfhkC6RUhv6J9clmzAta4k4qh7xuGIG1WSEWPeh0dIBdTbRxGm LmCwh2bc Kut0dJJyLFjV1oaSyrjrpQEA7roIWwSpHBYaLWnN0f0ApxiEoyYCYXJ0u/Xe9uhuVG5RPnm6hysFzpmEi24jW98ECTOjULIB2UrZtS0jmAamiBRxXJ1F9dxh94urpxb4WIgtxLb9IyAcE2Uzkgiw7CeBLAIxvKnpl865VxJjKDzxz9fsquMSKgXPLZpvY9uJAstA9DFtsPVKyOWn88PDURktJF6639gioGfWGHbKSUb5CVR7qC84xrIrulNzlWDlvZ/0XOnZWqMehAXSecXEUSCGXPSmX5GFkub3EEJxt2piFqtu6795ZXb/NAd8eOuNgh9urxpDdCquaMd5NTfAAfH0xAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/8/21 19:28, Jonathan Cameron 写道: > On Tue, 20 Aug 2024 11:02:05 +0800 > Tong Tiangen wrote: > >> 在 2024/8/19 19:56, Jonathan Cameron 写道: >>> On Tue, 28 May 2024 16:59:13 +0800 >>> Tong Tiangen wrote: >>> >>>> Currently, many scenarios that can tolerate memory errors when copying page >>>> have been supported in the kernel[1~5], all of which are implemented by >>>> copy_mc_[user]_highpage(). arm64 should also support this mechanism. >>>> >>>> Due to mte, arm64 needs to have its own copy_mc_[user]_highpage() >>>> architecture implementation, macros __HAVE_ARCH_COPY_MC_HIGHPAGE and >>>> __HAVE_ARCH_COPY_MC_USER_HIGHPAGE have been added to control it. >>>> >>>> Add new helper copy_mc_page() which provide a page copy implementation with >>>> hardware memory error safe. The code logic of copy_mc_page() is the same as >>>> copy_page(), the main difference is that the ldp insn of copy_mc_page() >>>> contains the fixup type EX_TYPE_KACCESS_ERR_ZERO_ME_SAFE, therefore, the >>>> main logic is extracted to copy_page_template.S. >>>> >>>> [1] commit d302c2398ba2 ("mm, hwpoison: when copy-on-write hits poison, take page offline") >>>> [2] commit 1cb9dc4b475c ("mm: hwpoison: support recovery from HugePage copy-on-write faults") >>>> [3] commit 6b970599e807 ("mm: hwpoison: support recovery from ksm_might_need_to_copy()") >>>> [4] commit 98c76c9f1ef7 ("mm/khugepaged: recover from poisoned anonymous memory") >>>> [5] commit 12904d953364 ("mm/khugepaged: recover from poisoned file-backed memory") >>>> >>>> Signed-off-by: Tong Tiangen >>> Trivial stuff inline. >>> >>> Jonathan >> >> I'm sorry, I may not have understood what you meant. Where is the better >> place to do inline? :) > Oops. All I meant was: > > My comments are inline - as in within the patch later in the email. > OK, It's my fault for not getting your point :) Thanks Jonathan. > > > .