From: Song Liu <songliubraving@fb.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Song Liu <song@kernel.org>, bpf <bpf@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
open list <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
"imbrenda@linux.ibm.com" <imbrenda@linux.ibm.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>
Subject: Re: [PATCH v3 bpf RESEND 2/4] page_alloc: use __vmalloc_huge for large system hash
Date: Fri, 15 Apr 2022 16:57:01 +0000 [thread overview]
Message-ID: <030EA68F-EAA1-41C8-B7FA-0675B118F0D8@fb.com> (raw)
In-Reply-To: <YlkRY8QfAdNk+Oso@infradead.org>
Hi Christoph,
> On Apr 14, 2022, at 11:32 PM, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Thu, Apr 14, 2022 at 12:59:12PM -0700, Song Liu wrote:
>> Use __vmalloc_huge() in alloc_large_system_hash() so that large system
>> hash (>= PMD_SIZE) could benefit from huge pages. Note that __vmalloc_huge
>> only allocates huge pages for systems with HAVE_ARCH_HUGE_VMALLOC.
>
> Looks good (modulo the possible naming chane suggested in patch 1):
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for your kind review!
Could you please share your thoughts on shipping the set with 5.18 (or
whether we should postpone it)?
AFAICT, the only changed behavior is to allow alloc_large_system_hash
return huge pages for size > PMD_SIZE on x86_64. I think this is
relatively safe, as this is only for large hash and we are at rc2.
Thanks,
Song
next prev parent reply other threads:[~2022-04-15 16:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 19:59 [PATCH v3 bpf RESEND 0/4] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP Song Liu
2022-04-14 19:59 ` [PATCH v3 bpf RESEND 1/4] vmalloc: replace VM_NO_HUGE_VMAP with VM_ALLOW_HUGE_VMAP Song Liu
2022-04-15 6:31 ` Christoph Hellwig
2022-04-14 19:59 ` [PATCH v3 bpf RESEND 2/4] page_alloc: use __vmalloc_huge for large system hash Song Liu
2022-04-15 6:32 ` Christoph Hellwig
2022-04-15 16:57 ` Song Liu [this message]
2022-04-14 19:59 ` [PATCH v3 bpf RESEND 3/4] module: introduce module_alloc_huge Song Liu
2022-04-14 20:34 ` Luis Chamberlain
2022-04-14 21:03 ` Song Liu
2022-04-14 21:11 ` Luis Chamberlain
2022-04-14 21:31 ` Song Liu
2022-04-15 19:03 ` Luis Chamberlain
2022-04-15 6:32 ` Christoph Hellwig
2022-04-15 15:59 ` Song Liu
2022-04-14 19:59 ` [PATCH v3 bpf RESEND 4/4] bpf: use module_alloc_huge for bpf_prog_pack Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=030EA68F-EAA1-41C8-B7FA-0675B118F0D8@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hch@infradead.org \
--cc=imbrenda@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox