From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B924C3ABDD for ; Mon, 19 May 2025 17:41:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16B3D6B00D3; Mon, 19 May 2025 13:41:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11B536B00D4; Mon, 19 May 2025 13:41:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB28A6B00D5; Mon, 19 May 2025 13:41:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CA9BC6B00D3 for ; Mon, 19 May 2025 13:41:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 09F281A0BAA for ; Mon, 19 May 2025 17:41:36 +0000 (UTC) X-FDA: 83460374592.27.C5097E4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id A99738000D for ; Mon, 19 May 2025 17:41:33 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JVHKSDoI; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747676493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wMM+2s7qRrI63vS75vOPvvwet4wpZHCqIEycJ3tkwcQ=; b=I0qq75l6I78FVbqTV+qNqqUCxF+wyaiWdMlIBk7A8/K1+/5YOnYJYggJA4cX5fBBEHKEtK YK8cZ54PNJ8xS91urU5Bcmn2lw0OARk6nLC1o7bNIhWiPYZFztX5vLHknzMaEMNoPi02+O QxV6OmWcjDlrAvHPcGgZqZhOeiBxO3U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747676493; a=rsa-sha256; cv=none; b=UgwrNjoFeSLMA2yrz0ICcyQpKYbwITV1IUxFMB7xUVpUX9/0VE77O2SxFdUMRJRZISJml9 GWEJIXEKh5ahEJ4ftMIXp576Pm53WptK65F62ccYQi/PRi99qfZBkNci77dimTmYECcqce tQ7YrwpYvzu84+kQGSR4WdRZTpoepTI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JVHKSDoI; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747676493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wMM+2s7qRrI63vS75vOPvvwet4wpZHCqIEycJ3tkwcQ=; b=JVHKSDoIF2JiC0TMWsn8ztbtKGohy65mn/dyW5Gj2vwC8uDtdUQCriXE0GuWfnD1Gfut86 LBesMRdn4KZ4qZeKYcz3dttFGK6hD0KFDqUHdN7nnHdQtq0SLBiudkxKnuMeqXk+dcDvzU K+4/lGSlynZ8Hqwx/3GBpflRCMwVi58= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-hz6wAmsWPjOhNRc6kA0NFA-1; Mon, 19 May 2025 13:41:31 -0400 X-MC-Unique: hz6wAmsWPjOhNRc6kA0NFA-1 X-Mimecast-MFC-AGG-ID: hz6wAmsWPjOhNRc6kA0NFA_1747676490 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-442f4a3851fso42154745e9.1 for ; Mon, 19 May 2025 10:41:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747676490; x=1748281290; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wMM+2s7qRrI63vS75vOPvvwet4wpZHCqIEycJ3tkwcQ=; b=Gu9BZ00vWWob3tlOLOyvmNcGWEWyQDL+Z/QRgirX0+zakcsbv/ub/giPYDHzxAz44J fJkIckB0pTAVmyeBqcQQtUIIsLG1TZX22ALu4T1L2gxvgagCzvPN6/wt5NuQVnC1/eV+ 2ccL2hq8v85HOZaYYMXj8UXc07V2dMe2Xrs9OPkobkgOkdZMIo3DFFSDgQeOTX2tfAtD fiMdUecexUYU6U4+kZoQQunI3+526IU6hG/mcAvf5CezzmjD1Hz3fyc6iW+9C9rMk2bf 9P+BAhHInxIUWti3qxyJdu562+/LbXXDm2ibziwtE7XprPH4nDcTAV1m/GqZtA3lO7wQ mXNg== X-Forwarded-Encrypted: i=1; AJvYcCVlK0A8Hugmtmz1PL6GXbBJVC+FrL8PtXbFhpfKX7MZ0jwT4oYEuNYQZtG0xjS84kUWyLRSjo2uoQ==@kvack.org X-Gm-Message-State: AOJu0YwIgbsTmCLioObVQSmh5w9GcFtc67lBFEj8hMIyTLl2RNORT7P/ 2pNfMHqjz18HoL0zwh013Ro2e0mnIlb9ONjLdrsSx+cic+Z2l3pCmnvOsc/3alrdm978HskRiBq 147GpFK3aN46bCS6Xpj6TS8lpV4Wmman+izBYAlkQSGSnT1zKPchY X-Gm-Gg: ASbGncvTj/H+E95dVsBexYwUcC04Fo0hi3CNnQ5nnc7EOJ3SLw7vgw1y2dSkNhXjjt2 fRTTFCtYdPlqtZI82FbZBAfqaA4BMsUyurx8UVptL0hBdVIf4Z26+xDqOro+gao22pdDKdhFp7F xfyAtmWQjHPR03fDnUGGBXx1tw0Uy06bX+7BeKNbxqFVx6ILYju1VayyuLV25ZcFs03AWtBIXfi nsUUZhZ49MTaOn2ty23Isl5aRY5NiJmTTW0tgnnNVBshiCrv1WUf+q6uY4fsIlzRjZOXbB0+T63 tgBzDjDy9klRJwL97O+7zaeMOdVqXtFLcFTC30PVaKIg1rtOGCNT6He+XNP5FCfJKpqUBy2Wg+7 LCKWGLXhdTzrPxTLeLoflGWUHl1MKx+3aJgMIbiQ= X-Received: by 2002:a05:600c:890b:b0:442:ffaa:6681 with SMTP id 5b1f17b1804b1-442ffaa6b6fmr81952135e9.28.1747676490438; Mon, 19 May 2025 10:41:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWnl7TcWfLB3Pa4DO8nxRC3zmwg6w26E4L7l3KlQwq71GfgWS4BKAiZ5l2yF+Mtm8mxarnwQ== X-Received: by 2002:a05:600c:890b:b0:442:ffaa:6681 with SMTP id 5b1f17b1804b1-442ffaa6b6fmr81951945e9.28.1747676490062; Mon, 19 May 2025 10:41:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f8ab839esm177926295e9.17.2025.05.19.10.41.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 10:41:29 -0700 (PDT) Message-ID: <0306ba4f-e0fe-47df-8ffc-4439c01745b2@redhat.com> Date: Mon, 19 May 2025 19:41:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: ksm: refer to special VMAs via VM_SPECIAL in ksm_compatible() To: Lorenzo Stoakes , Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: putFb5bNCYOODv2pQwNIOsXJuAxc74_10tzzDavU8QM_1747676490 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: nk53aap9fqzm6aw9hgz87gtoqi4pj45d X-Rspamd-Queue-Id: A99738000D X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747676493-923359 X-HE-Meta: U2FsdGVkX1/YAxnz13t/VvJr9zDBjtbPOtLKxJWYsw0psXLObw8o0b3J9aONYyz38cOCjZxFk2ATBmGTNHy9d4uAC3UDpy7W4w1XkviNxiAP2LnoAPTYT54w4gRYBbJ2Bwqu3yDFXMfuW5/Z4QGjybaB2FG8skAru4ZcyyjcYwks3m1iuBqR9tgdASjgRUA8jKTws9QbvDU+XcqoMyRQn5811KUxiLn9ACdWMcBAEgAj2w9DdIWfWGMZw9mJNLCQ+JD06ZVXVlr6fQtuyZMCshhxxmCDEiD7n/BNjTAwEdOBczOgNzKlmpvcQ/F8H9ywYoHBP2Xjpnuci3VcaItuNOEhSICz8ckAEFLQYrZehDkUSBE8dVdCP460sPctJP6UDg2iJypctRWJCe8u9GCvMcMbD8GphLnbYWm4cQtkBZ3z0qvTghMxKACX/X6s199YKjRXS7JFG6fkMp9hroTFkDLDSzmLTn6yEdgyz1UDEqkqxGt0241InXezpPm3lddrJxQpV9bpHlR/nDfST0IWFsd4qZD9aGyBhdadFnDsyMvJv2l9wdOR/4eP5ZNevT5UfKpetxgcM4eCkQrSHw31q+srUxCoCp8YsyxbCVk+24ZcufbKVs7T9HXZno/RH8SrzX9r+hPwsFQVZygbfGza2FHVNu02kZOquhPm4rOFewudyuje0xypXtHPJe3H6uRwXkijxg0tHS5oImZMOmfRiOgZmuGVSszy80EsDvUR9szrAFzu/N3pVCBj2TUVOlzOEsiAiib9JEyUHLbzq7PZHsga2akTbQ10Elze+swfePixyc6XeVlzIsJMfwHmmoiIcTOtZdq6rH7xfXTnN1D1tSgY5Fcjw4ygzEJbJ9uCJWGBpapvSplQQVxtNdhB1X9OyJ7jcB9Y9dtMy0c+Ry64qsQ51nOJkU1zMEmLcr/czJTMt76kyshHW3tAZQrWtccJ8TKtAMVmw0Mp8wc4SX7 z37Wll6y se4e5o8/ydCSRdL7enuOp7Dsv7bYoVgbvGlFXeRSRs/+RZkT/QILsdEnfN8gu6ApdkXf2mtiAqh4fjKegmGsrNieuEEWlmRzSHS2IjAFY6d4HyeZjoRQp3r1kBiV1IrGxQwvdxUfnb6cksAR9iCAtdTXHdHdS1SRb+OmfryZm1bPQB0PscLpNxKnoYKERzc3yalFw9PjtsNXjVgF7at2gFNs6LbNinISWU/X4NO3Daqmi+f2TbjM7JToSVUApNn8IMq9iNoZ4vhH+MsB+Vb8Cx3BPvo5/jcDqBVYFl7mnXUu3xR8BL+ncK6IgGtBPa+JsDHGgW4C3nZwujk89xJwkth1///AUzQHhD/FaCRKEaebYlYTldo2YzUKfiwaY+HMRNYSNkcYc0OQMiybn+0SJJebOKX5pf6ri9ZmVZexABc89lnbqBUH1i4Uk809tdM6Rh2SP1g55JXE8DOv/hSifxhr/nUx46GBh/TFYhAjgWQWTJY5Ri0RDzce/qQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.05.25 10:51, Lorenzo Stoakes wrote: > There's no need to spell out all the special cases, also doing it this way > makes it absolutely clear that we preclude unmergeable VMAs in general, and > puts the other excluded flags in stark and clear contrast. > > Signed-off-by: Lorenzo Stoakes > --- > mm/ksm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 08d486f188ff..d0c763abd499 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -679,9 +679,8 @@ static int break_ksm(struct vm_area_struct *vma, unsigned long addr, bool lock_v > > static bool ksm_compatible(const struct file *file, vm_flags_t vm_flags) > { > - if (vm_flags & (VM_SHARED | VM_MAYSHARE | VM_PFNMAP | > - VM_IO | VM_DONTEXPAND | VM_HUGETLB | > - VM_MIXEDMAP | VM_DROPPABLE)) > + if (vm_flags & (VM_SHARED | VM_MAYSHARE | VM_SPECIAL | > + VM_HUGETLB | VM_DROPPABLE)) > return false; /* just ignore the advice */ Stumbled over that recently myself ... (grepping for VM_SPECIAL does not return many results) Acked-by: David Hildenbrand -- Cheers, David / dhildenb