From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 228B6C5B549 for ; Fri, 6 Jun 2025 07:56:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB3B36B008C; Fri, 6 Jun 2025 03:56:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5B1A6B0092; Fri, 6 Jun 2025 03:56:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 922E76B0093; Fri, 6 Jun 2025 03:56:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 700AB6B008C for ; Fri, 6 Jun 2025 03:56:25 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 19F081A0241 for ; Fri, 6 Jun 2025 07:56:25 +0000 (UTC) X-FDA: 83524218330.12.30AFD11 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 65A1310000E for ; Fri, 6 Jun 2025 07:56:22 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TM5qELlp; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749196582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DHTEvwPHN4tR3d4e3BX0ymgMjtm1i84F6Rax2a+2GJM=; b=lJfKIRhk1cER41iUda/sEKiZdVjvls5dRK3+1Li4ReOYDU6FnTNp5EjopqHDoU6UEY3C+J 1nMdBpkqvnTzpVGg2sENbOs0+4gzYR0oAp2wWW/jkE1uWAe6UxZtyUAQsJI7713vIwqUOs 04GXlSIiOoLjyfLFbkQJ4hVXeszzKlo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TM5qELlp; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749196582; a=rsa-sha256; cv=none; b=VUwweRT/dlyP8t30fQUx/tFCO+FClBZM/KEggNIbBR67I/0f7O2ehDcC/Ny0PsEEMd8uXn iQKv94sHLOCTBhFqmPvuPIpVTHrSonW5JKJ1L0Le5WMNTyYxwL301uQ2fM7RA+G9xKXZlr 7HlGBFhQvnxKDE7BDMYiBWiTROWYw90= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749196581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DHTEvwPHN4tR3d4e3BX0ymgMjtm1i84F6Rax2a+2GJM=; b=TM5qELlpeWogA6i9eUfPCWtNe11b163D5+2Ihdlkr+uHtgwgz/ospKkACcTOy6+e1ezi6k T13a99yWqKCQsIwIOcteUEVWxEEHlBHAaOajq3Zp6HD5gy+T50g3GPjtHMHmvUhcJSFpWp CuSZkIdJPEeCEXDuOHCLNR747KoPFBM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-d--NR3sjNeaYwJwLVQEkqA-1; Fri, 06 Jun 2025 03:56:20 -0400 X-MC-Unique: d--NR3sjNeaYwJwLVQEkqA-1 X-Mimecast-MFC-AGG-ID: d--NR3sjNeaYwJwLVQEkqA_1749196579 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43eed325461so10659705e9.3 for ; Fri, 06 Jun 2025 00:56:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749196579; x=1749801379; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DHTEvwPHN4tR3d4e3BX0ymgMjtm1i84F6Rax2a+2GJM=; b=aRDE6kKmMy9DakfhExj4p4rBbuGHads3z1n+JLAAWc7NIKiq+OFlyY5DzcUF7lvRTl CPa4svD+KNDnvn1MVe7awlo2a+ZM9zCMyXi93Qa1pCl2oBJK2imlEW9GG+aWnHWhFJ1d UHLITh23SiPgEe6dqPV76FKgXuAPOPZGcqiZDZhNfG/y20PoXJZYCXWfB6RGhznR6a2f yMxaFP8yCiNjwxUtoVzzllemqaIUCwh8tjYBDbyiaTYlNx64ylaDhfoALnyy4pPhyuJM KOoTs6AR4BAMSf6MzOYT/ls4m1c4vVt1/J9TQuLemwTzqiqX6zDfOHUGXnc683NDK6Fz T3Ew== X-Forwarded-Encrypted: i=1; AJvYcCXmioSOyx+PKOhV5q78NkrPFUKIbH6OeJtTjLg/LtD2CtU5zKHXL2QyYOHnVkPHm/IZgfbYhoZ8jw==@kvack.org X-Gm-Message-State: AOJu0Ywo96Rn4zsL3v/24VoqRRguvkmjBPWp0cjU13XgsHzukeLQH1JE 8jBOtfUyUGwtKJ0glW8eei5ucOgvCur1dqrLwo3OkRH0vaWRl7aGGkx1TLWeRZ17WkHjWkvVjrO f3btaq+3CU/PhvMAr3OAQXaCPxeD7mXhh7mgOBPQUdGOppMDE9R2y X-Gm-Gg: ASbGncvvh251qmdud2EBpvr0wulfzQfmgTIvzpo1AHZHdasYZv3vJdIdLyFDp4x6Vlg NGXEk3Fi1uTfC0JYGD0K3DKMm4l320piqnNPRNQxrKUZaQPKJrxj/aYYgN3uJAH02dG4GjC6oPo fASBlUxFEPlhJAwyVWpaK5Zu0xm25mktcBSp691dOPf0ILdrFRNwJtsdOEidsDw1NzeXYgnKjp1 vJX5EK6xzUowze5+Xe61aSgBnFaCH/0MhzF3Z72s7Qg8iAs4H6TlP4v0v9+rGflj4ERxubs7zpH zsL/R6LP8X3fG1Y/itDS3WBAsjaf9Zzc2Qx15nbR5/s= X-Received: by 2002:a05:600c:464a:b0:441:d438:4ea5 with SMTP id 5b1f17b1804b1-4520151f224mr13917285e9.20.1749196579019; Fri, 06 Jun 2025 00:56:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoAWl6xmzQlKUbzmkpwMzxJ3AWGgLpfQumR6MVXDrU3ee0bRuuHVTE9M0lhPvQ+btiD5LvMA== X-Received: by 2002:a05:600c:464a:b0:441:d438:4ea5 with SMTP id 5b1f17b1804b1-4520151f224mr13917105e9.20.1749196578524; Fri, 06 Jun 2025 00:56:18 -0700 (PDT) Received: from [192.168.3.141] (p57a1a6a5.dip0.t-ipconnect.de. [87.161.166.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452730b9b27sm12529925e9.23.2025.06.06.00.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 00:56:18 -0700 (PDT) Message-ID: <02fd89c3-d0f9-412c-8f31-d343803c0982@redhat.com> Date: Fri, 6 Jun 2025 09:56:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] kernel BUG in try_to_unmap_one (2) To: Jinjiang Tu , syzbot , Liam.Howlett@oracle.com, akpm@linux-foundation.org, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, riel@surriel.com, syzkaller-bugs@googlegroups.com, vbabka@suse.cz, Jens Axboe , Catalin Marinas References: <68412d57.050a0220.2461cf.000e.GAE@google.com> <4fc2c008-2384-4d94-b1bf-f0a076585a4a@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ItgpyzkkcHqynSCBOYe9PMmqJTK0NoxPaIy5eKVW9EY_1749196579 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 65A1310000E X-Stat-Signature: sz97y8t85gkxt9x9n5pbg9h67ba4bajs X-Rspam-User: X-HE-Tag: 1749196582-499606 X-HE-Meta: U2FsdGVkX1816PR8Re/+A7P0e8Y2nuu4L58oA10vVwUk7HNphWi4487VaHKetYnbPRcV4RqOQ+71yMTnkv6Dj5CebWIBP35EvAv7rgPR0tNffu+0ARTs7j+VSUSbctblhYZEHlfdu2PSxnjrSLHeX3L4V9MyBix05XeqFb0x9lkwVql00UMaFcZhqzTvdI0ZRfNokKsDuRe7Mb86T5nnF+2Fo+fhALtnztoq60D075B8itrfAc+CTUGKAayx/C+reSzGJjcZnyHyO7PcUlTSenpjxD8/4oAVvED56pfBWnSqPK+QV6aSrx6Tw7syo12uOLJ3Aq7ndgFhiml89tslB7UiTyQqKd7fN/Q8PcT9JKTqoBMgqNclOu2kzNGzQcIPT7vvJOv5IONhGy9M0VeqF70m0Qkl36b+aBK/gAPrCsd7lJuqsqsepd8WaaadbnXq87xKKqDD2GqIL4WgQ9arVdhWI6nAfXDn3yH0RkSPUIQtZz6jlHeJLGxzYTH/LvVi2REqQ3TLvTeRI7wkrhHrwmizWmX2x6ZqVH6ZLPnQ/Po2CzoiING70WoBmtOsKb1Dhfu6d0eghtI/fDHybUsAVO2mQTTF5ABxk6oX7eE5w2II9AXB0yZOluL3pjs5GwrlEsLooRKecOlJ9Iu8d3HN1iFzgEENIv3bQwhMQUMGQ+LQOu330PnXhO0B5P0BmG27Rc+7FNdkjXSmXrF6xQ7MjNQSuS8BARqr1Z4YvHcJw3oWjLRmGLI/maFEKqjqHaHu+uI1Cw15CPCQZv96O8fOx32bMIFXMk+ZRSkr+32Ba/hnvBTUiJ8XCakyHSac+eRGw6vogl52lo2lrvNbCOk+nb5Ogz3/uCVvX7WWUmr3rfUCnnRs71ATf8CEPOScDE6tCLk5kzcYxQqe9BG+oy7H0Zyf47JZ5fL4CJgeBZQBslQ6Bf3DZo3DH5qJxT4/IgE3EdLm/Cf9sisZqHAGRJG DHwFVsEA ufYhDknzSwh4/+eLhKZ8wEpvBCnd4BFa/ccw4hsY/vQ/K4na1TemQyzlVtTuP1w7mx2cg0hvcUcygNmpuLAwZ4XQEYPaadlT6W/+hB4MDoBgVO8UTGcHdPMRVJ07Hauo1MpZlU2NWoSc1vquLIYFad0Me15LP5PoCPP38TIN4PwQMmapOdR/eu4gQYgrsJhvEfW4Tirgx6ljHFZ8u/5fbLEd0wiUV+fYO/Ytyqu5TmeiIXsHrxls6I6xdXnHqceSHkYBIgfkuazuaOe+mbDoW3x1Pcr9hE0mzqUVyzVutsxcV41Igi3ZqyhB6PF/nHXXFrpkzBOOAR/9Biww0BlFCIpk7gnBbChwdsBAywq053VsSro+LcVb4tZzaWcTtj7lwyjfUSObg+ILL3ySKsLE6I8WN6f4xxRRgs++O1EE+ldONZ+fJko0qZKkPjkfxQvkjJ1tUpAESPT0+GstnDHpKLv5t12LRhC0Ew1MrihwzKDTQDtH7mQZ2to4lvwWyMUChV2jsTuKj3reHgs1bI/p66RS83bwITNpI0XciO9gMoOKBdHsPh1Q3pffQh7TN7XABWZRYBzgCTGf9eqGQfy9MlMMEyhVNYRAtIfmy+OYuYzpRew0ePBfbHGuYFyS1Esf979Cj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 09:18, Jinjiang Tu wrote: > > 在 2025/6/5 14:37, David Hildenbrand 写道: >> On 05.06.25 08:27, David Hildenbrand wrote: >>> On 05.06.25 08:11, David Hildenbrand wrote: >>>> On 05.06.25 07:38, syzbot wrote: >>>>> Hello, >>>>> >>>>> syzbot found the following issue on: >>>>> >>>>> HEAD commit:    d7fa1af5b33e Merge branch 'for-next/core' into >>>>> for-kernelci >>>> >>>> Hmmm, another very odd page-table mapping related problem on that tree >>>> found on arm64 only: >>> >>> In this particular reproducer we seem to be having MADV_HUGEPAGE and >>> io_uring_setup() be racing with MADV_HWPOISON, MADV_PAGEOUT and >>> io_uring_register(IORING_REGISTER_BUFFERS). >>> >>> I assume the issue is related to MADV_HWPOISON, MADV_PAGEOUT and >>> io_uring_register racing, only. I suspect MADV_HWPOISON is trying to >>> split a THP, while MADV_PAGEOUT tries paging it out. >>> >>> IORING_REGISTER_BUFFERS ends up in >>> io_sqe_buffers_register->io_sqe_buffer_register where we GUP-fast and >>> try coalescing buffers. >>> >>> And something about THPs is not particularly happy :) >>> >> >> Not sure if realted to io_uring. >> >> unmap_poisoned_folio() calls try_to_unmap() without TTU_SPLIT_HUGE_PMD. >> >> When called from memory_failure(), we make sure to never call it on a >> large folio: WARN_ON(folio_test_large(folio)); >> >> However, from shrink_folio_list() we might call unmap_poisoned_folio() >> on a large folio, which doesn't work if it is still PMD-mapped. Maybe >> passing TTU_SPLIT_HUGE_PMD would fix it. >> > TTU_SPLIT_HUGE_PMD only converts the PMD-mapped THP to PTE-mapped THP, and may trigger the below WARN_ON_ONCE in try_to_unmap_one. > > if (PageHWPoison(subpage) && (flags & TTU_HWPOISON)) { > ... > } else if (likely(pte_present(pteval)) && pte_unused(pteval) && > !userfaultfd_armed(vma)) { > .... > } else if (folio_test_anon(folio)) { > swp_entry_t entry = page_swap_entry(subpage); > pte_t swp_pte; > /* > * Store the swap location in the pte. > * See handle_pte_fault() ... > */ > if (unlikely(folio_test_swapbacked(folio) != > folio_test_swapcache(folio))) { > WARN_ON_ONCE(1);          // here. if the subpage isn't hwposioned, and we hasn't call add_to_swap() for the THP > goto walk_abort; > } This makes me wonder if we should start splitting up try_to_unmap(), to handle the individual cases more cleanly at some point ... Maybe for now something like: diff --git a/mm/memory-failure.c b/mm/memory-failure.c index b91a33fb6c694..995486a3ff4d2 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1566,6 +1566,14 @@ int unmap_poisoned_folio(struct folio *folio, unsigned long pfn, bool must_kill) enum ttu_flags ttu = TTU_IGNORE_MLOCK | TTU_SYNC | TTU_HWPOISON; struct address_space *mapping; + /* + * try_to_unmap() cannot deal with some subpages of an anon folio + * not being hwpoisoned: we cannot unmap them without swap. + */ + if (folio_test_large(folio) && !folio_test_hugetlb(folio) && + folio_test_anon(folio) && !folio_test_swapcache(folio)) + return -EBUSY; + if (folio_test_swapcache(folio)) { pr_err("%#lx: keeping poisoned page in swap cache\n", pfn); ttu &= ~TTU_HWPOISON; > > If we want to unmap in shrink_folio_list, we have to try_to_split_thp_page() like memory_failure(). But it't too complicated, maybe just skip the > hwpoisoned folio is enough? If the folio is accessed again, memory_failure will be trigerred again and kill the accessing process since the folio > has be hwpoisoned. Maybe we should try splitting in there? But staring at shrink_folio_list(), not that easy. We could return -E2BIG and let the caller try splitting, to then retry. -- Cheers, David / dhildenb