From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: 'Michal Hocko' <mhocko@kernel.org>,
'Andrew Morton' <akpm@linux-foundation.org>
Cc: 'Linus Torvalds' <torvalds@linux-foundation.org>,
'Johannes Weiner' <hannes@cmpxchg.org>,
'Mel Gorman' <mgorman@suse.de>,
'David Rientjes' <rientjes@google.com>,
'Tetsuo Handa' <penguin-kernel@I-love.SAKURA.ne.jp>,
'Joonsoo Kim' <js1304@gmail.com>,
'Vlastimil Babka' <vbabka@suse.cz>,
linux-mm@kvack.org, 'LKML' <linux-kernel@vger.kernel.org>,
'Michal Hocko' <mhocko@suse.com>
Subject: Re: [PATCH 1/2] mmotm: mm-oom-rework-oom-detection-fix
Date: Fri, 13 May 2016 11:59:28 +0800 [thread overview]
Message-ID: <02ed01d1accb$d92e16f0$8b8a44d0$@alibaba-inc.com> (raw)
In-Reply-To: <1463051677-29418-2-git-send-email-mhocko@kernel.org>
> From: Michal Hocko <mhocko@suse.com>
>
> watermark check should use classzone_idx rather than high_zoneidx
> to check reserves against the correct (preferred) zone.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0d9008042efa..620ec002aea2 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3496,7 +3496,7 @@ should_reclaim_retry(gfp_t gfp_mask, unsigned order,
> * available?
> */
> if (__zone_watermark_ok(zone, order, min_wmark_pages(zone),
> - ac->high_zoneidx, alloc_flags, available)) {
> + ac_classzone_idx(ac), alloc_flags, available)) {
> /*
> * If we didn't make any progress and have a lot of
> * dirty + writeback pages then we should wait for
> --
> 2.8.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-13 3:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 11:14 [PATCH 0/2] oom detection fixups Michal Hocko
2016-05-12 11:14 ` [PATCH 1/2] mmotm: mm-oom-rework-oom-detection-fix Michal Hocko
2016-05-13 3:59 ` Hillf Danton [this message]
2016-05-12 11:14 ` [PATCH 2/2] mm, oom: protect !costly allocations some more for !CONFIG_COMPACTION Michal Hocko
2016-05-13 4:05 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02ed01d1accb$d92e16f0$8b8a44d0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox