From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F43C77B60 for ; Sat, 25 Mar 2023 06:38:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 746086B0071; Sat, 25 Mar 2023 02:38:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F61E6B0074; Sat, 25 Mar 2023 02:38:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BDA46B0075; Sat, 25 Mar 2023 02:38:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4FF676B0071 for ; Sat, 25 Mar 2023 02:38:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 215CF1A0101 for ; Sat, 25 Mar 2023 06:38:24 +0000 (UTC) X-FDA: 80606466528.27.4C7523C Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id C2AEE140005 for ; Sat, 25 Mar 2023 06:38:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679726302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vMRagJ+TolJoXRtNbkbaI6/K/M3uzTQy3W9irSiQkJo=; b=npuH+wf81k+IJSXLceu5UR+u2isZ50VTs0Louyu9SsAN8/RZjXnlDBoZSvmhxPBUe9xRZW LOgocauu4RjRfeNyKonAPVAN2ddZPLk7v++M3iuEeIN5HgxiKm9+LpjRGBkumlp3shapqh IW+vBOaG3U3M792nWLvebS5oirSEPKs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679726302; a=rsa-sha256; cv=none; b=alsFYWzJOUBjKdlQY3tGXB58UROP1Mum8eMzCAPhmk1zc9WT82CYfdcNA0xMH93F2Sdl24 QQHJ50/aaIfrZRrXke8ZltPuJKgbmdStZX68dFmtIo9rGLz4wCe+ld5PfFeMGN0s0ejGpx CKQuAvUPmf6RNULVeqHLTay0GOilVE8= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Pk8V53f06zKvCx; Sat, 25 Mar 2023 14:35:57 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sat, 25 Mar 2023 14:38:16 +0800 Message-ID: <02dd2437-32fa-31aa-4ff3-b33a058f2363@huawei.com> Date: Sat, 25 Mar 2023 14:38:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 05/14] ia64: don't allow users to override ARCH_FORCE_MAX_ORDER Content-Language: en-US To: Mike Rapoport , Andrew Morton CC: Arnd Bergmann , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , Zi Yan , , , , , , , , , , References: <20230325060828.2662773-1-rppt@kernel.org> <20230325060828.2662773-6-rppt@kernel.org> From: Kefeng Wang In-Reply-To: <20230325060828.2662773-6-rppt@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: C2AEE140005 X-Stat-Signature: t46dikpex41qpb1afirk1qtx1hwdfmg3 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679726301-724724 X-HE-Meta: U2FsdGVkX1+Tm9zmUNmrQv7XT5PFNC8TbYStgdzkPqlFS1TPxya7tCSzjIN1lb7tEUgleRFpD5UKMHylpfOlMAZ1oMddWaZfR+27jU+yOrgQG/4lHHjWQ1zt47fhnQ8ku6kEYMlkopXpWIZRwSKXXplHQqswxLEFmagHDxoZaLNFCPwS6vnSHaH50fLAyB5IgXrXQPVcUxylKc2IkEAjKpb53JoISGRGpZ4ykQtaWhIfQIbCsFGvbr880Xz3E2RVHa92ebI5v01R6lFt6JRVu+G5xG9w99uNzKy55glQGbUPpiyRaHgWbESUhrdnZNG9RARk0UWop9VRszO1Kk8QMzQEUC3R3t8oexNTS+TDrrfye9d2BVCXQCpS2uOldKMQaf6H9Gd52o+aGtfmJk4I7nPumRUXa4cnObnVtvfsOdXil8x8rh9pVN39IBKVWwqnCoG19vMjH8HYBoOAwA1psMVd63ytNjVeq2+J1u9rbq5qNFrAIHF+yMipl0qaDQHl5172cslBl1dgcLhxZH39CdSZhnRR8kEW+xS1ciKYVo+YOEsFhk1voLU4TEydHDVuQ3PDvX0zsVc9uAb+J5WAk1O1YnP8VEK2JowlGDBeEiKt/S8pgzsHyTjCqvXe2RyehX7yZQYFs1C8KNnLGO/RN2Lh8HCpVD+XoxDJRi78OR7IMGyWjU5e+pH4LSyyrmF5bL2bg7TzFWemZ8d6Xz2+ZqwigC6GR51f1MuFrrcRRJByqJiachOQwA0opx7AW5Zc4TrGdh/wz1/ESXisp1Yv6Uikk/0zEL0E2X6NEVp4hf/xSdZAZrN5CALCXOO4dPAii2YulGLVyZaeZWq5toqpa5FGgQedddAfKMsyKGQI0paXRRJV5Cr6FTqYOyUHHkYIbXjzUy6gBu9xlHl0PlMY1a38hJJDjwCYU7FQtYjcduESKZEQobsyZaSJPbjqo4hl1Qd3fKuy9dLkqBx9uix m/bO9/qj MdBl5bKiMg5UVOUNw7z/3+sdKH6V1WXD8k+Vsi8tKkk2XzvhpHv4epWyXEQgJQj9hD98oMWHvMy4SuZ6bZvfLwfX2ccpsYtwXpnpTrIiEh/JgV/Z2uMiDBBdMwZ6kucMN3tULa3ykKFvN6bm+yrmcPdyNlDWk2EvcrgmQUTGE3G8LzZ4/KFsbeeg/ongWxWO7WPd5buxNTGSx720MHk48Ge4lmbM4DerYnnWh53pyBHvf1TqgfnSApZQCIdZv56qBrdxh+kphqE1WjMNXitMR2KephLxiySeep5Lb4nVUDmdl+gNoTYw7zxEosWl/JcjSaZbybVUwNd+aLe1MckOFYnzSoA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/25 14:08, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > It is enough to keep default values for base and huge pages without > letting users to override ARCH_FORCE_MAX_ORDER. > > Drop the prompt to make the option unvisible in *config. > > Acked-by: Kirill A. Shutemov > Reviewed-by: Zi Yan > Signed-off-by: Mike Rapoport (IBM) > --- > arch/ia64/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index 0d2f41fa56ee..b61437cae162 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -202,8 +202,7 @@ config IA64_CYCLONE > If you're unsure, answer N. > > config ARCH_FORCE_MAX_ORDER > - int "MAX_ORDER (10 - 16)" if !HUGETLB_PAGE > - range 10 16 if !HUGETLB_PAGE > + int > default "16" if HUGETLB_PAGE > default "10" > It seems that we could drop the following part? diff --git a/arch/ia64/include/asm/sparsemem.h b/arch/ia64/include/asm/sparsemem.h index a58f8b466d96..18187551b183 100644 --- a/arch/ia64/include/asm/sparsemem.h +++ b/arch/ia64/include/asm/sparsemem.h @@ -11,11 +11,6 @@ #define SECTION_SIZE_BITS (30) #define MAX_PHYSMEM_BITS (50) -#ifdef CONFIG_ARCH_FORCE_MAX_ORDER -#if (CONFIG_ARCH_FORCE_MAX_ORDER + PAGE_SHIFT > SECTION_SIZE_BITS) -#undef SECTION_SIZE_BITS -#define SECTION_SIZE_BITS (CONFIG_ARCH_FORCE_MAX_ORDER + PAGE_SHIFT) -#endif #endif